`AwaitAssert` returns on its FIRST success, so an assertion that is already true at
t=0 passes instantly and spends none of its duration. All three sites asserted an
absence against a collection that starts empty, so none of them ever gave the
handler the time their comments claimed.
Replaced with mailbox-ordering positive controls rather than sleeps:
- `RouteNativeAlarmAck_unknown_node_is_dropped` — follow the unmapped ack with a
MAPPED one. The host forwards via `Tell` and the child handles `RouteAlarmAck`
with `ReceiveAsync` (which suspends its own mailbox), so once the control reaches
the driver the unmapped one has provably been handled.
- `RouteNativeAlarmAck_on_non_primary_is_dropped` — the role itself is the control:
return the node to Primary and re-send. Comments (`gated` / `control`) are the
discriminator, so a leaked ack is visible rather than merged into a count.
- `PeerProbeSupervisorTests.Single_node_snapshot_spawns_no_children` — a FOURTH site
the issue did not list. It says the other `ChildCount.ShouldBe(0)` waits are each
preceded by a `ShouldBe(1)`; that is true of three of the four, but not this one,
which asserts the initial state. Now followed by a two-node snapshot: the count
reaching 1 proves the single-node snapshot was processed, and a local-node child
would have made it 2.
The issue warned these may turn red, which would be a real defect surfacing. They
did not — the routing is correct. Proven by breaking it deliberately instead:
disabling the Primary gate reddens the Secondary test, and routing unmapped ids to
an arbitrary mapping reddens the unknown-node test. Under the old form both breaks
passed.
Joseph Doherty
240d7aa8aa