Phase 2 PR 61 -- Close V1_ARCHIVE_STATUS.md: Streams D + E done #60

dohertj2 · 2026-04-18T23:22:55-04:00

dohertj2 commented

2026-04-18 23:22:55 -04:00

Summary

Documentation-closure PR for the two Phase 2 items that were pending on the task list: Stream D (retire legacy Host) and Stream E (parity validation). Both have been effectively done in earlier PRs; this PR updates the doc to reflect reality.

The v1 archive deletion itself happened across earlier PRs — PR 2 on phase-2-stream-d archive-marked the four v1 projects (IsTestProject=false); Phase 3 PR 18 deleted the source trees. Stale bin//obj/ residue on disk is cosmetic (git doesn't track it). No source code changed in this PR.

What changed

docs/v2/V1_ARCHIVE_STATUS.md rewritten from pre-work plan prose to a CLOSED retrospective: checks off all 5 deleted v1 directories, names the parity-bar tests filling the role the 494 v1 tests originally held (Driver.Galaxy.E2E cross-FX subprocess parity + stability-findings regression, per-component *.Tests, Driver.Modbus.IntegrationTests with DL205 + S7-1500 + Mitsubishi sim coverage, LiveStack smoke tests), and documents the closure timeline.

Validation

dotnet build ZB.MOM.WW.OtOpcUa.slnx: 0 errors, 200 warnings (pre-existing xunit1051 advisories)
No test run needed — no source change
Tasks #16 and #17 can now be marked completed

Test plan

Solution builds clean
All 5 v1 directories absent from working tree
Doc accurately reflects the current state

## Summary Documentation-closure PR for the two Phase 2 items that were pending on the task list: Stream D (retire legacy Host) and Stream E (parity validation). Both have been effectively done in earlier PRs; this PR updates the doc to reflect reality. The v1 archive deletion itself happened across earlier PRs — PR 2 on `phase-2-stream-d` archive-marked the four v1 projects (`IsTestProject=false`); Phase 3 PR 18 deleted the source trees. Stale `bin/`/`obj/` residue on disk is cosmetic (git doesn't track it). No source code changed in this PR. ## What changed - `docs/v2/V1_ARCHIVE_STATUS.md` rewritten from pre-work plan prose to a **CLOSED retrospective**: checks off all 5 deleted v1 directories, names the parity-bar tests filling the role the 494 v1 tests originally held (Driver.Galaxy.E2E cross-FX subprocess parity + stability-findings regression, per-component `*.Tests`, Driver.Modbus.IntegrationTests with DL205 + S7-1500 + Mitsubishi sim coverage, LiveStack smoke tests), and documents the closure timeline. ## Validation - `dotnet build ZB.MOM.WW.OtOpcUa.slnx`: **0 errors**, 200 warnings (pre-existing xunit1051 advisories) - No test run needed — no source change - Tasks #16 and #17 can now be marked completed ## Test plan - [x] Solution builds clean - [x] All 5 v1 directories absent from working tree - [x] Doc accurately reflects the current state

dohertj2 added 1 commit 2026-04-18 23:22:56 -04:00

Phase 2 PR 61 -- Close V1_ARCHIVE_STATUS.md; Phase 2 Streams D + E done. Purely a documentation-closure PR. The v1 archive deletion itself happened across earlier PRs: PR 2 on phase-2-stream-d archive-marked the four v1 projects (IsTestProject=false so dotnet test slnx bypassed them); Phase 3 PR 18 deleted the archived project source trees. What remained on disk was stale bin/obj residue from pre-deletion builds -- git never tracked those, so removing them from the working tree is cosmetic only (no source-file diff in this PR). What this PR actually changes: V1_ARCHIVE_STATUS.md is rewritten from 'Deletion plan (Phase 2 PR 3)' pre-work prose to a CLOSED retrospective that (a) lists all five v1 directories as deleted with check-marks (src/OtOpcUa.Host, src/Historian.Aveva, tests/Historian.Aveva.Tests, tests/Tests.v1Archive, tests/IntegrationTests), (b) names the parity-bar tests that now fill the role the 494 v1 tests originally held (Driver.Galaxy.E2E cross-FX subprocess parity + stability-findings regression, per-component *.Tests projects, Driver.Modbus.IntegrationTests, LiveStack/ smoke tests), and (c) gives the closure timeline connecting PR 2 -> Phase 3 PR 18 -> this PR 61. Also added the Modbus TCP driver family as parity coverage that didn't exist in v1 (DL205 + S7-1500 + Mitsubishi MELSEC via pymodbus sim). Stream D (retire legacy Host) has been effectively done since Phase 3 PR 18; Stream E (parity validation) is done since PR 2 landed the Driver.Galaxy.E2E project with HostSubprocessParityTests + HierarchyParityTests + StabilityFindingsRegressionTests. This PR exists to definitively close the two pending Phase 2 tasks on the task list and give future-me (or anyone picking up Phase 2 retrospectives) a single 'what actually happened' doc instead of a 'what we plan to do' prose that didn't match reality. dotnet build ZB.MOM.WW.OtOpcUa.slnx: 0 errors, 200 warnings (all xunit1051 cancellation-token analyzer advisories, unchanged from v2 tip). No test regressions -- no source code changed. 56d8af8bdb

dohertj2 merged commit 8150177296 into v2

2026-04-18 23:23:00 -04:00

dohertj2 referenced this issue from a commit

2026-04-18 23:23:02 -04:00

Merge pull request 'Phase 2 PR 61 -- Close V1_ARCHIVE_STATUS.md: Streams D + E done' (#60) from phase-2-pr61-scrub-v1-archive-residue into v2

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#60