fix(harness): deploy E2E tests pass against real SQL (misdiagnosed as emulation timing) #452

2026-07-15T06:43:25-04:00

dohertj2 commented

2026-07-15 06:43:25 -04:00

Integration-sweep follow-up #6 SQL leg. The '7 heavy E2E time out under emulated SQL' diagnosis was wrong — they'd never run against real SQL (in-memory ignores FKs). Two defects: (1) missing ServerCluster/ClusterNode seed → NodeDeploymentState FK fails → deploy never seals (added SeedDefaultClusterAsync + fixed DriverReconnect); (2) stale EquipmentId='eq-1' vs the EquipmentIdNotDerived validator (pre-existing on both providers). Added OTOPCUA_HARNESS_SQL_HOST/LDAP_HOST overrides for native-amd64 fixtures. 11/11 green vs native SQL; in-memory unregressed 12/12. Roslyn racing test = pre-existing flaky, left as-is.

dohertj2 added 1 commit 2026-07-15 06:43:26 -04:00

fix(harness): make deploy E2E tests pass against real SQL (seed cluster FKs)

v2-ci / build (pull_request) Successful in 4m23s

Details

v2-ci / unit-tests (pull_request) Failing after 10m14s

Details

859d63178a

Integration-sweep follow-up #6 (SQL leg). The sweep flagged 7 heavy 2-node
deploy/failover/reconnect E2E tests as 'time out under amd64-emulated SQL' and
suggested raising deadlines. That diagnosis was WRONG: run against real
(native-amd64) SQL on the Docker host, they still hang — even at 4x deadline.
Root cause is that these tests had never actually run against real SQL, only the
EF in-memory provider, which does NOT enforce foreign keys.

Two distinct defects, both hidden by in-memory:

1. Missing FK-parent seed (5 tests). The deploy records a NodeDeploymentState row
   per node, FK'd to ClusterNode (FK_NodeDeploymentState_ClusterNode_NodeId). The
   tests never seeded ServerCluster + ClusterNode, so on SQL each node-state INSERT
   throws and the deploy never seals (waits the full deadline regardless of size).
   Added TwoNodeClusterHarness.SeedDefaultClusterAsync (seeds a ServerCluster +
   a ClusterNode per node; Warm/NodeCount=2 to satisfy the SQL CHECK constraint
   CK_ServerCluster_RedundancyMode_NodeCount AND the ClusterEnabledNodeCountMismatch
   validator). Called it in DeployHappyPath x2 / Failover / FleetDiagnostics /
   EquipmentNamespace; fixed DriverReconnect to seed node B + NodeCount=2.

2. Stale EquipmentId (EquipmentNamespace test; pre-existing on BOTH providers).
   Seeded EquipmentId='eq-1', but the later-added EquipmentIdNotDerived validator
   requires EquipmentId == DeriveEquipmentId(EquipmentUuid) ('EQ-'+first 12 hex).
   Fixed the seed to a canonical id + matching UUID. Only surfaced once the FK fix
   let the deploy reach equipment validation.

Also added OTOPCUA_HARNESS_SQL_HOST / OTOPCUA_HARNESS_LDAP_HOST overrides so the
harness fixtures can run on the native-amd64 Docker host (avoids arm64 mssql
emulation entirely).

Verified: the 5 SQL-backed classes go 11/11 green vs native SQL; in-memory default
unregressed (12/12). RoslynVirtualTagEvaluatorTests racing test is a pre-existing
flaky race (not SQL-backed; passes in isolation) — left as-is.

dohertj2 merged commit 152a5645ad into master

2026-07-15 06:43:39 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#452