dohertj2/lmxopcua
1
0
Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

chore(core): flatten Historian sub-namespace to Core.Abstractions root #438

Closed
dohertj2 wants to merge 0 commits from chore/flatten-historian-abstractions-namespace into master
pull from: chore/flatten-historian-abstractions-namespace
merge into: dohertj2:master
Conversation 1 Commits - Files Changed -
dohertj2 commented 2026-07-13 18:29:12 -04:00
Owner
Copy Link
Copy Source

Fixes the pre-existing red InterfaceIndependenceTests.AllPublicTypes_LiveInRootNamespace (decision #59 flat-surface rule) by moving 4 continuous-historization types out of the drifted ...Core.Abstractions.Historian sub-namespace into the root, matching the 6 sibling files. Consumer usings dropped/retargeted. No behavioral change. Core.Abstractions 129/129, Runtime historian+DI 72/72, Gateway unit 102/102, solution build 0 errors.

Fixes the pre-existing red `InterfaceIndependenceTests.AllPublicTypes_LiveInRootNamespace` (decision #59 flat-surface rule) by moving 4 continuous-historization types out of the drifted `...Core.Abstractions.Historian` sub-namespace into the root, matching the 6 sibling files. Consumer usings dropped/retargeted. No behavioral change. Core.Abstractions 129/129, Runtime historian+DI 72/72, Gateway unit 102/102, solution build 0 errors.
dohertj2 added 1 commit 2026-07-13 18:29:13 -04:00
chore(core): flatten Historian sub-namespace to Core.Abstractions root
v2-ci / build (pull_request) Successful in 4m32s
Details
v2-ci / unit-tests (pull_request) Failing after 10m2s
Details
56ddf45e1c 
Four continuous-historization types (IHistorizationOutbox, HistorizationOutboxEntry,
IHistorianValueWriter/HistorizationValue, HistorizationCommitMode) drifted into a
ZB.MOM.WW.OtOpcUa.Core.Abstractions.Historian sub-namespace while the other six files
in the same folder correctly use the root namespace. This violated decision #59's
flat-public-surface rule and left InterfaceIndependenceTests.AllPublicTypes_LiveInRootNamespace
red on master (pre-existing, predates round-2 remediation).

Move all four to the root namespace and drop/retarget the now-redundant
'using ...Core.Abstractions.Historian;' in the ~11 consumers. No behavioral change.

Verified: Core.Abstractions.Tests 129/129 (was 128/129), Runtime.Tests Historian+DI 72/72,
Gateway driver unit 102/102, full solution build 0 errors.
dohertj2 commented 2026-07-13 18:29:29 -04:00
Author
Owner
Copy Link
Copy Source

Merged to master via --no-ff at 50e04707c8.

Merged to master via --no-ff at 50e04707c896377114bb001c9e440765cb378077.
dohertj2 closed this pull request 2026-07-13 18:29:29 -04:00
Some checks are pending
v2-ci / build (pull_request) Successful in 4m32s
Details
v2-ci / unit-tests (pull_request) Failing after 10m2s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#438
Delete Branch "chore/flatten-historian-abstractions-namespace"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?