dohertj2/lmxopcua
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

R2-09 Driver fleet batch (arch-review round 2) #437

Closed
dohertj2 wants to merge 0 commits from r2/09-driver-fleet-batch into master
pull from: r2/09-driver-fleet-batch
merge into: dohertj2:master
Conversation 1 Commits - Files Changed -
+2786 -355
dohertj2 commented 2026-07-13 12:47:03 -04:00
Owner
Copy Link
Copy Source

Round-2 arch-review plan R2-09 (findings 05/STAB-3/4/5/8/12/16/17, ResolveHost/CONV-4, onError — 6 PR-sized sub-batches, 29 tasks).

  • B1 STAB-3: ModbusTransportDesyncException + teardown-before-propagate (timeout / TxId-mismatch / truncated-frame; caller-cancel NOT torn down).
  • B2 STAB-4/5: AbCip per-runtime GetRuntimeLock serializing read/write; 4 FOCAS fixed-tree caches → ConcurrentDictionary.
  • B3: new ConnectionBackoff primitive + PollGroupEngine v2 (failure backoff + caller-token-filtered OCE catches, the STAB-14-class engine guard); onError→health + 30s backoff in all 5 poll drivers; S7 bespoke poll fork deleted onto the engine (fixes array-refire + drain-before-dispose), reconciled with R2-01's landed S7 EnsureConnectedAsync/fatal-classification.
  • B4 STAB-8: per-device ConnectionBackoff connect throttles (TwinCAT/FOCAS/AbCip).
  • B5 CONV-4: all 5 ResolveHost route through EquipmentTagRefResolver for correct per-host breaker isolation.
  • B6 STAB-16/17/12: TwinCAT replay-failure marks-dead + Bad + health-degrade + probe-retry; unsubscribe-vs-replay ownership re-check (no orphan ADS notification); cancellable RecycleClientAsync.

29/29 tasks, 0 deferred. Build clean (driver projects 0-warning); S7 254, Modbus 312+161, AbCip 336, AbLegacy 209, TwinCAT 189, FOCAS 265, Core.Abstractions 128 (+14 ConnectionBackoff +20 PollGroupEngine) all green. (One PRE-EXISTING unrelated InterfaceIndependence failure at base — Historian sub-namespace, not R2-09.) Plan: archreview/plans/R2-09-driver-fleet-batch-plan.md.

Round-2 arch-review plan **R2-09** (findings 05/STAB-3/4/5/8/12/16/17, ResolveHost/CONV-4, onError — 6 PR-sized sub-batches, 29 tasks). - **B1 STAB-3**: `ModbusTransportDesyncException` + teardown-before-propagate (timeout / TxId-mismatch / truncated-frame; caller-cancel NOT torn down). - **B2 STAB-4/5**: AbCip per-runtime `GetRuntimeLock` serializing read/write; 4 FOCAS fixed-tree caches → ConcurrentDictionary. - **B3**: new `ConnectionBackoff` primitive + **PollGroupEngine v2** (failure backoff + caller-token-filtered OCE catches, the STAB-14-class engine guard); onError→health + 30s backoff in all 5 poll drivers; **S7 bespoke poll fork deleted** onto the engine (fixes array-refire + drain-before-dispose), reconciled with R2-01's landed S7 EnsureConnectedAsync/fatal-classification. - **B4 STAB-8**: per-device ConnectionBackoff connect throttles (TwinCAT/FOCAS/AbCip). - **B5 CONV-4**: all 5 `ResolveHost` route through `EquipmentTagRefResolver` for correct per-host breaker isolation. - **B6 STAB-16/17/12**: TwinCAT replay-failure marks-dead + Bad + health-degrade + probe-retry; unsubscribe-vs-replay ownership re-check (no orphan ADS notification); cancellable RecycleClientAsync. 29/29 tasks, 0 deferred. Build clean (driver projects 0-warning); S7 254, Modbus 312+161, AbCip 336, AbLegacy 209, TwinCAT 189, FOCAS 265, Core.Abstractions 128 (+14 ConnectionBackoff +20 PollGroupEngine) all green. (One PRE-EXISTING unrelated InterfaceIndependence failure at base — Historian sub-namespace, not R2-09.) Plan: `archreview/plans/R2-09-driver-fleet-batch-plan.md`.
dohertj2 added 29 commits 2026-07-13 12:47:05 -04:00
test(modbus): failing repro for STAB-3 timeout/framing stream desync 141c143586
fix(modbus): classify per-op timeout + framing violations connection-fatal (05/STAB-3) 98f4860103
fix(r2-09): B1.3 Modbus suites green (306+161); STAB-3 sub-batch complete e0998b82c3
test(abcip): failing repro for STAB-4 unserialized shared-handle ops 32f248c93d
feat(abcip): per-runtime operation lock on DeviceState (AbLegacy pattern) e48609b000
fix(abcip): serialize Read/GetStatus/Decode + Encode/Write/GetStatus per runtime (05/STAB-4) 00dcb547e6
test(focas): failing repro for STAB-5 cross-thread Dictionary mutation bb8386d126
fix(focas): ConcurrentDictionary for fixed-tree caches (05/STAB-5) 4231afb268
feat(core): ConnectionBackoff primitive — shared capped-exponential backoff + attempt throttle (05/STAB-8; seam for R2-01 S7 wiring) b8cf3cce0b
feat(core): PollGroupEngine v2 — failure backoff + caller-token-filtered OCE exit (CONV-1/STAB-8; STAB-14-class engine guard) ca6530c7f5
fix(drivers): wire PollGroupEngine onError->health + 30s poll backoff (05/STAB-9) [modbus,abcip,ablegacy] 9213c037b0
fix(drivers): wire PollGroupEngine onError->health + 30s poll backoff (05/STAB-9) [twincat,focas] b494d09d9b
test(s7): failing guards for the poll-fork retirement (PERF-3, STAB-6) 0d879363f8
refactor(s7): retire the bespoke poll fork onto PollGroupEngine v2 (CONV-1; fixes PERF-3 + STAB-6-S7; deletes the fork's bare-OCE poll-death — cross-ref plan R2-01) 85ef74ea86
fix(r2-09): B3.7 engine + 5 driver suites green (S7 254, Modbus 308, AbCip 331, AbLegacy 207, TwinCAT 181, FOCAS 260); B3 complete defb7a8c3d
fix(twincat): per-device connect-attempt backoff, probe-driven recovery (05/STAB-8) 962afed241
fix(focas): per-device connect-attempt backoff across the three loops (05/STAB-8) e54af9b948
fix(abcip): throttle evict-recreate Forward-Open attempts per device (05/STAB-8) 86742ad8cb
docs(s7): point R2-01 at the shipped ConnectionBackoff primitive for the S7 connect throttle (05/STAB-8 seam); B4 complete dd01565d9a
test(drivers): failing repro for CONV-4 equipment-tag ResolveHost mis-keying 8a7701db3f
fix(drivers): ResolveHost resolves equipment-tag refs via EquipmentTagRefResolver — per-host breaker isolation (CONV-4) 9262dd25b7
fix(modbus): equipment tags carry unitId; ResolveHost keys per-unit via the resolver (CONV-4) e69d3b3b0f
fix(r2-09): B5.4 five driver suites green (Modbus 312, AbCip 336, AbLegacy 209, TwinCAT 185, FOCAS 265); B5 complete e27416956e
test(twincat): failing repro for STAB-16 silent replay failure 4f16620948
fix(twincat): replay failure marks the registration dead, publishes Bad quality, degrades health (05/STAB-16) a06515ae91
fix(twincat): retry failed replay intents on the next successful probe tick (05/STAB-16) de29759643
fix(twincat): retract the fresh ADS notification when unsubscribe raced the replay (05/STAB-17) 082ee99b6b
fix(twincat): probe recycle honors cancellation — no uncancellable gate wait (05/STAB-12 compounded part); B6 complete (TwinCAT suite 189 green) 502a327f25
docs(r2-09): record execution deviations; clear CS8604 nullable warning in the 5 PollErrorHealthTests
v2-ci / build (pull_request) Successful in 3m32s
Details
v2-ci / unit-tests (pull_request) Failing after 9m27s
Details
6ee74d26fc
dohertj2 commented 2026-07-13 12:48:14 -04:00
Author
Owner
Copy Link
Copy Source

Landed on master via merge commit 31c98200 (local --no-ff merge). S7 poll-fork deletion reconciled with R2-01; verified Driver.S7.Tests 254/254 + clean build barrier. Closing as merged.

Landed on `master` via merge commit `31c98200` (local --no-ff merge). S7 poll-fork deletion reconciled with R2-01; verified Driver.S7.Tests 254/254 + clean build barrier. Closing as merged.
dohertj2 closed this pull request 2026-07-13 12:48:14 -04:00
Some checks are pending
v2-ci / build (pull_request) Successful in 3m32s
Details
v2-ci / unit-tests (pull_request) Failing after 9m27s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#437
Delete Branch "r2/09-driver-fleet-batch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?