R2-12 Repo hygiene (arch-review round 2) #426

2026-07-13T10:05:00-04:00

dohertj2 commented

2026-07-13 10:05:00 -04:00

Round-2 arch-review remediation plan R2-12 (findings 07/U-3/4/5/6, S-3, P-5, C-4/5/6).

Remove 7 orphaned proprietary AVEVA/Wonderware DLLs from lib/ (U-5)
Untrack/archive root planning files; honor pending.md never-stage rule (U-4); gitignore guards
Delete no-op nightly E2E workflow + redundant integration matrix job (S-3, P-5)
Document 5 alarm operator CLI commands (13/13); StyleGuide product-name fix; minimal .editorconfig (U-3, C-5)
xunit v2 holdout pin documented + bumped 2.9.2→2.9.3 with blocker rationale (C-4)

Clean solution build (0 err, 808 warns == baseline). 8 commits. Executed via isolated worktree; per-task TDD/verification. Plan: archreview/plans/R2-12-repo-hygiene-plan.md.

Round-2 arch-review remediation plan **R2-12** (findings 07/U-3/4/5/6, S-3, P-5, C-4/5/6). - Remove 7 orphaned proprietary AVEVA/Wonderware DLLs from `lib/` (U-5) - Untrack/archive root planning files; honor pending.md never-stage rule (U-4); gitignore guards - Delete no-op nightly E2E workflow + redundant integration matrix job (S-3, P-5) - Document 5 alarm operator CLI commands (13/13); StyleGuide product-name fix; minimal .editorconfig (U-3, C-5) - xunit v2 holdout pin documented + bumped 2.9.2→2.9.3 with blocker rationale (C-4) Clean solution build (0 err, 808 warns == baseline). 8 commits. Executed via isolated worktree; per-task TDD/verification. Plan: `archreview/plans/R2-12-repo-hygiene-plan.md`.

dohertj2 added 8 commits 2026-07-13 10:05:01 -04:00

chore(r2-12): remove 7 orphaned proprietary AVEVA DLLs from lib/ (07/U-5) d6ae8bd03a

Zero-reference proof passed: no *.csproj/*.props/*.targets/*.slnx names any
of the 7 binaries; no <HintPath> element exists repo-wide. Build clean after
removal. Added lib/ to .gitignore to block re-introduction.

Out of scope: purging these from git *history* (BFG/filter-repo) is a separate,
heavier decision that rewrites every clone; this removes them from the tip only.

chore(r2-12): U-6 husk dirs already absent in worktree — no deletion needed (07/U-6) 0aebffe800

The 5 Driver.Historian.Wonderware* husks are untracked bin/obj build artifacts
(0 tracked files; absent from slnx). A fresh worktree carries no untracked files,
so there is nothing to rm. Only tracked Wonderware residue is the intentional
retired doc stub + closed-review findings.md (kept). Deviation recorded in plan.

chore(r2-12): untrack/archive root planning files; honor pending.md's never-stage rule (07/U-4) 73d4061b77

- pending.md, current.md: git rm --cached (untrack, keep on disk) + root-anchored
  .gitignore entries — making the files' own declared 'never stage' rule true.
- looseends.md: deleted (2026-05-18 snapshot; sole open item + all follow-ups
  target the retired Wonderware historian sidecar rig, moot since the gateway
  cutover; recoverable from history).
- stillpending.md -> docs/plans/2026-06-18-stillpending-backlog-audit.md (git mv;
  referenced by docs/Historian.md + memory index, preserved under dated-plan convention).
- HISTORIAN-GATEWAY-INTEGRATION-ISSUES.md -> docs/plans/2026-06-27-historian-gateway-integration-issues.md (git mv).
- docs/Historian.md §'Closed backlog §2 items' repointed at the archived path.
Historical docs/plans/* references to the bare stillpending.md filename are frozen
point-in-time records, left untouched per the documentation-audit convention.

ci(r2-12): delete no-op nightly E2E workflow + redundant integration matrix (07/S-3, 07/P-5) 67de2c942b

- v2-e2e.yml deleted: its `--filter Category=E2E` matches zero tests repo-wide (the
  E2ETests project doesn't exist) so it reported a permanent false green; and its
  docker-dev fleet binds the LAN-only shared GLAuth (10.100.0.35:3893) + builds local
  images, so it isn't hosted-runner-bootable anyway. FOLLOW-UP: when a runner-reachable
  fleet + a real tests/Server/...E2ETests land, add a fresh workflow WITH a zero-match
  guard (fail if Category=E2E matches nothing).
- v2-ci.yml integration matrix removed: fully redundant with the unit-tests leg, which
  already runs both Host.IntegrationTests + OpcUaServer.IntegrationTests under the
  identical filter, fixtureless, gated at MIN_EXECUTED=1. No coverage lost. The S-2
  option-#2 fixture-backed-leg follow-up is preserved as a NOTE comment in the workflow.
Header comments updated; YAML validates; jobs are now build -> unit-tests.

docs(r2-12): document 5 alarm operator CLI commands; fix StyleGuide product name; add minimal .editorconfig (07/U-3, 07/C-5) 6e1903b231

- docs/Client.CLI.md: added ### ack / confirm / shelve / enable / disable sections
  (synopsis + options + example + expected output), each noting the AlarmAck LDAP-role
  gate and that --event-id comes from a prior `alarms` notification. Doc now covers all
  13 CLI commands (was 8). Overview operations list updated.
- StyleGuide.md: 'ScadaBridge' -> 'OtOpcUa' (header line 3) + the ScadaBridge:Timeout
  config-key example -> OpcUa:Timeout.
- .editorconfig (new, root): minimal code-style anchor; all C# analyzer rules at
  suggestion severity so nothing fails a TreatWarningsAsErrors build (verified: 808
  warnings unchanged from baseline, 0 errors).

test(r2-12): document + patch-align the xunit v2 holdout pin (07/C-4) 152d8ebe0e

Branch B (upstream-blocked): probed nuget.org for an xunit.v3 Akka TestKit —
Akka.TestKit.Xunit3 and Akka.TestKit.Xunit.v3 both return BlobNotFound (verified
2026-07-13), so the 3 holdouts (AdminUI/ControlPlane/Runtime.Tests) cannot migrate
off xunit v2 yet. Bumped the pin 2.9.2 -> 2.9.3 (latest 2.9.x) and moved the blocker
rationale + removal condition to a comment at the pin in Directory.Packages.props so
it lives at the version, not just in 3 scattered csprojs. All 3 suites green on 2.9.3
(514 + 63 + 364 tests).

docs(r2-12): record R2-12 repo-hygiene execution + open follow-ups in STATUS.md 04a9edab7e

chore(r2-12): mark T11 final verification complete

v2-ci / build (pull_request) Successful in 3m22s

Details

v2-ci / unit-tests (pull_request) Failing after 8m31s

Details

1455550d0c

dohertj2 referenced this issue from a commit

2026-07-13 10:06:30 -04:00

Merge R2-12 repo hygiene (arch-review round 2) [PR #426]

dohertj2 commented

2026-07-13 10:07:32 -04:00

Landed on master via merge commit 3c81f6eb (manual --no-ff merge with a clean dotnet build barrier). Closing as merged — branch commits d6ae8bd0..1455550d are all reachable from master.

Landed on `master` via merge commit `3c81f6eb` (manual `--no-ff` merge with a clean `dotnet build` barrier). Closing as merged — branch commits d6ae8bd0..1455550d are all reachable from master.

dohertj2 closed this pull request

2026-07-13 10:07:32 -04:00

v2-ci / build (pull_request) Successful in 3m22s

Details

v2-ci / unit-tests (pull_request) Failing after 8m31s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#426