[twincat] TwinCAT — ENUM and ALIAS at discovery #345

dohertj2 · 2026-04-25T17:51:04-04:00

dohertj2 commented

2026-04-25 17:51:04 -04:00

Summary

ENUM and ALIAS symbols now surface during discovery instead of being silently dropped.

Replaces name-only MapSymbolTypeName(string?) with new ResolveSymbolDataType(IDataType?) that inspects DataTypeCategory and walks the IAliasType.BaseType chain.
ENUM symbols surface as their underlying integer — IEnumType : IAliasType, same code path.
ALIAS chains recurse to the atomic primitive. Recursion bounded at 16 levels as cycle insurance.
POINTER / REFERENCE / INTERFACE / UNION / STRUCT / ARRAY / FB still return null and continue to be skipped (out of scope per issue body).
Discovery call site updated to pass symbol.DataType directly.

Test plan

dotnet build src/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT — clean (0 / 0)
dotnet test tests/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT.Tests — 151 / 151 passed (8 new in TwinCATTypeResolutionTests: single alias, chained alias, alias to unrecognised primitive, primitive direct, null, self-referential cycle, INT-based enum, DINT-based enum)
Integration tests — hardware-gated (TWINCAT_TARGET_NETID)

🤖 Auto-generated by the Mode-B execution loop. Closes #309.

Closes #309

## Summary ENUM and ALIAS symbols now surface during discovery instead of being silently dropped. - Replaces name-only `MapSymbolTypeName(string?)` with new `ResolveSymbolDataType(IDataType?)` that inspects `DataTypeCategory` and walks the `IAliasType.BaseType` chain. - **ENUM** symbols surface as their underlying integer — `IEnumType : IAliasType`, same code path. - **ALIAS** chains recurse to the atomic primitive. Recursion bounded at **16 levels** as cycle insurance. - **POINTER / REFERENCE / INTERFACE / UNION / STRUCT / ARRAY / FB** still return null and continue to be skipped (out of scope per issue body). - Discovery call site updated to pass `symbol.DataType` directly. ## Test plan - [x] `dotnet build src/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT` — clean (0 / 0) - [x] `dotnet test tests/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT.Tests` — **151 / 151 passed** (8 new in `TwinCATTypeResolutionTests`: single alias, chained alias, alias to unrecognised primitive, primitive direct, null, self-referential cycle, INT-based enum, DINT-based enum) - [ ] Integration tests — hardware-gated (TWINCAT_TARGET_NETID) 🤖 Auto-generated by the Mode-B execution loop. Closes #309. Closes #309

dohertj2 added 1 commit 2026-04-25 17:51:05 -04:00

Auto: twincat-1.5 — ENUM/ALIAS discovery 0df14ab94a

Resolve TwinCAT symbol data types via the IDataType chain instead of a
flat name match. ALIAS chains walk BaseType recursively (depth-capped at
16 against pathological cycles); ENUM surfaces its underlying integer
base type. POINTER / REFERENCE / INTERFACE / UNION / STRUCT / ARRAY / FB
remain explicitly out of scope and surface as null.

Closes #309

dohertj2 merged commit 2266dd9ad5 into auto/driver-gaps

2026-04-25 17:51:10 -04:00

dohertj2 deleted branch auto/twincat/1.5

2026-04-25 17:51:10 -04:00

dohertj2 referenced this issue from a commit

2026-04-25 17:51:11 -04:00

Merge pull request '[twincat] TwinCAT — ENUM and ALIAS at discovery' (#345) from auto/twincat/1.5 into auto/driver-gaps

dohertj2 referenced this pull request

2026-04-25 17:51:12 -04:00

[twincat] TwinCAT â€” ENUM and ALIAS at discovery #309

Sign in to join this conversation.