dohertj2/lmxopcua
1
0
Fork 0
Code Issues 44 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

[twincat] TwinCAT — Int64 fidelity for LINT/ULINT #341

Merged
dohertj2 merged 1 commits from auto/twincat/1.1 into auto/driver-gaps 2026-04-25 17:06:57 -04:00
Conversation 0 Commits 1 Files Changed 2 +4 -1
dohertj2 commented 2026-04-25 17:06:51 -04:00
Owner
Copy Link

Summary

Closes the silent Int32 truncation of LINT/ULINT in TwinCAT.

  • TwinCATDataType.ToDriverDataType() — LInt → Int64, ULInt → UInt64. Two arms split out, "matches Int64 gap" truncation comment removed.
  • AdsTwinCATClient.MapToClrType already returned long/ulong and the value-coercion path (Convert.ToInt64/Convert.ToUInt64) was already correct, so no client changes were needed.

Test plan

  • dotnet build src/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT — clean (0 / 0)
  • dotnet test tests/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT.Tests — 110 / 110 passed (2 new asserts in DataType_mapping_covers_atomic_iec_types for LInt → Int64 and ULInt → UInt64)
  • Integration tests — hardware-gated (TWINCAT_TARGET_NETID)

🤖 Auto-generated by the Mode-B execution loop. Closes #305.

Closes #305

## Summary Closes the silent Int32 truncation of `LINT`/`ULINT` in TwinCAT. - `TwinCATDataType.ToDriverDataType()` — `LInt → Int64`, `ULInt → UInt64`. Two arms split out, "matches Int64 gap" truncation comment removed. - `AdsTwinCATClient.MapToClrType` already returned `long`/`ulong` and the value-coercion path (`Convert.ToInt64`/`Convert.ToUInt64`) was already correct, so no client changes were needed. ## Test plan - [x] `dotnet build src/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT` — clean (0 / 0) - [x] `dotnet test tests/ZB.MOM.WW.OtOpcUa.Driver.TwinCAT.Tests` — **110 / 110 passed** (2 new asserts in `DataType_mapping_covers_atomic_iec_types` for `LInt → Int64` and `ULInt → UInt64`) - [ ] Integration tests — hardware-gated (TWINCAT_TARGET_NETID) 🤖 Auto-generated by the Mode-B execution loop. Closes #305. Closes #305
dohertj2 added 1 commit 2026-04-25 17:06:53 -04:00
Auto: twincat-1.1 — Int64 fidelity for LINT/ULINT 615ab25680 
Map LInt/ULInt to DriverDataType.Int64/UInt64 instead of truncating
to Int32. AdsTwinCATClient.MapToClrType already returns long/ulong
so the wire-level read returns the correct boxed types.

Closes #305
dohertj2 merged commit 8286255ae5 into auto/driver-gaps 2026-04-25 17:06:57 -04:00
dohertj2 deleted branch auto/twincat/1.1 2026-04-25 17:06:57 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#341
Delete Branch "auto/twincat/1.1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?