Task #242 partial — UnsTab interactive E2E test bodies + harness upgrades (Skip-guarded) #200

2026-04-21T02:11:39-04:00

dohertj2 commented

2026-04-21 02:11:39 -04:00

Summary

Partial progress on task #242 (UnsTab drag-drop interactive Playwright E2E). Two interactive tests authored + marked [Fact(Skip=...)] pending resolution of a concrete blazor.web.js asset-resolution blocker documented in the class docstring. Multiple harness upgrades that move the in-process WebApplication fixture closer to a working Blazor Server circuit.

Harness upgrades (AdminWebAppFactory)

Environment=Development so 500s surface exception stacks.
ContentRootPath → Admin assembly dir so wwwroot resolves.
SignalR hubs /hubs/fleet + /hubs/alerts mapped so ClusterDetail's HubConnection negotiation doesn't 500 at first render.
Services property exposed so tests can open scoped DI contexts against the running host.

Remaining blocker (reason for Skip)

/_framework/blazor.web.js returns HTTP 200 with a zero-byte body because the file ships via Microsoft.AspNetCore.App.Internal.Assets NuGet rather than Admin's wwwroot. Three viable next-session approaches in class docstring.

Test plan

Suite state: 1 passed (scaffolding smoke), 2 skipped (interactive), 0 failed.

🤖 Generated with Claude Code

## Summary Partial progress on task #242 (UnsTab drag-drop interactive Playwright E2E). Two interactive tests authored + marked [Fact(Skip=...)] pending resolution of a concrete blazor.web.js asset-resolution blocker documented in the class docstring. Multiple harness upgrades that move the in-process WebApplication fixture closer to a working Blazor Server circuit. ### Harness upgrades (AdminWebAppFactory) - `Environment=Development` so 500s surface exception stacks. - `ContentRootPath` → Admin assembly dir so wwwroot resolves. - SignalR hubs `/hubs/fleet` + `/hubs/alerts` mapped so ClusterDetail's HubConnection negotiation doesn't 500 at first render. - `Services` property exposed so tests can open scoped DI contexts against the running host. ### Remaining blocker (reason for Skip) `/_framework/blazor.web.js` returns HTTP 200 with a zero-byte body because the file ships via `Microsoft.AspNetCore.App.Internal.Assets` NuGet rather than Admin's wwwroot. Three viable next-session approaches in class docstring. ### Test plan - Suite state: 1 passed (scaffolding smoke), 2 skipped (interactive), 0 failed. 🤖 Generated with Claude Code

dohertj2 added 1 commit 2026-04-21 02:11:41 -04:00

Task #242 partial — UnsTab interactive E2E test bodies + harness upgrades (tests Skip-guarded pending blazor.web.js asset plumbing) 4e96f228b2

Carries the interactive drag-drop + 409 concurrent-edit test bodies (full Playwright
flows against the real @ondragstart/@ondragover/@ondrop handlers + modal + EF state
round-trip), plus several harness upgrades that push the in-process
WebApplication-based fixture closer to a working Blazor Server circuit. The
interactive tests are marked [Fact(Skip=...)] pending resolution of one remaining
blocker documented in the class docstring.

Harness upgrades (AdminWebAppFactory):
  - Environment set to Development so 500s surface exception stacks (rather than
    the generic error page) during future diagnosis.
  - ContentRootPath pointed at the Admin assembly dir so wwwroot + manifest files
    resolve.
  - Wired SignalR hubs (/hubs/fleet, /hubs/alerts) so ClusterDetail's HubConnection
    negotiation no longer 500s at first render.
  - Services property exposed so tests can open scoped DI contexts against the
    running host (scheduled peer-edit simulation, post-commit state assertion).

Remaining blocker (reason for Skip):
  /_framework/blazor.web.js returns HTTP 200 with a zero-byte body. The asset's
  route is declared in OtOpcUa.Admin.staticwebassets.endpoints.json, but the
  underlying file is shipped by the framework NuGet package
  (Microsoft.AspNetCore.App.Internal.Assets/_framework/blazor.web.js) rather than
  copied into the Admin wwwroot. MapStaticAssets can't resolve it without wiring
  a composite FileProvider or the WebRootPath machinery. Three viable next-session
  approaches listed in the class docstring:
    (a) Composite FileProvider mapping /_framework/* → NuGet cache.
    (b) Subprocess harness spawning real dotnet run of Admin project with an
        InMemory-DB override (closest to production composition).
    (c) MSBuild ItemGroup in the test csproj that copies framework files into the
        test output + ContentRoot=test assembly dir with UseStaticFiles.

Scaffolding smoke test (Admin_host_serves_HTTP_via_Playwright_scaffolding) stays
green unchanged.

Suite state: 1 passed, 2 skipped, 0 failed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

dohertj2 merged commit 3e3c7206dd into v2

2026-04-21 02:11:50 -04:00

dohertj2 referenced this issue from a commit

2026-04-21 02:11:52 -04:00

Merge pull request 'Task #242 partial — UnsTab interactive E2E test bodies + harness upgrades (Skip-guarded)' (#200) from task-242-unstab-interactive-partial into v2

dohertj2 referenced this pull request

2026-04-21 02:33:17 -04:00

Task #242 finish — UnsTab drag-drop interactive E2E tests un-skip + pass #201

dohertj2 referenced this issue from a commit

2026-04-30 08:21:26 -04:00

AlarmSurfaceInvoker — wraps IAlarmSource.Subscribe/Unsubscribe/Acknowledge through CapabilityInvoker with multi-host fan-out. Closes alarm-surface slice of task #161 (Phase 6.1 Stream A); the Roslyn invoker-coverage analyzer is split into new task #200 because a DiagnosticAnalyzer project is genuinely its own scaffolding PR (Microsoft.CodeAnalysis.CSharp.Workspaces dep, netstandard2.0 target, Microsoft.CodeAnalysis.Testing harness, ProjectReference OutputItemType=Analyzer wiring, and four corner-case rules I want tests for before shipping). Ship this PR as the runtime guardrail + callable API; the analyzer lands next as the compile-time guardrail. New AlarmSurfaceInvoker class in Core.Resilience. Three methods mirror IAlarmSource's three mutating surfaces: SubscribeAsync (fan-out: group sourceNodeIds by IPerCallHostResolver.ResolveHost, one CapabilityInvoker.ExecuteAsync per host with DriverCapability.AlarmSubscribe so AlarmSubscribe's retry policy kicks in + returns one IAlarmSubscriptionHandle per host); UnsubscribeAsync (single-host, defaultHost); AcknowledgeAsync (fan-out: group AlarmAcknowledgeRequests by resolver-mapped host, run each host's batch through DriverCapability.AlarmAcknowledge which does NOT retry per decision #143 — alarm-ack is a write-shaped op that's not idempotent at the plant-floor level). Drivers without IPerCallHostResolver (Galaxy single MXAccess endpoint, OpcUaClient against one remote, etc.) fall back to defaultHost = DriverInstanceId so breaker + bulkhead keying still happens; drivers with it get one-dead-PLC-doesn't-poison-siblings isolation per decision #144. Single-host single-subscribe returns [handle] with length 1; empty sourceNodeIds fast-paths to [] without a driver call. Five new AlarmSurfaceInvokerTests covering: (a) empty list short-circuits — driver method never called; (b) single-host sub routes via default host — one driver call with full id list; (c) multi-host sub fans out to 2 distinct hosts for 3 src ids mapping to 2 plcs — one driver call per host; (d) Acknowledge does not retry on failure — call count stays at 1 even with exception; (e) Subscribe retries transient failures — call count reaches 3 with a 2-failures-then-success fake. Core.Tests resilience-builder suite 19/19 passing (was 14, +5); Core.Tests whole suite still green. Core project builds 0 errors. Task #200 captures the compile-time guardrail: Roslyn DiagnosticAnalyzer at src/ZB.MOM.WW.OtOpcUa.Analyzers that flags direct invocations of the eleven capability-interface methods inside the Server namespace when the call is NOT inside a CapabilityInvoker.ExecuteAsync/ExecuteWriteAsync/AlarmSurfaceInvoker.*Async lambda. That analyzer is the reason we keep paying the wrapping-class overhead for every new capability.

dohertj2 referenced this issue from a commit