Phase 3 PR 16 — concrete OPC UA server scaffolding + AlarmConditionState materialization #15

dohertj2 · 2026-04-18T08:10:35-04:00

dohertj2 commented

2026-04-18 08:10:35 -04:00

Concrete realization of PR 15's IAddressSpaceBuilder contract against OPCFoundation.NetStandard.Opc.Ua.Server. DriverNodeManager (CustomNodeManager2 subclass) materializes Folder/Variable/AlarmCondition nodes from driver discovery, routes Read/Write to IReadable/IWritable, translates AlarmEventArgs transitions to OPC UA AlarmConditionState Activate/Acknowledge/Deactivate and fires ReportEvent. OtOpcUaServer wires one node manager per registered driver. Scoped as scaffolding — materialization shape is complete; actual server startup (ApplicationInstance + cert + endpoint binding wired into OpcUaServerService.ExecuteAsync) is deferred to the next PR since it depends on per-deployment ApplicationConfiguration policy. 152/152 solution-wide unit tests still pass. Live-endpoint integration tests land alongside the server-startup PR.

Concrete realization of PR 15's IAddressSpaceBuilder contract against OPCFoundation.NetStandard.Opc.Ua.Server. DriverNodeManager (CustomNodeManager2 subclass) materializes Folder/Variable/AlarmCondition nodes from driver discovery, routes Read/Write to IReadable/IWritable, translates AlarmEventArgs transitions to OPC UA AlarmConditionState Activate/Acknowledge/Deactivate and fires ReportEvent. OtOpcUaServer wires one node manager per registered driver. **Scoped as scaffolding** — materialization shape is complete; actual server startup (ApplicationInstance + cert + endpoint binding wired into OpcUaServerService.ExecuteAsync) is deferred to the next PR since it depends on per-deployment ApplicationConfiguration policy. 152/152 solution-wide unit tests still pass. Live-endpoint integration tests land alongside the server-startup PR.

dohertj2 added 1 commit 2026-04-18 08:10:36 -04:00

Phase 3 PR 16 — concrete OPC UA server scaffolding with AlarmConditionState materialization. Introduces the OPCFoundation.NetStandard.Opc.Ua.Server package (v1.5.374.126, same version the v1 stack already uses) and two new server-side classes: DriverNodeManager : CustomNodeManager2 is the concrete realization of PR 15's IAddressSpaceBuilder contract — Folder() creates FolderState nodes under an Organizes hierarchy rooted at ObjectsFolder > DriverInstanceId; Variable() creates BaseDataVariableState with DataType mapped from DriverDataType (Boolean/Int32/Float/Double/String/DateTime) + ValueRank (Scalar or OneDimension) + AccessLevel CurrentReadOrWrite; AddProperty() creates PropertyState with HasProperty reference. Read hook wires OnReadValue per variable to route to IReadable.ReadAsync; Write hook wires OnWriteValue to route to IWritable.WriteAsync and surface per-tag StatusCode. MarkAsAlarmCondition() materializes an OPC UA AlarmConditionState child of the variable, seeded from AlarmConditionInfo (SourceName, InitialSeverity → UA severity via Low=250/Medium=500/High=700/Critical=900, InitialDescription), initial state Enabled + Acknowledged + Inactive + Retain=false. Returns an IAlarmConditionSink whose OnTransition updates alarm.Severity/Time/Message and switches state per AlarmType string ('Active' → SetActiveState(true) + SetAcknowledgedState(false) + Retain=true; 'Acknowledged' → SetAcknowledgedState(true); 'Inactive' → SetActiveState(false) + Retain=false if already Acked) then calls alarm.ReportEvent to emit the OPC UA event to subscribed clients. Galaxy's GalaxyAlarmTracker (PR 14) now lands at a concrete AlarmConditionState node instead of just raising an unobserved C# event. OtOpcUaServer : StandardServer wires one DriverNodeManager per DriverHost.GetDriver during CreateMasterNodeManager — anonymous endpoint, no security profile (minimum-viable; LDAP + security-profile wire-up is the next PR). DriverHost gains public GetDriver(instanceId) so the server can enumerate drivers at startup. NestedBuilder inner class in DriverNodeManager implements IAddressSpaceBuilder by temporarily retargeting the parent's _currentFolder during each call so Folder→Variable→AddProperty land under the correct subtree — not thread-safe if discovery ran concurrently, but GenericDriverNodeManager.BuildAddressSpaceAsync is sequential per driver so this is safe by construction. NuGet audit suppress for GHSA-h958-fxgg-g7w3 (moderate-severity in OPCFoundation.NetStandard.Opc.Ua.Core 1.5.374.126; v1 stack already accepts this risk on the same package version). PR 16 is scoped as scaffolding — the actual server startup (ApplicationInstance, certificate config, endpoint binding, session management wiring into OpcUaServerService.ExecuteAsync) is deferred to a follow-up PR because it needs ApplicationConfiguration XML + optional-cert-store logic that depends on per-deployment policy decisions. The materialization shape is complete: a subsequent PR adds 100 LOC to start the server and all the already-written IAddressSpaceBuilder + alarm-condition + read/write wire-up activates end-to-end. Full solution: 0 errors, 152 unit tests pass (no new tests this PR — DriverNodeManager unit testing needs an IServerInternal mock which is heavyweight; live-endpoint integration tests land alongside the server-startup PR). f53c39a598

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

dohertj2 merged commit 7683b94287 into v2

2026-04-18 08:10:46 -04:00

dohertj2 referenced this issue from a commit

2026-04-18 08:10:47 -04:00

Merge pull request 'Phase 3 PR 16 — concrete OPC UA server scaffolding + AlarmConditionState materialization' (#15) from phase-3-pr16-opcua-server into v2

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#15