Phase 6.1 Stream A remaining - IPerCallHostResolver + per-call host dispatch (decision #144) #104

dohertj2 · 2026-04-19T12:33:12-04:00

dohertj2 commented

2026-04-19 12:33:12 -04:00

Closes the decision #144 per-device isolation gap. Multi-host drivers now trip per-PLC breakers instead of poisoning siblings.

Summary

IPerCallHostResolver optional driver capability. Multi-host drivers (Modbus N PLCs) implement; single-host drivers (Galaxy, S7, OpcUaClient) leave it alone.
DriverNodeManager.ResolveHostFor(fullRef) helper � returns resolver’s answer or falls back to driver.DriverInstanceId. Empty output also falls back.
Every dispatch site (OnReadValue + OnWriteValue + 4 HistoryRead paths) now passes ResolveHostFor(fullRef) to the invoker. HistoryRead Events tolerates fullRef == null for cluster-wide notifier queries.
Drivers without the resolver observe zero behaviour change.

Test plan

4 new dispatch tests: dead-PLC + healthy-PLC isolation (the decision #144 case), empty-string fallback, without-resolver single-pipeline regression guard, with-resolver two-pipeline cache count.
Full solution dotnet test: 1219 passing (was 1215, +4).
Driver adoption (Modbus first) lands alongside driver-specific follow-ups.

🤖 Generated with Claude Code

Closes the decision #144 per-device isolation gap. Multi-host drivers now trip per-PLC breakers instead of poisoning siblings. ## Summary - `IPerCallHostResolver` optional driver capability. Multi-host drivers (Modbus N PLCs) implement; single-host drivers (Galaxy, S7, OpcUaClient) leave it alone. - `DriverNodeManager.ResolveHostFor(fullRef)` helper � returns resolver’s answer or falls back to `driver.DriverInstanceId`. Empty output also falls back. - Every dispatch site (OnReadValue + OnWriteValue + 4 HistoryRead paths) now passes `ResolveHostFor(fullRef)` to the invoker. HistoryRead Events tolerates `fullRef == null` for cluster-wide notifier queries. - Drivers without the resolver observe zero behaviour change. ## Test plan - [x] 4 new dispatch tests: dead-PLC + healthy-PLC isolation (the decision #144 case), empty-string fallback, without-resolver single-pipeline regression guard, with-resolver two-pipeline cache count. - [x] Full solution `dotnet test`: 1219 passing (was 1215, +4). - [ ] Driver adoption (Modbus first) lands alongside driver-specific follow-ups. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

dohertj2 added 1 commit 2026-04-19 12:33:13 -04:00

Phase 6.1 Stream A remaining — IPerCallHostResolver + DriverNodeManager per-call host dispatch (decision #144 ) 4de94fab0d

Closes the per-device isolation gap flagged at the Phase 6.1 Stream A wire-up
(PR #78 used driver.DriverInstanceId as the pipeline host for every call, so
multi-host drivers like Modbus with N PLCs shared one pipeline — one dead PLC
poisoned sibling breakers). Decision #144 requires per-device isolation; this
PR wires it without breaking single-host drivers.

Core.Abstractions:
- IPerCallHostResolver interface. Optional driver capability. Drivers with
  multi-host topology (Modbus across N PLCs, AB CIP across a rack, etc.)
  implement this; single-host drivers (Galaxy, S7 against one PLC, OpcUaClient
  against one remote server) leave it alone. Must be fast + allocation-free
  — called once per tag on the hot path. Unknown refs return empty so dispatch
  falls back to single-host without throwing.

Server/OpcUa/DriverNodeManager:
- Captures `driver as IPerCallHostResolver` at construction alongside the
  existing capability casts.
- New `ResolveHostFor(fullReference)` helper returns either the resolver's
  answer or the driver's DriverInstanceId (single-host fallback). Empty /
  whitespace resolver output also falls back to DriverInstanceId.
- Every dispatch site now passes `ResolveHostFor(fullRef)` to the invoker
  instead of `_driver.DriverInstanceId` — OnReadValue, OnWriteValue, all four
  HistoryRead paths. The HistoryRead Events path tolerates fullRef=null and
  falls back to DriverInstanceId for those cluster-wide event queries.
- Drivers without IPerCallHostResolver observe zero behavioural change:
  every call still keys on DriverInstanceId, same as before.

Tests (4 new PerCallHostResolverDispatchTests, all pass):
- DeadPlc_DoesNotOpenBreaker_For_HealthyPlc_With_Resolver — 2 PLCs behind
  one driver; hammer the dead PLC past its breaker threshold; assert the
  healthy PLC's first call succeeds on its first attempt (decision #144).
- EmptyString / unknown-ref fallback behaviour documented via test.
- WithoutResolver_SameHost_Shares_One_Pipeline — regression guard for the
  single-host pre-existing behaviour.
- WithResolver_TwoHosts_Get_Two_Pipelines — builds the CachedPipelineCount
  assertion to confirm the shared-builder cache keys correctly.

Full solution dotnet test: 1219 passing (was 1215, +4). Pre-existing
Client.CLI Subscribe flake unchanged.

Adoption: Modbus driver (#120 follow-up), AB CIP / AB Legacy / TwinCAT
drivers (also #120) implement the interface and return the per-tag PLC host
string. Single-host drivers stay silent and pay zero cost.

Remaining sub-items of #160 still deferred:
- IAlarmSource.SubscribeAlarmsAsync + AcknowledgeAsync invoker wrapping.
  Non-trivial because alarm subscription is push-based from driver through
  IAlarmConditionSink — the wrap has to happen at the driver-to-server glue
  rather than a synchronous dispatch site.
- Roslyn analyzer asserting every capability-interface call routes through
  CapabilityInvoker. Substantial (separate analyzer project + test harness);
  noise-value ratio favors shipping this post-v2-GA once the coverage is
  known-stable.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

dohertj2 merged commit 244a36e03e into v2

2026-04-19 12:33:25 -04:00

dohertj2 referenced this issue from a commit

2026-04-19 12:33:26 -04:00

Merge pull request (#104) - IPerCallHostResolver + decision #144 wire-in

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#104