dohertj2/lmxopcua
1
0
Fork 0
Code Issues 26 Pull Requests 1 Actions 2 Packages Projects Releases Wiki Activity

Tests: bump xunit.v3 1.1.0 → 3.2.2 repo-wide and drop the four VersionOverrides #795

New Issue
Closed
opened 2026-11-10 08:58:33 -05:00 by dohertj2 · 1 comment
dohertj2 commented 2026-11-10 08:58:33 -05:00
Owner
Copy Link
Copy Source

Follow-up from #756 (b211911f).

Directory.Packages.props pins xunit.v3 at 1.1.0. Akka.TestKit.Xunit 1.5.62 needs ≥ 3.2.2, so the four TestKit projects (AdminUI.Tests, ControlPlane.Tests, Runtime.Tests, Host.Tests) carry VersionOverride="3.2.2". The other 44 test projects stay on 1.1.0.

Bumping the pin repo-wide currently fails with about 1,900 analyzer errors in those 44 projects: xUnit1051 (pass TestContext.Current.CancellationToken) and xUnit3003. #756 already applied the same mechanical fix to the four migrated projects.

Done when the central pin is 3.2.2, the overrides are gone, the build has 0 warnings, and test counts per project are unchanged.

Follow-up from #756 (`b211911f`). `Directory.Packages.props` pins `xunit.v3` at **1.1.0**. `Akka.TestKit.Xunit` 1.5.62 needs **≥ 3.2.2**, so the four TestKit projects (AdminUI.Tests, ControlPlane.Tests, Runtime.Tests, Host.Tests) carry `VersionOverride="3.2.2"`. The other 44 test projects stay on 1.1.0. Bumping the pin repo-wide currently fails with about 1,900 analyzer errors in those 44 projects: xUnit1051 (pass `TestContext.Current.CancellationToken`) and xUnit3003. #756 already applied the same mechanical fix to the four migrated projects. Done when the central pin is 3.2.2, the overrides are gone, the build has 0 warnings, and test counts per project are unchanged.
dohertj2 added the type:debtpriority:p3 labels 2026-11-10 08:58:33 -05:00
dohertj2 commented 2026-11-10 09:32:27 -05:00
Author
Owner
Copy Link
Copy Source

Fixed in 83ed880e (pushed to master).

Package changes:

  • xunit.v3 central pin 1.1.0 -> 3.2.2 in Directory.Packages.props. The #756 comment is updated.
  • The four VersionOverride="3.2.2" entries are removed (AdminUI, ControlPlane, Runtime and Host tests).
  • xunit.runner.visualstudio stays at 3.0.2 and is compatible.

Fallout was much smaller than estimated. xUnit1051 had already been cleaned (#725/#756), so there were no token call-site edits. The only diagnostics were 12 xUnit3003 errors: the custom Fact/Theory attributes in the AbCip, AbLegacy and TwinCAT IntegrationTests fixtures. Each now has the CallerFilePath/CallerLineNumber source-info ctor, matching SqlServerFactAttribute. Nothing was suppressed and no test behaviour changed.

dotnet build ZB.MOM.WW.OtOpcUa.slnx --no-incremental gives 0 warnings and 0 errors, including after the rebase onto latest master.

Counts, each project run one at a time (passed/skipped, before = origin/master b211911f, after = this commit). They are identical for every project except two:

  • Runtime.Tests: before had 1 failure, DriverHostActorApplyingStashTests.ACompletedApply_NeverReportsAWedge (flake). After is 1002 passed + 3 skipped = 1005 total, the same total as before.
  • Driver.Historian.Sql.Common.Tests: 10 failures (SdkAggregateParityTests) both before and after (265 passed / 10 failed of 275). This is pre-existing and unrelated.
Project Before After
AdminUI.Tests 1968/0 1968/0
ControlPlane.Tests 324/0 324/0
Host.Tests 279/0 279/0
Runtime.Tests 1001/3 (1 fail) 1002/3
OpcUaServer.Tests 1027/1 1027/1
ScriptWorker.Tests 165/8 165/8
Security.Tests 104/0 104/0
Analyzers.Tests 22/0 22/0
TwinCAT.Tests 663/0 663/0
Client.CLI / Shared / UI 168 / 240 / 130 same
Cluster / Commons 255 / 363 same

All other unit projects are unchanged; the full per-project list is in the session logs. Integration projects were checked with --list-tests only (discovered counts identical): AbCip 55, AbLegacy 16, FOCAS 18, QuestDb 234, SqlServer 195, Modbus 44, Mqtt 30, MTConnect 18, OpcUaClient 5, OpcUaClient.Browser 5, S7 26, Sql 83, TwinCAT 18, Host 289, OpcUaServer 133.

Fixed in 83ed880e (pushed to master). Package changes: - `xunit.v3` central pin 1.1.0 -> 3.2.2 in Directory.Packages.props. The #756 comment is updated. - The four `VersionOverride="3.2.2"` entries are removed (AdminUI, ControlPlane, Runtime and Host tests). - `xunit.runner.visualstudio` stays at 3.0.2 and is compatible. Fallout was much smaller than estimated. xUnit1051 had already been cleaned (#725/#756), so there were no token call-site edits. The only diagnostics were 12 xUnit3003 errors: the custom Fact/Theory attributes in the AbCip, AbLegacy and TwinCAT IntegrationTests fixtures. Each now has the CallerFilePath/CallerLineNumber source-info ctor, matching `SqlServerFactAttribute`. Nothing was suppressed and no test behaviour changed. `dotnet build ZB.MOM.WW.OtOpcUa.slnx --no-incremental` gives 0 warnings and 0 errors, including after the rebase onto latest master. Counts, each project run one at a time (passed/skipped, before = origin/master `b211911f`, after = this commit). They are identical for every project except two: - Runtime.Tests: before had 1 failure, `DriverHostActorApplyingStashTests.ACompletedApply_NeverReportsAWedge` (flake). After is 1002 passed + 3 skipped = 1005 total, the same total as before. - Driver.Historian.Sql.Common.Tests: 10 failures (`SdkAggregateParityTests`) both before and after (265 passed / 10 failed of 275). This is pre-existing and unrelated. | Project | Before | After | |---|---|---| | AdminUI.Tests | 1968/0 | 1968/0 | | ControlPlane.Tests | 324/0 | 324/0 | | Host.Tests | 279/0 | 279/0 | | Runtime.Tests | 1001/3 (1 fail) | 1002/3 | | OpcUaServer.Tests | 1027/1 | 1027/1 | | ScriptWorker.Tests | 165/8 | 165/8 | | Security.Tests | 104/0 | 104/0 | | Analyzers.Tests | 22/0 | 22/0 | | TwinCAT.Tests | 663/0 | 663/0 | | Client.CLI / Shared / UI | 168 / 240 / 130 | same | | Cluster / Commons | 255 / 363 | same | All other unit projects are unchanged; the full per-project list is in the session logs. Integration projects were checked with `--list-tests` only (discovered counts identical): AbCip 55, AbLegacy 16, FOCAS 18, QuestDb 234, SqlServer 195, Modbus 44, Mqtt 30, MTConnect 18, OpcUaClient 5, OpcUaClient.Browser 5, S7 26, Sql 83, TwinCAT 18, Host 289, OpcUaServer 133.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 blocked
Blocked by dependency or external hold
 cross-driver
queue management
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label priority:p3 type:debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#795
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?