dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Flaky: MTConnectSubscribeTests.A_rebaseline_that_delivers_nothing_still_advances_the_reconnect_backoff #661

New Issue
Closed
opened 2026-10-09 05:48:34 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-09 05:48:34 -04:00
Owner
Copy Link
Copy Source

Failed once in a full-suite run on master 98c00904 (2026-10-09): driver.ReconnectAttempts should be greater than 5 but was 5 (MTConnectSubscribeTests.cs:1071). Passes 8/8 in isolation.

Likely a race in the test: it waits for the 6th sample call (WaitForSampleCallsAsync(6)) and then reads ReconnectAttempts, but the counter is advanced on the pump's backoff path, which can lag the sample-call signal under full-suite load. Fix: wait for the counter itself (poll/AwaitAssert until ReconnectAttempts > early within the watchdog) rather than inferring it from the call count. Test added in 9631a40f (#650 review).

Failed once in a full-suite run on master 98c00904 (2026-10-09): `driver.ReconnectAttempts should be greater than 5 but was 5` (MTConnectSubscribeTests.cs:1071). Passes 8/8 in isolation. Likely a race in the test: it waits for the 6th sample call (`WaitForSampleCallsAsync(6)`) and then reads `ReconnectAttempts`, but the counter is advanced on the pump's backoff path, which can lag the sample-call signal under full-suite load. Fix: wait for the counter itself (poll/AwaitAssert until `ReconnectAttempts > early` within the watchdog) rather than inferring it from the call count. Test added in `9631a40f` (#650 review).
dohertj2 commented 2026-10-09 07:11:43 -04:00
Author
Owner
Copy Link
Copy Source

Fixed and pushed in master fecfdd22 (branch commits 480b000f, 31e2148a). The flaky reconnect test waited on a sample-call proxy that could advance before ReconnectAttempts; both affected tests now wait on ReconnectAttempts itself via a cancellable, watchdog-bounded loop (no background spin). Test-only change. Verified: MTConnectSubscribeTests 10/10 runs green (42 each); full MTConnect suite 633/0 on the merged result.

Fixed and pushed in master `fecfdd22` (branch commits `480b000f`, `31e2148a`). The flaky reconnect test waited on a sample-call proxy that could advance before `ReconnectAttempts`; both affected tests now wait on `ReconnectAttempts` itself via a cancellable, watchdog-bounded loop (no background spin). Test-only change. Verified: MTConnectSubscribeTests 10/10 runs green (42 each); full MTConnect suite 633/0 on the merged result.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#661
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?