MTConnect: EVENT enumerations + DATA_SET/TABLE support #650
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Split out of #613 (low priority). (1) EVENT DataItems with controlled vocabularies (Execution, ControllerMode, ...) are served as Strings; modelling them as OPC UA enumerations needs a per-type vocabulary table that vendors extend, plus a fallback for unknown values. (2) MTConnect 2.x DATA_SET / TABLE observations (Entry key/value children) currently read BadNotSupported; options: expose as String JSON, or structured/array nodes. Both documented as unsupported in docs/drivers/MTConnect.md (feature status table).
Acceptance: decide representation, implement in MTConnectObservationIndex/StreamsParser, wire test against the fixture. Not scheduled.
DATA_SET/TABLE fixed on master (
f8f8eb9f+9631a40f, merged0be21be3): served as a String of compact, ordinal-sorted JSON ({"k":v}/{"row":{"cell":v}});/currentreplaces,/samplemerges by key,resetTriggeredreplaces,removeddrops the key, empty set = Good{}, UNAVAILABLE = BadNoCommunication. Review caught a regression first (ordinary SAMPLEs withresetTriggered, e.g. a daily PartCount, would have become{}) — fixed + tested. Fixture gained a TABLE item (fixture_worktable) and periodic changes. Live gate PASS: fixture redeployed on 10.100.0.35, MTConnect.IntegrationTests 16/16 incl.Read_serves_data_set_and_table_as_json_stringsagainst the real cppagent.EVENT enumerations: parked / won't-fix, rationale in docs/drivers/MTConnect.md (vendor-extensible vocabulary, would break consumers reading these as String).