dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Client.Shared: AddComment API, remove Galaxy-era fallback reads, LoggerLifecycle flake #598

New Issue
Closed
opened 2026-10-08 02:31:10 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-08 02:31:10 -04:00
Owner
Copy Link
Copy Source

Sources: src/Client/ZB.MOM.WW.OtOpcUa.Client.Shared/IOpcUaClientService.cs; OpcUaClientService.cs:826-866; docs/plans/2026-08-17-perf-followups-r3.md ("Test reliability").

  • Add AddCommentAsync + CLI/UI plumbing + an over-the-wire test (ServerEventRig / ClientAlarmMethodTests exist)
  • The alarm-event fallback reads <cond>.InAlarm/.Acked/.TimeAlarmOn/.DescAttrName — v2 Galaxy names v3 conditions don't have; remove or replace with standard Part 9 reads
  • LoggerLifecycleTests.ConfigureLogging_DisposesPreviousLogger_BeforeReassigning flake: pin to a serial [Collection] (races global Serilog.Log.Logger)

Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep.

Sources: src/Client/ZB.MOM.WW.OtOpcUa.Client.Shared/IOpcUaClientService.cs; OpcUaClientService.cs:826-866; docs/plans/2026-08-17-perf-followups-r3.md ("Test reliability"). - [ ] Add `AddCommentAsync` + CLI/UI plumbing + an over-the-wire test (`ServerEventRig` / `ClientAlarmMethodTests` exist) - [ ] The alarm-event fallback reads `<cond>.InAlarm/.Acked/.TimeAlarmOn/.DescAttrName` — v2 Galaxy names v3 conditions don't have; remove or replace with standard Part 9 reads - [ ] `LoggerLifecycleTests.ConfigureLogging_DisposesPreviousLogger_BeforeReassigning` flake: pin to a serial `[Collection]` (races global `Serilog.Log.Logger`) _Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep._
dohertj2 commented 2026-10-08 09:24:30 -04:00
Author
Owner
Copy Link
Copy Source

Resolved on master (48bd266e, merge 9b159025).

  • AddCommentAsync on IOpcUaClientService/OpcUaClientService, plus a comment CLI command (CommentCommand) and over-the-wire coverage via ServerEventRig.
  • The Galaxy-era fallback reads (<cond>.InAlarm/.Acked/...) were removed; the server's standard Part 9 fields are used.
  • LoggerLifecycleTests flake: the CLI tests are serialised (shared Serilog global; Client.CLI.Tests/AssemblyInfo.cs).
  • Client.Shared also moved off the obsolete sync SDK APIs in the same change (#621).

Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).

Resolved on master (48bd266e, merge 9b159025). - [x] `AddCommentAsync` on `IOpcUaClientService`/`OpcUaClientService`, plus a `comment` CLI command (`CommentCommand`) and over-the-wire coverage via ServerEventRig. - [x] The Galaxy-era fallback reads (`<cond>.InAlarm/.Acked/...`) were removed; the server's standard Part 9 fields are used. - [x] LoggerLifecycleTests flake: the CLI tests are serialised (shared Serilog global; `Client.CLI.Tests/AssemblyInfo.cs`). - Client.Shared also moved off the obsolete sync SDK APIs in the same change (#621). *Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).*
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#598
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?