v3 Batch 2 — /raw project-tree AdminUI + Calculation driver #470

2026-07-16T05:28:02-04:00

dohertj2 commented

2026-07-16 05:28:02 -04:00

v3 Batch 2 — `/raw` project-tree AdminUI + `Calculation` driver

Implements docs/plans/2026-07-15-v3-batch2-raw-ui-calculation-plan.md (Track 0 + WP1–WP8),
executed via the /v3-batch 2 coordinator: contracts-first fan-out, worktree-isolated Opus
agents per wave, a code-reviewer pass + green build/test after each wave, then the
non-negotiable 7-item live gate on docker-dev.

What landed

Track 0 — reusable ContextMenu (right-click + ⋯, keyboard/focus); RFC-4180
CsvParser/CsvWriter; DriverTypeNames constants + a reflection-discovery guard;
CalculationEvaluator core (VirtualTag-evaluator parity).
Wave A — IRawTreeService/RawTreeService (lazy tree + mutations, integrity guards,
rename-warnings); /raw page + lazy RawTree with per-node context menus.
Wave B — driver→embeddable-form refactor + DriverConfigModal/DeviceModal
(endpoint→DeviceConfig, Test-connect via merged config); manual tag entry + tag edit
modal + Calculation tag editor; CSV import (staged review grid) / export; all wired into
the tree (name/confirm/driver-type dialogs + post-mutation refresh).
Wave C — browse re-target (two-tier gate, merged-config feed, commit → raw tags with
address-field mapping + folder mirroring); Calculation driver (IDependencyConsumer +
mux adapter, timer + change triggers, DraftValidator scriptId + cycle gates);
DriverTypeNames rewire + retirement of the routed driver flow.

Address space stays dark (values light up in Batch 4). Full solution builds 0 errors;
AdminUI.Tests 638 passed / 3 skipped, Runtime.Tests 357 passed, driver + guard suites green.

Reviewer findings fixed in-branch

Wave B H1 — driver forms still serialized the endpoint into DriverConfig; stripped
the endpoint keys (Modbus/S7/OpcUaClient) so DeviceConfig is the sole source (a 2nd
device on a single-Host driver no longer reverts to 127.0.0.1).
Wave C HIGH — CalculationDriver.ReinitializeAsync ignored the new config, so calc
tag/script edits were silently inert after a redeploy and the re-register loop was
decorative. Now rebuilds the tag/dependency table on reinit and re-registers deps after
the delta applies (DeltaApplied notification, race-free). New redeploy test proves it.
Wave-A/B/0 mediums (auto-expand, friendly create-race/delete failures, discovery-driven
guard, CSV comment). Deferred (documented): pre-existing Modbus/S7 form TimeSpan↔*Ms
DTO mismatch; CSV alarm-subfield/flag-precedence edge cases; OpcUaClient endpoint
precedence; unused LoadMergedProbeConfigAsync; refresh collapses sibling expansion.

Live `/run` gate (docker-dev `:9200`, both central nodes rebuilt)

Authoring + Test-connect — /raw → New Modbus driver gate-modbus (form body renders,
PLC family/MELSEC enum dropdowns correct) → Device1 endpoint 10.100.0.35:5020 in
DeviceConfig → Test connect OK · 94 ms against the live Modbus fixture; SQL confirms
endpoint in DeviceConfig ({"Host":"10.100.0.35","Port":5020,"UnitId":1}).
Historian-tagname deploy block — a historized tag with a 260-char effective tagname →
POST /api/deployments 422 [HistorianTagnameTooLong] tag 'TAG-gatelong' … is 260 chars (max 255); shortened override → 202 Accepted.
CSV round-trip + bad-enum — export produces the exact column dictionary
(…,Region,Address,ModbusDataType,ByteOrder,…); importing 1 valid + 1 bad-enum row →
review grid "2 rows, 1 valid, 1 invalid", row-2 error "Column 'ModbusDataType':
'NOTATYPE' is not a valid ModbusDataType (expected one of: Bool, Int16, UInt16, …)",
Commit disabled (all-or-nothing; SQL confirms nothing committed); a valid-only import →
Commit → ImportedTag lands with typed columns assembled into TagConfig.
Browse-commit — OpcUaClient device → opc-plc (opc.tcp://10.100.0.35:50000): two-tier
gate enabled browse, merged config connected, real tree walked (NetworkSet/…/OpcPlc);
multi-selected 2 leaves with "create matching tag-groups" → raw tags land under the
mirrored Basic group with DataType + the browse ref in the nodeId address field
(nsu=…;s=AlternatingBoolean), not an identity key.
Calculation deploy + cycle gate — a calc tag reading a Modbus RawPath deploys 202;
a 2-cycle (calc1/Engine/A↔calc1/Engine/B) → 422 [CalculationDependencyCycle] … (members: calc1/Engine/A, calc1/Engine/B); clean redeploy 202, no crash loops (both
central nodes stable; only a deploy-reject WRN in the log).
Rename warning — renaming gate-modbus→gate-modbus-renamed fired the warning modal
"1 historized tag beneath this node will change its RawPath (historian tagname)…".
Retired routes — /clusters/{id}/drivers, …/new, …/new/{slug}, …/{id} all
return 404; /raw + /uns still 200.

Docs

docs/Raw.md (new — the /raw authoring tree + endpoint split + CSV + Calculation +
retirement note); CLAUDE.md AdminUI section updated; the Calculation mini-design remains the
driver's authority.

# v3 Batch 2 — `/raw` project-tree AdminUI + `Calculation` driver Implements `docs/plans/2026-07-15-v3-batch2-raw-ui-calculation-plan.md` (Track 0 + WP1–WP8), executed via the `/v3-batch 2` coordinator: contracts-first fan-out, worktree-isolated Opus agents per wave, a code-reviewer pass + green build/test after each wave, then the non-negotiable 7-item live gate on docker-dev. ## What landed - **Track 0** — reusable `ContextMenu` (right-click + `⋯`, keyboard/focus); RFC-4180 `CsvParser`/`CsvWriter`; `DriverTypeNames` constants + a reflection-discovery guard; `CalculationEvaluator` core (VirtualTag-evaluator parity). - **Wave A** — `IRawTreeService`/`RawTreeService` (lazy tree + mutations, integrity guards, rename-warnings); `/raw` page + lazy `RawTree` with per-node context menus. - **Wave B** — driver→embeddable-form refactor + `DriverConfigModal`/`DeviceModal` (endpoint→`DeviceConfig`, Test-connect via merged config); manual tag entry + tag edit modal + `Calculation` tag editor; CSV import (staged review grid) / export; all wired into the tree (name/confirm/driver-type dialogs + post-mutation refresh). - **Wave C** — browse re-target (two-tier gate, merged-config feed, commit → raw tags with address-field mapping + folder mirroring); `Calculation` driver (`IDependencyConsumer` + mux adapter, timer + change triggers, `DraftValidator` scriptId + cycle gates); `DriverTypeNames` rewire + retirement of the routed driver flow. **Address space stays dark** (values light up in Batch 4). Full solution builds 0 errors; `AdminUI.Tests` 638 passed / 3 skipped, `Runtime.Tests` 357 passed, driver + guard suites green. ## Reviewer findings fixed in-branch - **Wave B H1** — driver forms still serialized the endpoint into `DriverConfig`; stripped the endpoint keys (Modbus/S7/OpcUaClient) so `DeviceConfig` is the sole source (a 2nd device on a single-Host driver no longer reverts to `127.0.0.1`). - **Wave C HIGH** — `CalculationDriver.ReinitializeAsync` ignored the new config, so calc tag/script edits were silently inert after a redeploy and the re-register loop was decorative. Now rebuilds the tag/dependency table on reinit and re-registers deps after the delta applies (`DeltaApplied` notification, race-free). New redeploy test proves it. - Wave-A/B/0 mediums (auto-expand, friendly create-race/delete failures, discovery-driven guard, CSV comment). Deferred (documented): pre-existing Modbus/S7 form `TimeSpan`↔`*Ms` DTO mismatch; CSV alarm-subfield/flag-precedence edge cases; OpcUaClient endpoint precedence; unused `LoadMergedProbeConfigAsync`; refresh collapses sibling expansion. ## Live `/run` gate (docker-dev `:9200`, both central nodes rebuilt) 1. **Authoring + Test-connect** — `/raw` → New Modbus driver `gate-modbus` (form body renders, `PLC family`/`MELSEC` enum dropdowns correct) → Device1 endpoint `10.100.0.35:5020` in `DeviceConfig` → **Test connect OK · 94 ms** against the live Modbus fixture; SQL confirms endpoint in `DeviceConfig` (`{"Host":"10.100.0.35","Port":5020,"UnitId":1}`). 2. **Historian-tagname deploy block** — a historized tag with a 260-char effective tagname → `POST /api/deployments` **422** `[HistorianTagnameTooLong] tag 'TAG-gatelong' … is 260 chars (max 255)`; shortened override → **202 Accepted**. 3. **CSV round-trip + bad-enum** — export produces the exact column dictionary (`…,Region,Address,ModbusDataType,ByteOrder,…`); importing 1 valid + 1 bad-enum row → review grid "2 rows, 1 valid, 1 invalid", row-2 error *"Column 'ModbusDataType': 'NOTATYPE' is not a valid ModbusDataType (expected one of: Bool, Int16, UInt16, …)"*, **Commit disabled** (all-or-nothing; SQL confirms nothing committed); a valid-only import → Commit → `ImportedTag` lands with typed columns assembled into `TagConfig`. 4. **Browse-commit** — OpcUaClient device → opc-plc (`opc.tcp://10.100.0.35:50000`): two-tier gate enabled browse, merged config connected, real tree walked (NetworkSet/…/OpcPlc); multi-selected 2 leaves with "create matching tag-groups" → raw tags land under the mirrored `Basic` group with DataType + the browse ref in the `nodeId` address field (`nsu=…;s=AlternatingBoolean`), not an identity key. 5. **Calculation deploy + cycle gate** — a calc tag reading a Modbus RawPath deploys **202**; a 2-cycle (`calc1/Engine/A`↔`calc1/Engine/B`) → **422** `[CalculationDependencyCycle] … (members: calc1/Engine/A, calc1/Engine/B)`; clean redeploy 202, no crash loops (both central nodes stable; only a deploy-reject WRN in the log). 6. **Rename warning** — renaming `gate-modbus`→`gate-modbus-renamed` fired the warning modal *"1 historized tag beneath this node will change its RawPath (historian tagname)…"*. 7. **Retired routes** — `/clusters/{id}/drivers`, `…/new`, `…/new/{slug}`, `…/{id}` all return **404**; `/raw` + `/uns` still 200. ## Docs `docs/Raw.md` (new — the `/raw` authoring tree + endpoint split + CSV + Calculation + retirement note); `CLAUDE.md` AdminUI section updated; the Calculation mini-design remains the driver's authority.

dohertj2 added 35 commits 2026-07-16 05:28:03 -04:00

feat(adminui): T0-1 reusable ContextMenu component + demo page 1d7afbb1eb

Adds a reusable right-click / context menu Blazor component for the AdminUI:
- ContextMenu.razor: right-click surface (browser menu suppressed) + optional
  ellipsis fallback trigger, both anchoring the menu at the pointer; keyboard
  nav (arrows/Enter/Esc), transparent backdrop outside-click close (no JS).
- ContextMenu.razor.css: scoped styles on the shared theme tokens.
- ContextMenuItem.cs: Label/OnClick/Icon/Disabled/IsSeparator model + Separator().
- Dev demo page at /dev/context-menu-demo.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

feat(core): T0-3 DriverTypeNames constants + reflection guard 12b9978974

Add DriverTypeNames as the single source of truth for driver-type
dispatch strings, one const per currently-registered driver factory
(value = the exact factory DriverTypeName). Fixes the latent drift
between hand-authored dispatch-map literals and the real factory names
(e.g. TwinCAT/FOCAS/GalaxyMxGateway) at the source.

A reflection guard test in Core.Abstractions.Tests builds the real
registered-factory set by driving each *DriverFactoryExtensions.Register
into a live DriverFactoryRegistry (mirroring the Host's
DriverFactoryBootstrap) and asserts bidirectional parity with the
constants, so any future rename on either side breaks the test gate.

Consumers are rewired in Batch 2 WP8; Calculation's const lands with its
factory in WP7.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

feat(commons): T0-2 RFC-4180 CSV parser + writer 17c7e97efb

Add a pure, no-I/O RFC 4180 CSV reader and writer to the Commons project
(greenfield — no CSV code existed).

CsvParser: string / TextReader -> rows of string[]; streaming IEnumerable
overload + eager Parse(string) + thin ParseWithHeader. Handles quoted
fields (embedded delimiter/CR/LF/CRLF, "" -> " escape), space
preservation, CRLF/LF/CR terminators, no phantom trailing row. Strict
malformed-input policy: FormatException with 1-based line/column on a
quote inside an unquoted field, a char after a closing quote, or an
unterminated quote. Faithful empty-line policy: a blank line is one empty
field (callers filter).

CsvWriter: rows -> string / TextWriter; quote-on-demand (delimiter, quote,
CR, LF only; internal quotes doubled), configurable delimiter/newline
(default CRLF), optional quote-all, no trailing terminator.

Tests (xUnit + Shouldly, 109): full RFC edge corpus for the parser, the
writer quote-on-demand rules, and the required Parse(Write(rows)) == rows
round-trip property over a table of every tricky character (x CRLF/LF/
quote-all/semicolon).

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

feat(driver-calc): T0-4 Calculation evaluator core + project 86ca1a76d1

New Driver.Calculation project + CalculationEvaluator, mirroring the
VirtualTag RoslynVirtualTagEvaluator: source-hash compile cache
(CompiledScriptCache), 2 s TimedScriptEvaluator, passthrough fast-path,
single-tag mode (ctx.SetVirtualTag dropped + logged), sandbox/compile/
timeout/throw all surfaced as VirtualTagEvalResult.Failure for WP7 to map
to Bad quality. IScriptCacheOwner.ClearCompiledScripts for the deploy
generation boundary. 11 parity unit tests. Both projects added to the
solution. Evaluator + tests only — driver shell / registration is WP7.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

merge wt/t0-1 into v3/batch2-raw-ui (Track 0) 1fb96afd8b

merge wt/t0-2 into v3/batch2-raw-ui (Track 0) 3c34f58bd2

merge wt/t0-3 into v3/batch2-raw-ui (Track 0) a38af16f0f

merge wt/t0-4 into v3/batch2-raw-ui (Track 0) 9a896efecd

review(track0): async ContextMenu OnClick + keyboard-⋯ anchoring + focus-return; discovery-driven DriverTypeNames guard; CSV round-trip comment c3277b52c9

Wave-0 reviewer findings (no Critical/High):
- T0-1 M: ContextMenuItem.OnClick Action→Func<Task> (kills async-void at menu call sites Wave A/B/C need); keyboard-activated ⋯ now anchors below the button instead of viewport (0,0); focus returns to trigger on close; backdrop closes on native right-click too.
- T0-3 M: guard test now discovers *DriverFactoryExtensions.Register by convention from the deployed driver assemblies instead of a hand-copied list, so a future driver lacking a constant is actually caught.
- T0-2 L: corrected the round-trip 'sole non-round-trippable shape' comment (any table whose final row is a lone empty field).

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

contracts(b2-waveA): RawNode view-model + IRawTreeService read surface + RawRenameResult fbf3c26c2a

Wave A contract-first fan-out types for the /raw project tree:
- RawNode/RawNodeKind: shared tree view-model (Enterprise→Cluster→Folder→Driver→Device→TagGroup→Tag), lazy-load metadata, per-kind ids + DriverType propagation for menu gating.
- IRawTreeService: committed READ surface (LoadRootsAsync + LoadChildrenAsync); WP1 extends with the mutation surface, WP2 consumes read-only.
- RawRenameResult: rename outcome carrying non-blocking warnings (historized/UNS-referenced now; script-scan in Batch 3).

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

feat(adminui): B2-WP2 /raw page + lazy RawTree + context menus (modals stubbed) b80b27f44b

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

feat(adminui): B2-WP1 RawTreeService + lazy tree data layer + mutations 76b8325b84

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

merge wt/wp1 into v3/batch2-raw-ui (Wave A) 9ff224012a

merge wt/wp2 into v3/batch2-raw-ui (Wave A) fa9d2af430

review(b2-waveA): /raw auto-expand enterprise roots; friendly create-race + delete failures; auth-guard classifies /raw + dev demo 928e06dd01

Wave-A reviewer findings (no Critical/High):
- M-2: GlobalRaw auto-expands Enterprise roots so the Cluster level is visible on load (mirrors GlobalUns.ExpandStructural); clusters stay lazily collapsed.
- L-1: create mutations route SaveChanges through SaveCreateAsync — a lost sibling-name race (filtered-unique-index clash) becomes a friendly failure instead of an uncaught DbUpdateException.
- L-2: SaveDeleteAsync no longer leaks raw EF/SQL text; operator-friendly guidance.
- L-5: RawNode.ChildCount doc clarified (direct children only).
- Regression fix: PageAuthorizationGuardTests classifies the two new routable pages (/raw → ConfigEditor, /dev/context-menu-demo → AuthenticatedRead).
M-1 (ordinal vs SQL-collation sibling uniqueness) assessed benign: name indexes use the DB default collation and the server-side pre-check runs under that same collation, so pre-check and index agree — no case-variant rows can coexist, so runtime ordinal RawPath keying never collides.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

feat(adminui): B2 Wave-B service prelude — tag CRUD/import + driver/device config + merged probe 76cffe1f49

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

merge wt/wpb0 into v3/batch2-raw-ui (Wave-B service prelude) 54ab413396

feat(adminui): B2-WP4 manual tag entry + raw tag modal + Calculation editor ada552fbec

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

feat(adminui): B2-WP5 CSV tag import/export + review grid 59ea02d971

Staged CSV tag import (upload -> parse -> review grid with per-row verdicts
-> all-or-nothing commit) and export for the /raw tree Device/TagGroup.

- CsvColumnMap: per-driver typed column <-> TagConfig JSON maps (model-backed
  for the 7 typed drivers, raw-key for Galaxy/Calculation) + the common column
  dictionary; typed columns merge OVER the TagConfigJson fallback (typed wins).
- RawTagCsvMapper: pure parse (review rows + verdicts + typed/fallback
  provenance + intra-batch dup detection) and export (residual TagConfigJson)
  over the T0-2 CsvParser/CsvWriter.
- RawTagCsvExportReader: DbContext-backed read helper (no IRawTreeService
  extension) enumerating a device's tags + reconstructing group paths.
- RawCsvImportModal + RawCsvExportModal (data-URI download).
- Reflection guard test (typed column -> real model property + batch-plan
  dictionary parity) + export->import round-trip property test.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

feat(adminui): B2-WP3 driver/device config modals + page-to-form refactor 844f93f64f

Extract the 8 typed driver pages into embeddable <Driver>DriverForm bodies
(channel/protocol config) and add per-driver <Driver>DeviceForm bodies
(connection endpoint -> Device.DeviceConfig, v3 endpoint split). New
DriverConfigModal + DeviceModal dispatch by DriverType (DriverTypeNames) for
the /raw tree; Test-connect inside DeviceModal builds the merged Driver+Device
config transiently via DriverDeviceConfigMerger. Routed pages now host the
form bodies and keep working. Round-trip + enum-serialization guard tests for
the Modbus driver form + Modbus device model; retargeted the existing
page-form serialization tests + the _jsonOpts converter guard to the forms.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

merge wt/wp3 into v3/batch2-raw-ui (Wave B UI) 038ffc161b

merge wt/wp4 into v3/batch2-raw-ui (Wave B UI) d949bcffc1

merge wt/wp5 into v3/batch2-raw-ui (Wave B UI) f986519317

feat(adminui): B2 Wave-B integration — wire real /raw modals + dialogs + refresh aef9ef8452

Replace RawTree's 22 stub handlers with the real Wave-B modals and 3 new
small dialogs, plus post-mutation subtree refresh:

- New dialogs: RawNameDialog (create/rename, RawPaths.ValidateSegment inline),
  RawConfirmDialog (deletes), RawDriverTypeDialog (New driver type+name picker,
  incl. Calculation).
- Configure driver/device -> DriverConfigModal/DeviceModal (edit); New device ->
  DeviceModal (create); Edit tag -> RawTagModal; Manual entry / CSV import/export
  -> the Raw*Modal surfaces; New folder/tag-group/group + New driver + Rename +
  Delete + Toggle -> IRawTreeService directly via the dialogs.
- Refresh: reload the container after create-under, the parent after item-level
  ops (parent found by searching the loaded tree; robust, non-throwing).
- Rename warnings + blocked-delete errors surfaced via the repurposed RawStubModal
  message surface. Browse device stays a placeholder (Wave C). Driver-level
  'Test connect' menu item removed (test-connect now lives on the device modal).

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

merge wt/wpint into v3/batch2-raw-ui (Wave-B integration wiring) d6d454347f

review(b2-waveB): strip endpoint keys from driver-form config (H1) so DeviceConfig is sole endpoint source ae9f906f52

Reviewer H1 (v3 regression): the endpoint→DeviceConfig split ADDED the endpoint to DeviceConfig but
the driver forms still serialized it into DriverConfig at defaults. Single-device worked only by an
STJ case-insensitive last-key-wins accident; a 2nd device on a single-top-level-Host driver (Modbus/S7)
silently reverted to the driver-form default (host=127.0.0.1). Fix: Modbus/S7/OpcUaClient driver-form
GetConfigJson strips the endpoint keys (host/port/unitId; host/port/rack/slot; scalar endpointUrl) from
the serialized channel config, leaving DeviceConfig as the sole source (OpcUaClient keeps its endpointUrls
failover list, which is driver-level policy).

Enum-serialization verified CLEAN fleet-wide; ImportTagsAsync all-or-nothing verified; RawTree wiring sound.
Deferred (documented in PR): H2 pre-existing Modbus/S7 form TimeSpan vs factory *Ms-int DTO mismatch (authored
durations dropped — predates v3); M1 CSV export drops non-columned alarm sub-keys; M2 blank flag column
clobbers a base-JSON isHistorized/isArray; M3 OpcUaClient device/driver endpoint precedence; L1 unused
LoadMergedProbeConfigAsync; L5 refresh collapses sibling expansion.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

feat(adminui): B2-WP6 browse re-target — /raw device browse commits raw tags 1f43449942

Browse device… on a /raw Device/TagGroup opens the discovery-browser modal
against the merged Driver+Device config and commits selected browse leaves as
raw Tag rows under the target, via IRawTreeService.ImportTagsAsync.

- RawBrowseModal.razor: two-tier browse gate (bespoke IDriverBrowser →
  universal DiscoveryDriverBrowser via SupportsOnlineDiscovery → disabled),
  merged config from LoadMergedProbeConfigAsync, multi-select over
  DriverBrowseTree, opt-in 'create matching tag-groups' folder mirror,
  commit via ImportTagsAsync.
- RawBrowseCommitMapper: pure leaf→RawTagImportRow mapper — DriverDataType→
  OPC UA type, per-driver address field (nodeId/tagPath/symbolPath/address/
  attributeRef), target-group + mirror path combine. Unit-tested (39 tests).
- DriverBrowseTree: additive multi-select mode (checkboxes + ancestor-path
  callback), default off preserves single-select pickers.
- RawTree: OnBrowseDevice wired to the modal (Device + TagGroup menus).

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

merge wt/wp6 into v3/batch2-raw-ui (Wave C — browse re-target) c07bbf7fd3

feat(driver-calc): B2-WP7 Calculation driver — IDependencyConsumer + triggers + deploy cycle gate 53d222e0f7

Adds the Calculation pseudo-driver (tags computed by C# scripts over other tags' live
values) plus the host seam that feeds it:

- IDependencyConsumer capability interface (Core.Abstractions) + DriverTypeNames.Calculation.
- CalculationDriver : IDriver, ISubscribable, IReadable, IDependencyConsumer — change-gate +
  dedupe (VirtualTagActor parity), timer-group scheduler, Bad-transition + script-log emission,
  Good recovery; reuses the T0-4 CalculationEvaluator.
- DriverHostActor spawns a DependencyConsumerMuxAdapter per dependency-consuming driver,
  registering its refs on the per-node DependencyMuxActor and forwarding DependencyValueChanged
  → OnDependencyValue; re-registers on every apply, torn down with the driver.
- Factory + probe registered in DriverFactoryBootstrap (keeps the T0-3 guard green); guard test
  csproj references the driver so the bin-scan discovers the factory.
- DeploymentArtifact injects the resolved scriptSource (scriptId → SourceCode) into a calc tag's
  delivered TagConfig so the host-blind driver can compile it.
- DraftValidator deploy gates: CalculationScriptMissing / CalculationScriptNotFound (scriptId
  existence) + CalculationDependencyCycle (DependencyGraph.DetectCycles over calc→calc edges).
- Tests: driver units (dep-ref extraction, change-gate, dedupe, Bad+script-log+recovery, timer,
  read), tag-config parsing, DraftValidator gates (self/2-cycle/cross-driver-terminal), and a
  Runtime integration test proving values FLOW mux → adapter → driver → calc-of-calc end-to-end.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

merge wt/wp7 into v3/batch2-raw-ui (Wave C — Calculation driver) dc80a3b4f6

refactor(adminui): B2-WP8 DriverTypeNames rewire + retire routed driver-authoring flow 96471d2345

Part 1 — rewire the three DriverType dispatch maps from hand-authored string
literals to the canonical DriverTypeNames constants (single source of truth):
- TagConfigEditorMap, TagConfigValidator (AdminUI)
- EquipmentTagConfigInspector (ControlPlane)
This FIXES the live drift ("TwinCat"->TwinCAT, "Focas"->FOCAS). The maps are
OrdinalIgnoreCase so behavior is identical; the value is no future drift.
Calculation is not added to the inspector (no CalculationTagDefinitionFactory.Inspect).
Added TagConfigDriverTypeNameGuardTests pinning the maps to the constants.

Part 2 — retire the routed /clusters/{id}/drivers driver-authoring flow (/raw
Waves A-C now cover driver/device/tag authoring end-to-end):
- Deleted DriverTypePicker, DriverEditRouter, the 8 *DriverPage shells, and the
  ClusterDrivers list page.
- Removed the "Drivers" tab from ClusterNav. Routes /clusters/{id}/drivers* now
  simply do not exist -> clean 404.
- The Forms/DeviceForms bodies, shared driver sections, and address pickers used
  by the /raw modals are untouched.

Part 3 — updated PageAuthorizationGuardTests census: removed the 10 deleted
ConfigEditor pages + ClusterDrivers, updated group-count comments (ConfigEditor
21->11, AuthenticatedRead 17->16). Removed the now-dead Clusters.Drivers usings
from the 4 *DriverPageFormSerializationTests + the guard test.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

merge wt/wp8 into v3/batch2-raw-ui (Wave C — DriverTypeNames rewire + retire routed driver flow) 2e6e89f4a5

fix(driver-calc): rebuild calc tag state on ReinitializeAsync + re-register deps post-apply (review HIGH) af5e062ba4

A calc-tag add/remove/edit or a script edit changes the merged DriverConfig,
which DriverSpawnPlanner routes to an in-place ApplyDelta (not a respawn), i.e.
CalculationDriver.ReinitializeAsync. The old ReinitializeAsync ignored the new
config: the tag table + dependency-ref set were built once at construction and
never rebuilt, so after a redeploy added tags never computed, removed tags kept
publishing, and edited scripts served stale results (deploy reported success).

Part 1 (HIGH): extract RebuildTagTable(config) — shared by the ctor and reinit
so they cannot drift — and have ReinitializeAsync re-bind the new config
(ParseOptions) and rebuild _tagsByRawPath/_changeDependents/_dependencyRefs/
_stateByRawPath under _lock, preserving last-known state for surviving tags,
dropping removed tags, and starting new tags fresh. _dependencyRefs now reflects
the new authored tags. Corrected the now-false ReinitializeAsync comment.

Part 2 (MEDIUM ordering hazard): the host's ReRegister was Tell-ed synchronously
alongside the ApplyDelta Tell, so the adapter re-read DependencyRefs before the
async ReinitializeAsync rebuilt them (stale set, no self-correction). Now
DriverInstanceActor sends DeltaApplied(driverInstanceId) to DriverHostActor
AFTER ReinitializeAsync completes, and HandleDeltaApplied re-registers only that
driver's adapter — sequenced after the rebuild. Removed the inline loop.

Test: added a redeploy test to CalculationDependencyFlowTests exercising the
real DependencyMuxActor + adapter + driver — a new tag reading a NEW dep flows +
computes, a removed tag stops publishing, an edited script serves the new
result, and DependencyRefs re-registers the new set. Fails on pre-fix code
(DependencyRefs stays stale ["src/a"]), passes after the fix.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

merge wt/wpfix into v3/batch2-raw-ui (Wave C review HIGH: calc-driver redeploy staleness) c598978d77

docs(v3): Batch 2 — /raw authoring tree guide + CLAUDE.md + PR description

v2-ci / build (pull_request) Successful in 3m25s

Details

v2-ci / unit-tests (pull_request) Failing after 8m37s

Details

33915c9e4d

docs/Raw.md (the /raw project tree: lazy tree, endpoint→DeviceConfig split, manual/CSV/browse
authoring, Calculation driver, routed-flow retirement); CLAUDE.md AdminUI section notes /raw +
DriverTypeNames rewire + Calculation driver; PR body with the 7-item live-gate evidence.

Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox

dohertj2 merged commit a88dc86173 into master

2026-07-16 05:50:28 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#470