R2-11 TagConfig consolidation (arch-review round 2) #434

2026-07-13T11:27:03-04:00

dohertj2 commented

2026-07-13 11:27:03 -04:00

Round-2 arch-review plan R2-11 (findings 01/C-1, 01/P-1 + 05 ReadEnum/Writable/capability — 3-phase strictness rollout).

Part 1 (C-1/P-1): TagConfigIntent.Parse + DeviceConfigIntent in Commons are the single byte-parity home; the four hand-synced copies (composer, DeploymentArtifact, EquipmentNodeWalker, DraftValidator) delegate; composer parses once per tag (P-1). Permanent 30-blob parity corpus guards compose≡decode.
Part 2 (CONV-2/UNDER-1/UNDER-6): shared strict-capable TagConfigJson readers in Core.Abstractions replace the six ReadEnum copies; every driver parser gained Inspect() + honours writable (FOCAS forced read-only + capability-matrix pre-flight → BadNodeIdUnknown); Modbus probe parses the factory DTO shape (timeoutMs no longer dropped). New EquipmentTagConfigInspector + AdminOps deploy-gate with Deployment:TagConfigValidationMode (Warn default | Error opt-in). AdminUI: Writable checkbox in the six typed editors.
Phase C (runtime-strict flip) deliberately deferred — behavior change to land only after fleets run Error mode clean.

22/24 tasks; T22 (AdminUI Writable /run) + T24 (full sweep) deferred to serial heavy pass. Build clean (production projects TreatWarningsAsErrors); parity corpus + 6 driver strictness suites + Commons TagConfigIntent 48 all green; grep gates (MUST-parse-identically / ReadEnum copies) = 0. Plan: archreview/plans/R2-11-tagconfig-consolidation-plan.md.

Round-2 arch-review plan **R2-11** (findings 01/C-1, 01/P-1 + 05 ReadEnum/Writable/capability — 3-phase strictness rollout). - **Part 1 (C-1/P-1):** `TagConfigIntent.Parse` + `DeviceConfigIntent` in Commons are the single byte-parity home; the four hand-synced copies (composer, DeploymentArtifact, EquipmentNodeWalker, DraftValidator) delegate; composer parses once per tag (P-1). Permanent 30-blob parity corpus guards compose≡decode. - **Part 2 (CONV-2/UNDER-1/UNDER-6):** shared strict-capable `TagConfigJson` readers in Core.Abstractions replace the six `ReadEnum` copies; every driver parser gained `Inspect()` + honours `writable` (FOCAS forced read-only + capability-matrix pre-flight → BadNodeIdUnknown); Modbus probe parses the factory DTO shape (timeoutMs no longer dropped). New `EquipmentTagConfigInspector` + AdminOps deploy-gate with `Deployment:TagConfigValidationMode` (Warn default | Error opt-in). AdminUI: Writable checkbox in the six typed editors. - **Phase C (runtime-strict flip) deliberately deferred** — behavior change to land only after fleets run Error mode clean. 22/24 tasks; **T22 (AdminUI Writable /run) + T24 (full sweep) deferred** to serial heavy pass. Build clean (production projects TreatWarningsAsErrors); parity corpus + 6 driver strictness suites + Commons TagConfigIntent 48 all green; grep gates (MUST-parse-identically / ReadEnum copies) = 0. Plan: `archreview/plans/R2-11-tagconfig-consolidation-plan.md`.

dohertj2 added 24 commits 2026-07-13 11:27:04 -04:00

test(runtime): golden TagConfig corpus + compose/decode parity characterization (R2-11) 2e14fe1f24

test(core,config): FullName-semantics characterization for walker + draft gate (R2-11) 353f04b70c

feat(commons): TagConfigIntent.Parse — single home for the byte-parity TagConfig intents (R2-11, 01/C-1) cd3f1270ee

feat(commons): DeviceConfigIntent — device-host extraction + normalization home (R2-11) b6633f7562

refactor(opcuaserver): composer parses TagConfig once per tag via TagConfigIntent (R2-11, 01/P-1) a452a20947

Deletes the composer's ExtractTagFullName/Alarm/Historize/Array statics and (co-located
to keep the build green, per plan T5) the three OpcUaServer.Tests ExtractTag* suites whose
tables now live in Commons.Tests/TagConfigIntentTests. T10 is the grep-sweep verification.

refactor(runtime,opcuaserver): device-host normalization re-homed to Commons DeviceConfigIntent (R2-11) 7bbec77716

refactor(runtime): DeploymentArtifact decodes TagConfig via shared TagConfigIntent (R2-11, 01/C-1) c1e19ea954

refactor(config): DraftValidator Galaxy rule reads ExplicitFullName via TagConfigIntent (R2-11) a3c2b11e34

refactor(core): EquipmentNodeWalker.ExtractFullName delegates to TagConfigIntent; repoint canonical-parser doc cites (R2-11) 4b86beef28

Full walker deletion remains round-1 U-1's task.

test(opcuaserver): retire ExtractTag* tests — byte-parity authority is Commons TagConfigIntentTests (R2-11) 9c94d51bf4

Verification: grep 'MUST parse identically' src/ → 0 hits. Deletions co-located into T5/T6 for
green builds; recorded under Execution deviations.

feat(core-abstractions): TagConfigJson shared strict-capable field readers (R2-11, 05/CONV-2) a9b7a5002a

feat(driver-modbus): shared TagConfigJson readers, writable key, Inspect warnings (R2-11) 64b9bba9e9

feat(driver-s7): shared TagConfigJson readers, writable key, Inspect warnings (R2-11) 1cceef406e

feat(driver-abcip): shared TagConfigJson readers + Inspect warnings (R2-11) d374ba332b

feat(driver-ablegacy): shared TagConfigJson readers, writable key, Inspect warnings (R2-11) 6e2415bb4c

feat(driver-twincat): shared TagConfigJson readers, writable key, Inspect warnings (R2-11) 4f5bbd253c

fix(driver-focas): equipment tags forced read-only until PMC writes exist; shared readers + Inspect (R2-11, 05/UNDER-1) e294416087

fix(driver-focas): equipment tags run the capability-matrix pre-flight authored tags get (R2-11, 05/UNDER-6) 24435efa8b

fix(driver-modbus): probe parses the factory DTO shape — timeoutMs no longer silently dropped (R2-11, 05/CONV-2) b2a56ebf3b

feat(controlplane): EquipmentTagConfigInspector — DriverType-dispatched deploy-time TagConfig inspection (R2-11) 8401055c9d

feat(controlplane): deploy-gate TagConfig strictness — Warn default, Error opt-in at the draft gate (R2-11, 05/CONV-2) 4260b6ecaa

feat(adminui): writable checkbox in driver-typed tag editors (R2-11, 05/UNDER-6) 4449baac69

Models gain an optional bool? Writable (absent stays omitted; explicit false round-trips,
unknown keys preserved); the six editors gain a Writable checkbox (FOCAS disabled+read-only
hint). 9 model round-trip tests green. docker-dev /run verify of one editor deferred-live.

docs: R2-11 TagConfig consolidation + strictness rollout decisions 7fc3b19961

docs(r2-11): record T24 final-sweep gates (grep clean, build 0 errors) + deferred-live notes

v2-ci / build (pull_request) Successful in 3m42s

Details

v2-ci / unit-tests (pull_request) Failing after 8m34s

Details

7c7d383da6

dohertj2 commented

2026-07-13 11:29:34 -04:00

Landed on master via merge commit 1a698cbb (local --no-ff merge). Auto-merged AddressSpaceApplier.cs + DriverHostActor.cs against R2-04/R2-10; verified semantically via OpcUaServer.Tests 286/286 + Runtime.Tests 396/396 + clean build barrier. Phase C runtime-strict flip + T22/T24 deferred. Closing as merged.

Landed on `master` via merge commit `1a698cbb` (local --no-ff merge). Auto-merged AddressSpaceApplier.cs + DriverHostActor.cs against R2-04/R2-10; verified semantically via OpcUaServer.Tests 286/286 + Runtime.Tests 396/396 + clean build barrier. Phase C runtime-strict flip + T22/T24 deferred. Closing as merged.

dohertj2 closed this pull request

2026-07-13 11:29:34 -04:00

dohertj2 referenced this issue from a commit

2026-07-13 11:29:35 -04:00

Merge R2-11 TagConfig consolidation (arch-review round 2) [PR #434]

v2-ci / build (pull_request) Successful in 3m42s

Details

v2-ci / unit-tests (pull_request) Failing after 8m34s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#434