AB CIP PR 9-12 � Per-family profile tests + GuardLogix safety-tag support #116

dohertj2 · 2026-04-19T17:20:40-04:00

dohertj2 commented

2026-04-19 17:20:40 -04:00

Consolidates PRs 9/10/11/12 � ControlLogix / CompactLogix / Micro800 / GuardLogix profile-metadata assertions + integration-surface wiring. Per-family live-wire tests deferred to the ab_server-CI follow-up. New AbCipTagDefinition.SafetyTag field for GuardLogix � forces ViewOnly in discovery + rejects writes with BadNotWritable. 14 new tests, 161/161 passing. Merges to v2.

Consolidates PRs 9/10/11/12 � ControlLogix / CompactLogix / Micro800 / GuardLogix profile-metadata assertions + integration-surface wiring. Per-family live-wire tests deferred to the ab_server-CI follow-up. New `AbCipTagDefinition.SafetyTag` field for GuardLogix � forces ViewOnly in discovery + rejects writes with BadNotWritable. 14 new tests, 161/161 passing. Merges to v2.

dohertj2 added 1 commit 2026-04-19 17:20:41 -04:00

AB CIP PR 9-12 — Per-PLC-family profile tests + GuardLogix safety-tag support. Consolidates PRs 9/10/11/12 from the plan (ControlLogix / CompactLogix / Micro800 / GuardLogix integration suites) into a single PR because the per-family work that actually ships without a live ab_server binary is profile-metadata assertion + unit-level driver-option binding. Per-family integration tests that require a running simulator are deferred to the ab_server-CI follow-up already tracked from PR 3 (download prebuilt Windows binary as GitHub release asset). ControlLogix — baseline profile asserted (controllogix attribute, 4002 LFO ConnectionSize, 1,0 default path, request-packing + connected-messaging, 4000B max fragment). CompactLogix — narrower 504 ConnectionSize for 5069-L3x safety, 500B max fragment, lib attribute compactlogix which libplctag maps to the ControlLogix family internally but via our profile chain we surface it as a distinct knob so future quirk handling (5069 narrow-window regression cases) hangs off the compactlogix attribute. Micro800 — empty CIP path for no-backplane routing, 488B ConnectionSize, 484B fragment cap, request packing + connected messaging both disabled (most models reject Forward_Open), micro800 lib attribute. Test asserts the driver correctly parses an ab://192.168.1.20/ host address with empty path + forwards the empty path through AbCipTagCreateParams so libplctag sees the unconnected-only configuration. GuardLogix — wire protocol identical to ControlLogix (safety partition is a per-tag concern, not a wire-layer distinction) so profile defaults match ControlLogix. New AbCipTagDefinition.SafetyTag field — when true, the driver forces SecurityClassification.ViewOnly in discovery regardless of the Writable flag, and IWritable rejects the write upfront with BadNotWritable. Matches the Rockwell safety-partition isolation model where non-safety-task writes to safety tags would be rejected by the PLC anyway — surfacing the intent at the driver surface prevents wasted wire round-trips + gives Admin UI users a correct ViewOnly rendering. 14 new unit tests in AbCipPlcFamilyTests covering — ControlLogix profile defaults + correct profile selection at Initialize, CompactLogix narrower-than-ControlLogix ConnectionSize + fragment cap, Micro800 empty path parses + SupportsConnectedMessaging=false + SupportsRequestPacking=false + read forwards empty path + micro800 attribute through to libplctag, GuardLogix wire-protocol parity with ControlLogix, GuardLogix safety tag surfaces as ViewOnly in discovery even when Writable=true, GuardLogix safety-tag write rejected with BadNotWritable even when Writable=true, ForFamily theory (4 families → correct libplctag attribute). Total AbCip unit tests now 161/161 passing (+14 from PR 8's 147). Modbus + other drivers untouched; full solution builds 0 errors. PR 13 (IAlarmSource via tag-projected ALMA/ALMD blocks) remains deferred per the plan — feature-flagged pattern not needed before go-live. 60b8d6f2d0

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

dohertj2 merged commit 70f5f2cad1 into v2

2026-04-19 17:20:44 -04:00

dohertj2 referenced this issue from a commit

2026-04-19 17:20:46 -04:00

Merge pull request (#116) - AbCip family profiles

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#116