lmxopcua

dohertj2/lmxopcua

Fork 0

...

Author SHA1 Message Date

Author	SHA1	Message	Date
Joseph Doherty	0e93587b1c	merge: test-correctness, config-secret and AdminUI fixes (#503 #501 #493 #499 #488 #505 ) v2-ci / build (push) Successful in 4m14s Details v2-ci / unit-tests (push) Failing after 14m48s Details Six issues closed, one new one found, filed and fixed. - #503 Galaxy EventPump flake — root cause was cross-test measurement leakage on a STATIC Meter, not a timing budget. 15/15 clean under the issue's own contention recipe. Three further defects in the same test fixed on the way, including a "held" dispatch loop that was never held (async void on EventHandler<T>) and an assertion built from a derived quantity, which could only fail spuriously. - #501 Three absence assertions given positive controls (a fourth site the issue did not list). Proven falsifiable by breaking the production code: both breaks passed under the old AwaitAssert form. - #493 docker-dev seed backfills ClusterNode.GrpcPort; upgrade step documented. Deliberately no EF migration — the right value is per-node config the DB cannot derive, and a wrong dial target is worse than a NULL that is already skipped. - #499 Sql credentials refused in ClusterNode.DriverConfigOverridesJson, gated at the SAVE rather than the deploy: node overrides never enter the artifact, so a deploy gate would not stop the credential being stored. Live-verified. - #488 Periodic desired-vs-actual subscription reconcile (option A), gated on ISubscribable so a non-subscribable driver is not Subscribe-spammed forever. - #505 The AdminUI cluster-node editor had never worked at all — HTTP 500 on load (InputNumber<byte>) and Save a silent no-op (NodeId regex forbids the ':' every NodeId contains), with no ValidationSummary to reveal it. Pre-existing on master, invisible to 739 green AdminUI tests, found only by going to drive the page. Also closed #492 (already fixed by `2964361a` and drill-verified; no code change). Verified: solution builds 0 errors; 2406 tests pass across Runtime (507), AdminUI (739), Configuration (131), Galaxy (317), Cluster (147), Core (260), ScriptedAlarms (82) and Sql (223). #499 and #505 live-gated on docker-dev with both central nodes rebuilt; rig restored afterwards.	2026-07-26 10:51:43 -04:00

Joseph Doherty

0e93587b1c

merge: test-correctness, config-secret and AdminUI fixes (#503 #501 #493 #499 #488 #505 )

v2-ci / build (push) Successful in 4m14s

Details

v2-ci / unit-tests (push) Failing after 14m48s

Details

Six issues closed, one new one found, filed and fixed.

- #503 Galaxy EventPump flake — root cause was cross-test measurement leakage on a
  STATIC Meter, not a timing budget. 15/15 clean under the issue's own contention
  recipe. Three further defects in the same test fixed on the way, including a
  "held" dispatch loop that was never held (async void on EventHandler<T>) and an
  assertion built from a derived quantity, which could only fail spuriously.
- #501 Three absence assertions given positive controls (a fourth site the issue
  did not list). Proven falsifiable by breaking the production code: both breaks
  passed under the old AwaitAssert form.
- #493 docker-dev seed backfills ClusterNode.GrpcPort; upgrade step documented.
  Deliberately no EF migration — the right value is per-node config the DB cannot
  derive, and a wrong dial target is worse than a NULL that is already skipped.
- #499 Sql credentials refused in ClusterNode.DriverConfigOverridesJson, gated at
  the SAVE rather than the deploy: node overrides never enter the artifact, so a
  deploy gate would not stop the credential being stored. Live-verified.
- #488 Periodic desired-vs-actual subscription reconcile (option A), gated on
  ISubscribable so a non-subscribable driver is not Subscribe-spammed forever.
- #505 The AdminUI cluster-node editor had never worked at all — HTTP 500 on load
  (InputNumber<byte>) and Save a silent no-op (NodeId regex forbids the ':' every
  NodeId contains), with no ValidationSummary to reveal it. Pre-existing on master,
  invisible to 739 green AdminUI tests, found only by going to drive the page.

Also closed #492 (already fixed by 2964361a and drill-verified; no code change).

Verified: solution builds 0 errors; 2406 tests pass across Runtime (507), AdminUI
(739), Configuration (131), Galaxy (317), Cluster (147), Core (260),
ScriptedAlarms (82) and Sql (223). #499 and #505 live-gated on docker-dev with both
central nodes rebuilt; rig restored afterwards.

2026-07-26 10:51:43 -04:00

Compare commits

1 Commits

fix/issues-503-501-493-499-488 ... 0e93587b1c

Diff Content Not Available

Compare commits

1 Commits fix/issues-503-501-493-499-488 ... 0e93587b1c

Diff Content Not Available

1 Commits

fix/issues-503-501-493-499-488 ... 0e93587b1c