15 Commits

Author	SHA1	Message	Date
Joseph Doherty	dc0d7653b9	feat(v3-batch3): B3-WP4 — {{equip}}/<RefName> reference-relative resolution ... Replace the deleted equipment-base-prefix {{equip}} mechanism (impossible now that equipment is reference-only) with per-reference resolution: {{equip}}/<RefName> resolves through the owning equipment's UnsTagReference rows (by effective name) to the backing raw tag's RawPath. Every unresolved <RefName> is a clear deploy error + authoring rejection + Monaco diagnostic — preserving "editor accepts <=> publish accepts". Commons: - EquipmentScriptPaths: delete DeriveEquipmentBase; SubstituteEquipmentToken now takes the equipment's reference map (effectiveName -> RawPath) and substitutes {{equip}}/<RefName> inside path literals (unresolved left intact, never throws); add ExtractEquipReferenceNames (path-literal scoped) + ExtractEquipReferenceNamesFromText (message templates). Slash syntax replaces the v2 dot joint. - New EquipmentReferenceMap: shared, input-shape-agnostic builder (entity + JSON sides) over RawPathResolver — the single authority both compose seams + the validator use, so resolved RawPaths agree byte-for-byte. Compose seams (byte-parity kept): - AddressSpaceComposer.Compose + DeploymentArtifact.ParseComposition both build the per-equipment reference map from UnsTagReferences + Tags + raw topology and substitute VirtualTag AND ScriptedAlarm-predicate sources before dependency extraction (runtime dep refs = resolved RawPaths). Deploy gate + authoring + editor: - DraftValidator.ValidateEquipReferenceResolution: EquipReferenceUnresolved error for unresolved {{equip}}/<RefName> in VirtualTag/ScriptedAlarm scripts + alarm message-template tokens (naming script, equipment, missing ref). - UnsTreeService.ValidateEquipTokenAsync (Wave-A M1): reference-relative authoring rejection, replacing the stale DeriveEquipmentBase(empty)->reject-all logic. - ScriptAnalysisService: {{equip}}/ completion offers the equipment's reference effective names; DiagnoseAsync flags unresolved refs (OTSCRIPT_EQUIPREF) same as the deploy gate. Requests carry optional EquipmentId (threaded MonacoEditor -> monaco-init.js -> fetch bodies). IScriptTagCatalog.GetEquipmentRelativeLeavesAsync repurposed to GetEquipmentReferenceNamesAsync(equipmentId, filter). Tests: EquipmentScriptPaths substitution/extraction (slash pinned); composer<-> artifact reference-resolution byte-parity; DraftValidator unresolved-ref; ScriptAnalysis completion+diagnostic; M1 authoring gate. Build clean (0/0); all five affected suites green. Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox	2026-07-16 06:58:17 -04:00
Joseph Doherty	6a616a1ab2	test(adminui): migrate AdminUI.Tests to v3 greenfield schema + Batch-1 stubs ... Migrate tests/Server/ZB.MOM.WW.OtOpcUa.AdminUI.Tests (was 358 build errors) to the v3 Raw-only Tag schema and the Batch-1 AdminUI stubs. Production untouched. - Driver-page serialization tests: drop the retired pre-declared Tags editor (page *TagRow types + DriverOptions.Tags); multi-device pages keep their Devices editor (ToOptions(devices)). Enum-serialization round-trip coverage (CpuType/ModbusFamily/MelsecFamily/AbCipPlcFamily/AbLegacyPlcFamily/FocasCncSeries) preserved intact. - UnsTreeTestDb: reseed to v3 (Device->Tag raw slice, no EquipmentId/DriverInstanceId on Tag, no Namespace). - UnsTreeService tag tests: assert Batch-1 stubs (CreateTag/UpdateTag refusal, empty tag/tag-driver lists); DeleteTag stays live against a raw Tag. - Equipment #122 guard retained (validates input driver vs line cluster); drop the retired persisted-binding assertions + NamespaceId seeds. Area/Line #122 driver- orphan guard retired -> assert cross-cluster move now succeeds. - DeleteCluster: drop the deleted-Namespace child-check test. - OpcUaClientTagConfigModel/TagConfigValidator: address key FullName -> nodeId. - ScriptTagCatalog: project surviving Name/DataType/TagConfig; DriverInstanceId null. - VirtualTag {{equip}} equipment-tag-derived base is dark -> 3 tests skipped (Batch-3). Result: build green; 507 passed / 3 skipped / 0 failed.	2026-07-15 21:50:48 -04:00
Joseph Doherty	3c908f1df0	review(AdminUI): fix null-TagConfig crash, CTS leak, unencoded historian tag ... Review at HEAD 7286d320. AdminUI-002: IsValidJson null/blank -> friendly error (was ArgumentNullException). AdminUI-003: DriverStatusPanel Reconnect/Restart dispose CTS (build- verified, live /run deferred). AdminUI-005: HistorianWonderware picker URL-encodes tag name. AdminUI-008: Format round-trip test. 001 (script-page authz) + 004 (hub [Authorize]) left Open as cross-cutting w/ Host/Security.	2026-06-19 10:52:23 -04:00
Joseph Doherty	ac3450d5f4	fix(adminui): ctx-receiver guard + truthful SetVirtualTag hover in script-editor completions	2026-06-18 02:39:12 -04:00
Joseph Doherty	c3c5617266	docs(test): neutralize last stale 'SystemPlatform tags' comment (final-review nit)	2026-06-12 22:44:10 -04:00
Joseph Doherty	7d25480fee	docs(galaxy): neutralize remaining stale SystemPlatform/alias terminology in comments + a test name ... Replace "SystemPlatform mirror tag", "Galaxy alias", and "SystemPlatform-kind" in doc-comments and test names with neutral accurate wording ("FolderPath-scoped tag", "EquipmentId == null", etc.). No code, logic, or test bodies changed — comments and one test method name only.	2026-06-12 22:30:50 -04:00
Joseph Doherty	6c23a6763a	test(adminui): DB-backed tests for ScriptTagCatalog.GetEquipmentRelativeLeavesAsync	2026-06-10 08:12:52 -04:00
Joseph Doherty	c7041a24e7	feat(adminui): {{equip}}-aware hover + {{equip}}. leaf completion in the script editor	2026-06-10 08:04:51 -04:00
Joseph Doherty	142635b402	feat(adminui): tag-path hover (tag kind/type/driver inside ctx.GetTag literals)	2026-06-10 05:48:02 -04:00
Joseph Doherty	4a2f7e37e5	feat(adminui): script document formatting (NormalizeWhitespace)	2026-06-09 15:06:40 -04:00
Joseph Doherty	9104b6c614	feat(adminui): script hover + signature help	2026-06-09 15:03:40 -04:00
Joseph Doherty	521fb61e44	feat(adminui): tag-path completion inside ctx.GetTag/SetVirtualTag literals	2026-06-09 14:53:15 -04:00
Joseph Doherty	d1434933b4	feat(adminui): IScriptTagCatalog for tag-path completion	2026-06-09 14:49:19 -04:00
Joseph Doherty	93f5a745a3	feat(adminui): scope + dot-member script completions	2026-06-09 14:36:28 -04:00
Joseph Doherty	6a9b052fc7	feat(adminui): script diagnostics (Roslyn + forbidden-type + dynamic-path)	2026-06-09 14:29:08 -04:00