feat(adminui): script document formatting (NormalizeWhitespace)

2026-06-09 15:06:40 -04:00
parent 9104b6c614
commit 4a2f7e37e5
2 changed files with 46 additions and 1 deletions
@@ -325,6 +325,21 @@ public sealed class ScriptAnalysisService
        }
        catch (Exception ex) { _logger?.LogWarning(ex, "Script signature help failed."); return empty; }
    }
-    public FormatResponse Format(FormatRequest req) => new(req.Code);                                        // Task 8
+    public FormatResponse Format(FormatRequest req)                                                           // Task 8
+    {
+        if (string.IsNullOrEmpty(req.Code)) return new FormatResponse(req.Code);
+        try
+        {
+            var code = Normalize(req.Code);
+            var tree = CSharpSyntaxTree.ParseText(code,
+                new CSharpParseOptions(LanguageVersion.Latest, kind: SourceCodeKind.Script));
+            var formatted = tree.GetRoot().NormalizeWhitespace(indentation: "    ", eol: "\n").ToFullString();
+            return new FormatResponse(formatted);
+        }
+        catch
+        {
+            return new FormatResponse(req.Code);
+        }
+    }
    public InlayHintsResponse InlayHints(InlayHintsRequest req) => new(Array.Empty<InlayHint>());            // Task 8 (stays empty)
 }
@@ -0,0 +1,30 @@
+using Shouldly;
+using Xunit;
+using ZB.MOM.WW.OtOpcUa.AdminUI.ScriptAnalysis;
+
+namespace ZB.MOM.WW.OtOpcUa.AdminUI.Tests.ScriptAnalysis;
+
+public sealed class FormatTests
+{
+    private static readonly ScriptAnalysisService Svc = new();
+    private static string Fmt(string code) => Svc.Format(new FormatRequest(code)).Code;
+
+    [Fact] public void Reflows_crammed_source_to_canonical_layout()
+    {
+        var outp = Fmt("var x=1;return x;");
+        outp.ShouldNotBe("var x=1;return x;");      // it changed
+        outp.ShouldContain("\n");                    // statements split onto separate lines
+        outp.ShouldContain("var x = 1;");            // canonical spacing
+    }
+
+    [Fact] public void Empty_code_is_returned_unchanged()
+        => Fmt("").ShouldBe("");
+
+    [Fact] public void Unparseable_code_is_returned_unchanged()
+    {
+        // a fragment that NormalizeWhitespace can still parse in script mode won't throw;
+        // pass something that round-trips to itself or is returned as-is on failure.
+        var src = "return ctx.GetTag(\"A\").Value;";
+        Fmt(src).ShouldNotBeNull();
+    }
+}