62 Commits

Author	SHA1	Message	Date
Joseph Doherty	23f353e79b	test(adminui): close Phase 6 review test-gaps + Enterprise-delete warning	2026-06-16 17:10:40 -04:00
Joseph Doherty	6a8020e7e7	feat(adminui): native-alarm HistorizeToAveva opt-out	2026-06-16 16:27:31 -04:00
Joseph Doherty	93d9160dae	feat(alarms): DriverHostActor routes native-condition acks to the owning driver [H6d]	2026-06-15 14:46:00 -04:00
Joseph Doherty	4501f12669	feat(vtags): wire IHistoryWriter through DriverHostActor (Null default; durable sink infra-gated) (H5d, stillpending §1)	2026-06-15 10:38:49 -04:00
Joseph Doherty	9c5a091395	feat(vtags): decode VirtualTag Historize from artifact, byte-parity with composer (H5b, stillpending §1)	2026-06-15 10:17:08 -04:00
Joseph Doherty	c9643f68ba	fix(runtime): restart driver no longer throws 'actor name is not unique' ... HandleRestartDriver stopped + respawned the child within one synchronous message handler, reusing the base actor name drv-<id>. Context.Stop is async (the child processes its own stop on its own mailbox), so the old child was ALWAYS still registered when the respawn ran — Context.ActorOf threw InvalidActorNameException deterministically on every AdminUI Restart press, crashing + restarting the host. Fix: a monotonic _childSpawnGeneration counter (single-threaded actor) feeds a -g<gen> suffix on every spawned child name, so a respawn can never collide with the still-terminating predecessor. Children are tracked by the _children dict (by IActorRef), never by actor path, so the suffix is invisible to callers. This also closes the same-shaped latent race in the reconcile path (a removed- then-readded instance, and a driver-type-change ToStop+ToSpawn in one plan). Regression test RestartDriver_respawns_the_child_without_an_actor_name_collision (verified: FAILS on the old code with the exact InvalidActorNameException, PASSES with the fix). Runtime.Tests 238/238 green. Code-reviewed (approved).	2026-06-15 05:41:18 -04:00
Joseph Doherty	7f313df7a6	fix(alarms): subscribe native alarms to un-gate the IAlarmSource feed ... Phase B native alarms never fired end-to-end: GalaxyDriver suppresses OnAlarmEvent until an alarm subscription exists (_alarmSubscriptions.Count > 0), but the runtime only attached the OnAlarmEvent handler and never called SubscribeAlarmsAsync — so the central feed stayed gated and no transition reached the Part 9 condition / /alerts. Unit tests passed because they inject through the IAlarmSource seam directly; the deferred live /run surfaced it. DriverHostActor computes per-driver alarm refs (alarm-bearing tags' FullNames) and hands them via SetDesiredSubscriptions; DriverInstanceActor calls SubscribeAlarmsAsync for IAlarmSource drivers on Connected entry and whenever alarm refs are pushed while Connected (the deploy path), idempotent via a cached handle reset on detach so reconnect re-subscribes.	2026-06-15 00:42:43 -04:00
Joseph Doherty	fa2388eabf	test(alarms): assert reconnect-dropped native alarm does not dead-letter; tighten severity doc ... Add AllDeadLetters probe to Native_alarm_during_reconnect_is_dropped_not_forwarded so the test genuinely guards the Reconnecting state's Receive<NativeAlarmRaised> drop handler — removing that handler would now cause a dead-letter and fail the assertion (false-negative gap closed). Reword the ScriptedAlarms.md severity-mapping note: "snaps on the first transition" → "every transition maps … overriding the authored seed from the first transition onward", clarifying that MapSeverity runs on every event, not just the first.	2026-06-14 22:56:18 -04:00
Joseph Doherty	c03361de1b	test(drivers): extract shared stub-driver harness (de-dup)	2026-06-14 22:49:26 -04:00
Joseph Doherty	d8129e5ab7	test(alarms): fix reconnect-drop test to use mailbox-ordering approach	2026-06-14 22:48:36 -04:00
Joseph Doherty	51cda2c744	test(alarms): assert OperatorComment flows through ForwardNativeAlarm	2026-06-14 22:41:43 -04:00
Joseph Doherty	c8db5767ea	test(alarms): guard native-alarm-during-reconnect is dropped not dead-lettered	2026-06-14 22:41:08 -04:00
Joseph Doherty	c35c1d3734	refactor(historian): single-parse ExtractTagHistorize + review-nit tests/docs ... Stop parsing TagConfig twice per tag on the deploy hot path: Phase7Composer's equipment-tag Select lambda is now block-bodied (captures isHistorized/historianTagname once), and DeploymentArtifact.BuildEquipmentTagPlans captures locals before result.Add. Add wrong-type-historianTagname InlineData to ExtractTagHistorizeTests. Extend the parity round-trip fixture with a 4th tag (isHistorized:false + JSON-null tagname) exercising the artifact-side private guard path. Align DeploymentArtifact's ExtractTagHistorize doc-comment with the composer-side phrasing (ExtractTagFullName / ExtractTagAlarm cross-reference).	2026-06-14 19:02:02 -04:00
Joseph Doherty	440929c82a	feat(historian): carry isHistorized + historianTagname through EquipmentTagPlan (byte-parity)	2026-06-14 18:55:04 -04:00
Joseph Doherty	751786ec8c	fix(drivers): adopt corrected config via ApplyDelta while (re)connecting (#7) ... A DriverInstanceActor stuck Reconnecting/Connecting now adopts a config delivered via ApplyDelta and re-initialises with it, instead of dead-lettering and retrying the stale config forever. A monotonic init generation supersedes the in-flight init so the corrected config always wins.	2026-06-14 17:15:28 -04:00
Joseph Doherty	f9be38430c	fix(alarms): route native alarms by ConditionId (dotted FullName), not bare SourceNodeId (integration review)	2026-06-14 04:09:01 -04:00
Joseph Doherty	7e86fa7099	fix(alarms): normalise native TransitionKind to canonical EmissionKind vocabulary (review)	2026-06-14 03:58:46 -04:00
Joseph Doherty	8736fcc37c	feat(alarms): Primary-gated AlarmTransitionEvent fan-out for native alarms (Phase B WS-5)	2026-06-14 03:48:41 -04:00
Joseph Doherty	4c56a1719b	feat(alarms): DriverHostActor routes native alarm transitions to Part 9 conditions (Phase B WS-4c)	2026-06-14 03:34:25 -04:00
Joseph Doherty	25c3bd16ba	feat(alarms): DriverInstanceActor forwards native OnAlarmEvent to parent (Phase B WS-4b)	2026-06-14 03:24:24 -04:00
Joseph Doherty	c1aeafaaf3	feat(alarms): NativeAlarmProjector maps transitions to condition snapshots (Phase B WS-4a)	2026-06-14 03:16:44 -04:00
Joseph Doherty	e1ccd99ea2	feat(alarms): EquipmentTagPlan.Alarm parsed byte-parity from TagConfig (Phase B WS-2)	2026-06-14 03:12:48 -04:00
Joseph Doherty	590e497872	fix(runtime): narrow ActorNodeWriteGateway catch + drop vacuous no-actor assertion	2026-06-14 01:32:34 -04:00
Joseph Doherty	526ddb6a57	feat(runtime): ActorNodeWriteGateway — Asks RouteNodeWrite, returns NodeWriteOutcome	2026-06-14 01:23:43 -04:00
Joseph Doherty	97d82dda46	test(runtime): future-enum trap for AccessLevel->Writable parity	2026-06-14 00:45:00 -04:00
Joseph Doherty	7e405e949b	fix(runtime): swallow self SubscriptionFailed too (symmetric to SubscriptionEstablished)	2026-06-14 00:42:31 -04:00
Joseph Doherty	42b4a923fd	fix(runtime): fast-fail writes in degraded driver states + swallow self SubscriptionEstablished	2026-06-14 00:34:37 -04:00
Joseph Doherty	99eea0b455	test(runtime): raw-blob routing test uses a no-FullName protocol blob (genuine #4d case)	2026-06-14 00:26:10 -04:00
Joseph Doherty	4cda275b8d	fix(runtime): fast-fail RouteNodeWrite while Stale + micro-opts + raw-blob routing test	2026-06-14 00:16:47 -04:00
Joseph Doherty	a23fb2b82e	feat(server): equipment-tag node writability from Tag.AccessLevel (parity-safe, no migration)	2026-06-13 11:46:00 -04:00
Joseph Doherty	f8f1027287	feat(runtime): NodeId->driver reverse routing + primary-gated RouteNodeWrite	2026-06-13 11:44:26 -04:00
Joseph Doherty	c4435e4fd6	feat(runtime): route driver values to folder-scoped equipment NodeIds (live-value delivery)	2026-06-13 06:32:38 -04:00
Joseph Doherty	dcbaf63ab1	feat(config): remove the SystemPlatform NamespaceKind (capstone) — Galaxy is Equipment-kind	2026-06-12 22:18:56 -04:00
Joseph Doherty	056bfbda1b	test(opcua): composer↔artifact byte-parity for a Galaxy equipment tag	2026-06-12 22:05:15 -04:00
Joseph Doherty	95be607a07	feat(opcua): remove SystemPlatform-mirror GalaxyTags contract end-to-end (composer+applier+artifact, byte-parity)	2026-06-12 21:45:19 -04:00
Joseph Doherty	bc9e83ed9f	feat(composer): admit GalaxyMxGateway-backed equipment alias tags (+byte-parity)	2026-06-11 21:10:21 -04:00
Joseph Doherty	a8640a9331	test(scripted-alarms): cover bootstrap-restore path forwarding alarms (T10 review)	2026-06-10 15:24:39 -04:00
Joseph Doherty	5256761368	feat(scripted-alarms): spawn + apply ScriptedAlarmHostActor in DriverHostActor (T10)	2026-06-10 15:17:29 -04:00
Joseph Doherty	8e8ca9efe8	feat(scripted-alarms): DeploymentArtifact byte-parity for the alarm plan (T6)	2026-06-10 14:41:46 -04:00
Joseph Doherty	66ea9c56f6	feat(runtime): DeploymentArtifact substitutes {{equip}} (parity with composer)	2026-06-10 07:53:20 -04:00
Joseph Doherty	d909a8e4f6	docs+test(deploy): clarify driver-less attribution docs + no-line exclusion test (Task 2 review)	2026-06-08 07:02:25 -04:00
Joseph Doherty	c688899134	fix(deploy): cluster-attribute driver-less equipment via its UNS line area (BuildClusterSets)	2026-06-08 06:53:41 -04:00
Joseph Doherty	6b36eff2d3	refactor(runtime): capture-first in HandleWriteAsync; assert no handler leak on resubscribe; fix stale comment	2026-06-07 10:31:20 -04:00
Joseph Doherty	98259ab026	fix(runtime): capture Sender before await in DriverInstanceActor subscribe (no-ActorContext race)	2026-06-07 10:26:17 -04:00
Joseph Doherty	4c221ce2b3	merge: equipment-namespace live values (VirtualTag route)	2026-06-07 09:33:21 -04:00
Joseph Doherty	1c579410cd	fix(runtime): flag cross-cluster orphan-equipment bindings on rebuild ... ParseComposition(blob, nodeId, onInconsistency?) detects a kept equipment whose UNS line belongs to another cluster (a same-cluster-invariant violation that would orphan the equipment folder) and reports it via an optional callback, wired to OpcUaPublishActor's logger. Detection-only; the upstream draft validator remains the authority. Adds two unit tests.	2026-06-07 08:24:11 -04:00
Joseph Doherty	397f9b783a	feat(runtime): spawn+apply VirtualTagHostActor on deploy apply and restore	2026-06-07 05:41:04 -04:00
Joseph Doherty	c7661d0510	feat(opcua): parse Equipment VirtualTag plans from the deployment artifact	2026-06-07 05:09:53 -04:00
Joseph Doherty	1b7f995aea	feat(runtime): DriverHost spawns + subscribes only its own ClusterId's drivers	2026-06-07 03:19:22 -04:00
Joseph Doherty	4fca4e1aca	feat(runtime): node-scoped ParseComposition filters address space by ClusterId	2026-06-07 03:15:46 -04:00