fix(focas): browse-committed fixed-tree tags are readable (Gitea #540)

Authoring FOCAS tags through /raw -> Browse device... produced tags the driver could never read. Every committed tag read BadNodeIdUnknown forever, and the failure was silent end to end: the AdminUI accepted it, the deploy gate sealed green, and the driver reported Healthy with 0 errors while ignoring the tags. Net effect: the whole fixed-tree surface could not be published through any v3 authoring path. Found cutting wonder-app-vd03 over to v3 against a real Makino Pro 5 / Fanuc 30i, where 0 of 20 committed tags read while two hand-authored MACRO: tags on the same device read Good. A captured browse leaf's id IS its DriverAttributeInfo.FullName, and the fixed tree emitted "{deviceHost}/{path}" there -- an internal cache key, not an address. Both authoring paths wrote it verbatim into TagConfig.address, and FocasAddress.TryParse accepts no such form, so the driver skipped the tags at init. Fixed at the emitter rather than by stripping the host at commit, which fixes the browse-commit flow and the manual picker's tree-select together and leaves one canonical address form: - FocasAddress gains a fourth kind, FIXED:<path>, and moves to Contracts so the AdminUI and ControlPlane can parse without referencing the runtime driver (#526). A FIXED: read is served from the fixed-tree snapshot the poll loop already maintains -- no area read, no connection. Writes refuse: nothing in that tree is a writable location on the CNC. - The address carries no device. A tag's device comes from its Device row, and a second routing channel for one fact is what created this defect. - An authored FIXED: tag arms the fixed-tree poll loop by itself. Enabled defaults false and the browser force-enables it only for a browse, so the operator would otherwise browse, commit, deploy, and land on a driver whose loop never starts -- every tag Bad with a correct address. - Fixed-tree values are now dated from the last answered poll and go BadCommunicationError once it is stale (8 cadences, floored at 30s). The poll loop swallows a failed tick by design, so a dead CNC would otherwise serve its last snapshot as Good indefinitely -- harmless while nothing could bind to the tree, not harmless now. Guardrails, so this class cannot recur silently: - FocasTagConfigModel.Validate() runs the real parser instead of a non-empty check, and FocasTagDefinitionFactory.Inspect() warns at the deploy gate, which covers CSV/API config that never touches the modal. - The manual picker offered axis/spindle/program/status "parameter groups" -- none of which is a FOCAS addressing space -- and its own default value, axis:5, was unusable. It now composes PMC / PARAM: / MACRO: through FocasAddress, so what it emits is parseable by construction. Tests assert addresses ROUND-TRIP through the parser rather than matching an expected string: the previous FocasAddressBuilderTests pinned "axis:5" exactly, which is how a green suite coexisted with a picker nobody could use. Verified red-first against the old emitter. FOCAS 308, AdminUI 1095, ControlPlane 169, Core 581 -- all pass, 0 warnings. The remaining half of #540 -- a driver reporting Healthy/0 errors while skipping tags at init -- is fleet-wide (eight drivers do this) and is filed separately rather than patched per-driver.
2026-08-05 17:32:18 -04:00
parent 4e4619514c
commit b61fe38823
14 changed files with 1147 additions and 251 deletions
@@ -47,6 +47,32 @@ public sealed class FocasTagConfigModel

    /// <summary>Validation hook; returns an error message or null when the model is valid.</summary>
    /// <returns>An error message describing the validation failure, or null when the model is valid.</returns>
+    /// <remarks>
+    ///     <b>This runs the driver's real parser, not a non-empty check</b> (Gitea #540). It used to
+    ///     accept any non-blank string, which is how 20 tags carrying a browse full reference
+    ///     (<c>10.201.31.5:8193/Identity/SeriesNumber</c>) were authored, deployed and sealed green —
+    ///     the driver then skipped every one at init and they read <c>BadNodeIdUnknown</c> forever
+    ///     with no signal anywhere. An address that cannot be parsed cannot be polled, so the
+    ///     rejection belongs here, where the operator is still looking at the field.
+    ///     <para><see cref="FocasAddress"/> lives in the driver's <c>Contracts</c> assembly precisely
+    ///     so this project can call it without referencing the runtime driver (Gitea #526).</para>
+    /// </remarks>
    public string? Validate()
-        => string.IsNullOrWhiteSpace(Address) ? "Address is required." : null;
+    {
+        if (string.IsNullOrWhiteSpace(Address)) return "Address is required.";
+        return FocasAddress.TryParse(Address) is null ? DescribeUnparseableAddress(Address) : null;
+    }
+
+    /// <summary>
+    ///     The operator-facing rejection message for an address the FOCAS parser will not accept,
+    ///     naming the four legal forms. Shared with the deploy-time inspector so the modal and the
+    ///     deploy gate say the same thing about the same string.
+    /// </summary>
+    /// <param name="address">The rejected address.</param>
+    /// <returns>The message.</returns>
+    internal static string DescribeUnparseableAddress(string address) =>
+        $"'{address.Trim()}' is not a FOCAS address. Expected a PMC address (X0.0, R100, F20.3), " +
+        "a CNC parameter (PARAM:1020, PARAM:1815/0), a macro variable (MACRO:500), or a fixed-tree " +
+        "path (FIXED:Identity/SeriesNumber). A browse full reference including the device host is " +
+        "not an address — commit the leaf from the browser rather than pasting its id.";
 }