test: migrate AdminUI/ControlPlane/Runtime/Host tests to xunit.v3 (#756)
v2-ci / unit-tests (push) Failing after 13m22s

Akka.TestKit.Xunit2 -> Akka.TestKit.Xunit 1.5.62 (xunit.v3 TestKit; needs xunit.v3 3.2.2, set via
VersionOverride on the four projects). Removes the xunit 2.9.3 pin. IAsyncLifetime returns ValueTask,
SqlServerFactAttribute gains the source-info ctor, and xUnit1051 call sites pass
TestContext.Current.CancellationToken. Test counts unchanged.

Claude-Session: https://claude.ai/code/session_01GT67AEHd2Acv1YPwGfXEoV
This commit is contained in:
Joseph Doherty
2026-11-10 08:57:33 -05:00
parent 2a8e2981fe
commit b211911f98
191 changed files with 2161 additions and 2166 deletions
@@ -65,9 +65,9 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var sw = Stopwatch.StartNew();
var askBudget = TimeSpan.FromSeconds(8); // the host's Ask
var first = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-1", 1), askBudget);
new DriverInstanceActor.WriteAttribute("tag-1", 1), askBudget, TestContext.Current.CancellationToken);
var second = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-2", 2), askBudget);
new DriverInstanceActor.WriteAttribute("tag-2", 2), askBudget, TestContext.Current.CancellationToken);
var results = await Task.WhenAll(first, second);
sw.Stop();
@@ -85,14 +85,14 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var driver = new SlowWritableDriver { HoldWrites = true };
var (actor, parent) = Connect(driver);
await actor.Ask<DriverInstanceActor.SubscriptionEstablished>(
new DriverInstanceActor.Subscribe(new[] { "tag-a" }, TimeSpan.FromMilliseconds(100)), PresenceBudget);
new DriverInstanceActor.Subscribe(new[] { "tag-a" }, TimeSpan.FromMilliseconds(100)), PresenceBudget, TestContext.Current.CancellationToken);
var pending = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-a", 7), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-a", 7), PresenceBudget, TestContext.Current.CancellationToken);
AwaitWritesEntered(driver, 1);
driver.FireDataChange("tag-a", 3.5);
var published = parent.ExpectMsg<DriverInstanceActor.AttributeValueBatchPublished>(PresenceBudget);
var published = parent.ExpectMsg<DriverInstanceActor.AttributeValueBatchPublished>(PresenceBudget, cancellationToken: TestContext.Current.CancellationToken);
published.Items.Single().Value.ShouldBe(3.5);
pending.IsCompleted.ShouldBeFalse("the write is still held — the data change did not wait behind it");
@@ -114,7 +114,7 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
AwaitWritesEntered(driver, 2);
// Settle: a third write entering the driver would show up here.
await Task.Delay(300);
await Task.Delay(300, TestContext.Current.CancellationToken);
driver.WritesEntered.ShouldBe(2, "the cap let a third write into the driver");
driver.ReleaseWrites();
@@ -140,17 +140,17 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var (actor, _) = Connect(driver, maxWritesInFlight: 4);
var first = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-a", 1), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-a", 1), PresenceBudget, TestContext.Current.CancellationToken);
AwaitWritesEntered(driver, 1);
var second = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-a", 2), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-a", 2), PresenceBudget, TestContext.Current.CancellationToken);
// Positive control: a DIFFERENT tag is not held behind tag-a.
var other = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-b", 9), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-b", 9), PresenceBudget, TestContext.Current.CancellationToken);
AwaitWritesEntered(driver, 2);
driver.EnteredRefs.ShouldBe(new[] { "tag-a", "tag-b" });
await Task.Delay(300);
await Task.Delay(300, TestContext.Current.CancellationToken);
driver.WritesEntered.ShouldBe(2, "the second tag-a write entered the driver while the first was still inside it");
second.IsCompleted.ShouldBeFalse();
@@ -170,12 +170,12 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var (actor, _) = Connect(driver, maxWritesInFlight: 1, queuedWriteBudget: TimeSpan.FromMilliseconds(300));
var inFlight = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-0", 0), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-0", 0), PresenceBudget, TestContext.Current.CancellationToken);
AwaitWritesEntered(driver, 1);
var stale = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-1", 1), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-1", 1), PresenceBudget, TestContext.Current.CancellationToken);
await Task.Delay(600);
await Task.Delay(600, TestContext.Current.CancellationToken);
driver.ReleaseWrites();
(await inFlight).Success.ShouldBeTrue();
@@ -202,7 +202,7 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var (actor, _) = Connect(driver, maxWritesInFlight: 1, writeTimeout: TimeSpan.FromMilliseconds(300));
var hung = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-a", 1), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-a", 1), PresenceBudget, TestContext.Current.CancellationToken);
AwaitWritesEntered(driver, 1);
var hungResult = await hung;
@@ -214,7 +214,7 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
// The tag (and the single slot) are free again: a later tag-a write reaches the device even though the
// abandoned one is still inside it.
var later = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-a", 2), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-a", 2), PresenceBudget, TestContext.Current.CancellationToken);
AwaitWritesEntered(driver, 2);
driver.EnteredRefs.ShouldBe(new[] { "tag-a", "tag-a" });
var laterResult = await later;
@@ -237,12 +237,12 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var (actor, _) = Connect(driver, writeTimeout: TimeSpan.FromSeconds(10), writeClock: clock);
var write = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-a", 1), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-a", 1), PresenceBudget, TestContext.Current.CancellationToken);
AwaitWritesEntered(driver, 1);
AwaitWriteBoundsArmed(clock);
clock.Advance(TimeSpan.FromSeconds(6));
await Task.Delay(100);
await Task.Delay(100, TestContext.Current.CancellationToken);
write.IsCompleted.ShouldBeFalse("the write was cut off before its configured 10 s bound");
driver.ReleaseWrites();
@@ -263,7 +263,7 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var (actor, _) = Connect(driver, writeTimeout: TimeSpan.FromSeconds(10), writeClock: clock);
var write = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-a", 1), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-a", 1), PresenceBudget, TestContext.Current.CancellationToken);
AwaitWritesEntered(driver, 1);
AwaitWriteBoundsArmed(clock);
@@ -286,12 +286,12 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var (actor, _) = Connect(driver, writeTimeout: TimeSpan.FromSeconds(10), writeClock: clock);
var write = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-a", 1), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-a", 1), PresenceBudget, TestContext.Current.CancellationToken);
AwaitWritesEntered(driver, 1);
AwaitWriteBoundsArmed(clock);
clock.Advance(TimeSpan.FromSeconds(10));
await Task.Delay(100);
await Task.Delay(100, TestContext.Current.CancellationToken);
write.IsCompleted.ShouldBeFalse("abandoned at the cancel instant — no grace for the driver to answer");
clock.Advance(DriverInstanceActor.WriteAbandonGrace(TimeSpan.FromSeconds(10)));
@@ -325,7 +325,7 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var issuedAt = clock.GetTimestamp();
clock.Advance(bounds.QueueBudget + TimeSpan.FromMilliseconds(1));
var result = await actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-a", 1, issuedAt), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-a", 1, issuedAt), PresenceBudget, TestContext.Current.CancellationToken);
result.Success.ShouldBeFalse();
result.Reason!.ShouldContain("800A0000", customMessage: "BadTimeout");
@@ -344,7 +344,7 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var issuedAt = clock.GetTimestamp();
clock.Advance(bounds.QueueBudget);
var result = await actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-a", 1, issuedAt), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-a", 1, issuedAt), PresenceBudget, TestContext.Current.CancellationToken);
result.Success.ShouldBeTrue(result.Reason);
driver.Writes.Select(w => w.FullReference).ShouldBe(new[] { "tag-a" });
@@ -357,13 +357,13 @@ public sealed class DriverInstanceActorConcurrentWriteTests : RuntimeActorTestBa
var (actor, parent) = Connect(driver, maxWritesInFlight: 1);
var inFlight = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-0", 0), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-0", 0), PresenceBudget, TestContext.Current.CancellationToken);
AwaitWritesEntered(driver, 1);
var queued = actor.Ask<DriverInstanceActor.WriteAttributeResult>(
new DriverInstanceActor.WriteAttribute("tag-1", 1), PresenceBudget);
new DriverInstanceActor.WriteAttribute("tag-1", 1), PresenceBudget, TestContext.Current.CancellationToken);
actor.Tell(new DriverInstanceActor.ForceReconnect());
parent.ExpectMsg<DriverInstanceActor.ConnectivityChanged>(m => !m.Connected, PresenceBudget);
parent.ExpectMsg<DriverInstanceActor.ConnectivityChanged>(m => !m.Connected, PresenceBudget, cancellationToken: TestContext.Current.CancellationToken);
var queuedResult = await queued;
queuedResult.Success.ShouldBeFalse();