fix(drivers): #630 review - AbCip disposes alarm projection + clears tag tables, join not abortable by init token; S7 swaps Plc under _gate; doc rationale

Claude-Session: https://claude.ai/code/session_01Ef2ozxS7QPanGT8uoATbTe
2026-10-08 14:39:05 -04:00
parent 461133235a
commit 18a20981a5
6 changed files with 56 additions and 10 deletions
@@ -229,6 +229,33 @@ public sealed class AbCipAlarmProjectionTests
    }

    /// <summary>Waits for <paramref name="more"/> further reads of the fake runtime (a processed-count wait).</summary>
+    /// <summary>
+    ///     #630 — a re-Initialize on a live driver must dispose the alarm projection's poll loop rather
+    ///     than leave it running (it would keep raising duplicate alarm events through this driver).
+    /// </summary>
+    [Fact]
+    public async Task Reinitialize_Stops_The_Previous_Projection_Poll_Loop()
+    {
+        var factory = new FakeAbCipTagFactory();
+        var drv = new AbCipDriver(Options(enabled: true), "drv-1", factory);
+        await drv.InitializeAsync("{}", CancellationToken.None);
+        await drv.SubscribeAlarmsAsync(["HighTemp"], CancellationToken.None);
+
+        await WaitForTagCreation(factory, "HighTemp");
+        var tag = factory.Tags["HighTemp"];
+        // Positive control: the loop is demonstrably polling before the re-init.
+        await WaitForMoreReadsAsync(factory, "HighTemp", 3);
+
+        await drv.InitializeAsync("{}", CancellationToken.None);
+
+        int Reads() => factory.Tags.Values.Sum(t => t.ReadCount); // the loop may re-create its runtime on the new device state
+        var frozen = Reads();
+        await Task.Delay(300); // ~15 poll intervals; a live loop would advance the count
+        Reads().ShouldBe(frozen);
+
+        await drv.ShutdownAsync(CancellationToken.None);
+    }
+
    private static async Task WaitForMoreReadsAsync(FakeAbCipTagFactory factory, string tagName, int more)
    {
        var tag = factory.Tags[tagName];