dohertj2/jdescopingtool
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address code review issues in converter tool

Browse Source
This commit is contained in:
Joseph Doherty
2026-01-06 14:24:23 -05:00
parent edd07858a1
commit 8b1dfeb6c6
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Tools/CacheConverter/Program.cs
+13 -3
View File
@@ -74,7 +74,14 @@ foreach (var jsonFile in jsonFiles)
}
Console.WriteLine();
Console.WriteLine($"Total: {totalOriginalSize:N0} -> {totalNewSize:N0} bytes ({(double)totalNewSize / totalOriginalSize * 100:F1}%)");
if (totalOriginalSize > 0)
{
Console.WriteLine($"Total: {totalOriginalSize:N0} -> {totalNewSize:N0} bytes ({(double)totalNewSize / totalOriginalSize * 100:F1}%)");
}
else
{
Console.WriteLine("No files were converted.");
}
return 0;
static DataTable CreateDataTable(List<Dictionary<string, JsonElement>> records)
@@ -112,6 +119,7 @@ static DataTable CreateDataTable(List<Dictionary<string, JsonElement>> records)
static Type InferType(JsonElement element) => element.ValueKind switch
{
JsonValueKind.String when element.GetString() is string s && DateTime.TryParse(s, out _) => typeof(DateTime),
JsonValueKind.String => typeof(string),
JsonValueKind.Number when element.TryGetInt64(out _) => typeof(long),
JsonValueKind.Number => typeof(decimal),
@@ -126,12 +134,14 @@ static object ConvertValue(JsonElement element, Type targetType)
return DBNull.Value;
if (targetType == typeof(string))
return (object?)element.GetString() ?? DBNull.Value;
if (targetType == typeof(DateTime))
{
var str = element.GetString();
// Try to parse as DateTime if it looks like one
if (str != null && DateTime.TryParse(str, out var dt))
return dt;
return (object?)str ?? DBNull.Value;
return DBNull.Value;
}
if (targetType == typeof(long))