Files
ScadaBridge/tests/ZB.MOM.WW.ScadaBridge.AuditLog.Tests/Central/RetiredAuditSettingsWarningTests.cs
T
Joseph Doherty ed2ed0a367 feat(audit)!: remove the AuditLog hash chain, head export and two-login maintenance hardening
Owner decision 2026-11-15, at IT security's request, pending a family-wide general solution.

Removed: the chaining service, hasher, verifier, chain head/tombstone entities and store, the #139
chain-start cutoff, AuditLog:HashChain (incl. ChainBacklog and HeadExport with its File/Syslog sinks
and export service), the audit-chain-head-export health check, the VerifyAuditChain /
VerifyAuditChainHeads management commands and the `audit verify-chain` / `audit verify-heads` CLI
commands, and the two-login plumbing (AuditLog:MaintenanceConnectionString, AuditMaintenanceContext,
the keyed audit-maintenance repository/archive). Purge, archive, retention, partition roll-forward
and backfill-source-node all run on the runtime connection again, as before #107.

Parquet archive (#42) kept, chain-free: format v2 (ten stored columns, no tombstone file, manifest
without chain state), the switch guard is the row count only (51003 gone), verify = data-file size,
SHA-256 and row count, and superseded-stale cleanup proves coverage by EventId. Format-v1 archives
still list, verify and are cleaned up (their tombstone file too).

Migration RemoveAuditLogHashChain drops the chain indexes, the scadabridge_audit_chainer role
(members first), both chain tables, ChainSeq/RowHash and the purger's AuditMaintenanceGrants grants;
writer/purger roles stay. Down restores them. Every chain-column reference is EXEC-deferred for the
idempotent script (#126); FlipAuditLogClusteredKey's two chain index statements get the same
deferral, behaviour unchanged, so re-running the idempotent script on a migrated database works.
The partition-switch staging table adds the chain columns only when the live table has them, so the
new binary purges either schema. Deploy gate: old binaries map the chain columns, so the migration
ships with the new binaries, both centrals stopped.

A leftover AuditLog:HashChain section or MaintenanceConnectionString (DEV/QA still carry
AuditLog__HashChain__Enabled=true) is ignored with one startup warning (RetiredAuditSettingsWarning).

Claude-Session: https://claude.ai/code/session_01GT67AFKC45MBz1wPZnVbX8
2026-11-15 17:38:22 -05:00

43 lines
1.7 KiB
C#

using Microsoft.Extensions.Configuration;
using ZB.MOM.WW.ScadaBridge.AuditLog.Central;
namespace ZB.MOM.WW.ScadaBridge.AuditLog.Tests.Central;
/// <summary>
/// The hash chain and the maintenance login were removed on 2026-11-15; a node still carrying
/// their settings (DEV/QA have <c>AuditLog__HashChain__Enabled=true</c> in the Central service
/// env) must boot and be told the keys are ignored.
/// </summary>
public class RetiredAuditSettingsWarningTests
{
private static IConfiguration Config(params (string Key, string Value)[] values) =>
new ConfigurationBuilder()
.AddInMemoryCollection(values.Select(v => new KeyValuePair<string, string?>(v.Key, v.Value)))
.Build();
/// <summary>The env var left on DEV/QA (and the maintenance login) are both reported.</summary>
[Fact]
public void FindRetired_ReportsTheHashChainSection_AndTheMaintenanceConnectionString()
{
var config = Config(
("AuditLog:HashChain:Enabled", "true"),
("AuditLog:MaintenanceConnectionString", "Server=x;Database=y"));
Assert.Equal(
[RetiredAuditSettingsWarning.HashChainSection, RetiredAuditSettingsWarning.MaintenanceConnectionStringKey],
RetiredAuditSettingsWarning.FindRetired(config));
}
/// <summary>A clean configuration (and the archive settings that remain) reports nothing.</summary>
[Fact]
public void FindRetired_ReportsNothing_ForCurrentSettings()
{
var config = Config(
("AuditLog:Archive:Enabled", "true"),
("AuditLog:RetentionDays", "365"),
("AuditLog:MaintenanceConnectionString", " "));
Assert.Empty(RetiredAuditSettingsWarning.FindRetired(config));
}
}