Joseph Doherty
a506b19d17
TemplateEdit was the last page still hand-rolling its own modal chrome after
M10 — T34c only tokenized its backdrops. All four member-authoring forms
(Attribute, Alarm, Native Alarm Source, Script) now open through
IDialogService.ShowAsync, so the single DialogHost in MainLayout owns the
backdrop, focus trap, Escape and focus restoration.
Pattern copied from the already-migrated pages (MoveDataConnectionDialog +
Templates' Move/Rename dialogs): each body is its own component beside the page
taking a DialogContext<bool>, owning its form state, rendering validation and
server errors INLINE while staying open, and closing with Close(true) only once
the save succeeded — at which point the page reloads. An inline RenderFragment
would NOT have worked: DialogHost renders the captured fragment in its own tree,
so the page's StateHasChanged could never refresh it.
Persistence deliberately stayed on the page (it owns TemplateService, the
inherited-member rules, and the repository-direct native-source path) and is
reached through an OnSaveAsync delegate returning null on success or the message
to display. Behaviour preserved verbatim, including the List-attribute encode +
Decode round-trip check, the name/trigger-type read-only-on-edit rules, the
duplicate-native-source-name guard, and NormalizeExecutionTimeout.
TemplateScriptDialog keeps all four tab panels mounted (Monaco and the JSONJoy
island must not tear down on tab switch) and hosts the Test Run panel, which
needs the live unsaved editor buffer, so it injects ScriptAnalysisService
directly and cancels an in-flight run on dispose.
Extraction moved markup that three structural source-scanning tests pinned;
all three were repointed at the new files rather than weakened:
- TemplateNativeAlarmSourceEditorTests (+ a new test asserting the form is
host-mounted and the body renders no chrome of its own)
- AttributeListEditorTests (list-editor reveal now in the dialog body)
- TestRunWarningTests (Real I/O warning travelled with the script panel)
Build 0/0; CentralUI.Tests 973/973 green.
62 lines
2.6 KiB
C#
62 lines
2.6 KiB
C#
namespace ZB.MOM.WW.ScadaBridge.CentralUI.Tests.Design;
|
|
|
|
/// <summary>
|
|
/// Regression tests for CentralUI-014. Test Run wires <c>External</c>,
|
|
/// <c>Database</c>, and <c>Notify</c> to central's real services, so a Test Run
|
|
/// has production-equivalent side effects. The finding asked, at minimum, that
|
|
/// this blast radius be surfaced to the user. The Test Run panels in
|
|
/// <c>SharedScriptForm</c> and <c>TemplateEdit</c> carry a prominent
|
|
/// <c>Real I/O</c> badge and an <c>alert-warning</c> block stating the side
|
|
/// effects are real and permanent; <c>ApiMethodForm</c> (Inbound API kind) has
|
|
/// no real-I/O surface at all and correctly omits the badge. These tests pin
|
|
/// that warning so it cannot silently regress.
|
|
/// </summary>
|
|
public class TestRunWarningTests
|
|
{
|
|
private static string SrcRoot
|
|
{
|
|
get
|
|
{
|
|
// tests/ZB.MOM.WW.ScadaBridge.CentralUI.Tests/bin/Debug/net10.0 → repo root.
|
|
var dir = AppContext.BaseDirectory;
|
|
for (var i = 0; i < 6 && dir is not null; i++)
|
|
dir = Directory.GetParent(dir)?.FullName;
|
|
return Path.Combine(dir!, "src", "ZB.MOM.WW.ScadaBridge.CentralUI",
|
|
"Components", "Pages", "Design");
|
|
}
|
|
}
|
|
|
|
private static string Read(string fileName)
|
|
=> File.ReadAllText(Path.Combine(SrcRoot, fileName));
|
|
|
|
// M10 residual: the template Test Run panel moved out of TemplateEdit.razor
|
|
// into TemplateScriptDialog.razor when the page-embedded script modal was
|
|
// migrated to the IDialogService host. The warning travelled with it.
|
|
[Theory]
|
|
[InlineData("SharedScriptForm.razor")]
|
|
[InlineData("TemplateScriptDialog.razor")]
|
|
public void TestRunPanel_WithRealIoSurface_ShowsRealIoBadgeAndWarning(string razorFile)
|
|
{
|
|
var markup = Read(razorFile);
|
|
|
|
// The "Real I/O" badge on the Test Run panel header.
|
|
Assert.Contains("Real I/O", markup);
|
|
// The explicit warning that side effects hit real systems and are permanent.
|
|
Assert.Contains("alert-warning", markup);
|
|
Assert.Contains("fire for real", markup);
|
|
Assert.Contains("Side effects are permanent", markup);
|
|
}
|
|
|
|
[Fact]
|
|
public void ApiMethodForm_TestRun_HasNoRealIoBadge_BecauseInboundApiHasNoSideEffectSurface()
|
|
{
|
|
// The Inbound API sandbox host exposes only Parameters / Route (Route
|
|
// throws) — there is no External/Database/Notify, so no "Real I/O".
|
|
var markup = Read("ApiMethodForm.razor");
|
|
|
|
Assert.DoesNotContain("Real I/O", markup);
|
|
// It still warns that Route calls throw.
|
|
Assert.Contains("alert-warning", markup);
|
|
}
|
|
}
|