Joseph Doherty
63c16d6912
Phase 4 of the ClusterClient -> gRPC migration deleted the Akka transports but left the naming behind: `ClusterClientSiteAuditClient` was transport- agnostic and worked unchanged, so it survived the deletion under a name that now describes a transport the repo no longer has. Same for a scatter of doc-comments still framing gRPC as "the new transport" beside an Akka one that is gone. Renames it to `SiteCommunicationAuditClient` (and its test file) and rewrites the stale comments to describe the single transport that exists. Also tightens CLAUDE.md: drops the self-describing directory listing and the 27-component enumeration in favour of the non-obvious parts only. Behaviour-neutral: names and prose only. Recorded as the Phase 4 follow-up in docs/plans/2026-07-22-clusterclient-to-grpc-plan.md.
80 lines
3.5 KiB
C#
80 lines
3.5 KiB
C#
using Akka.Actor;
|
|
using Akka.TestKit.Xunit2;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using Microsoft.Extensions.Options;
|
|
using NSubstitute;
|
|
using ZB.MOM.WW.ScadaBridge.Commons.Entities.Deployment;
|
|
using ZB.MOM.WW.ScadaBridge.Commons.Entities.Sites;
|
|
using ZB.MOM.WW.ScadaBridge.Commons.Interfaces.Repositories;
|
|
using ZB.MOM.WW.ScadaBridge.Commons.Messages.Deployment;
|
|
using ZB.MOM.WW.ScadaBridge.Commons.Types.Deployment;
|
|
using ZB.MOM.WW.ScadaBridge.Communication.Actors;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.Communication.Tests;
|
|
|
|
/// <summary>
|
|
/// Tests that <see cref="CentralCommunicationActor"/> routes a site→central
|
|
/// <see cref="ReconcileSiteRequest"/> through the scoped <see cref="ReconcileService"/>
|
|
/// and pipes the resulting <see cref="ReconcileSiteResponse"/> back to the original
|
|
/// sender (the site's transport path). Mirrors the audit-ingest routing tests.
|
|
/// </summary>
|
|
public class CentralCommunicationActorReconcileTests : TestKit
|
|
{
|
|
[Fact]
|
|
public void ReconcileSiteRequest_RoutesResponseToSender()
|
|
{
|
|
var deploymentRepo = Substitute.For<IDeploymentManagerRepository>();
|
|
var siteRepo = Substitute.For<ISiteRepository>();
|
|
|
|
// GetAllSitesAsync is called by the actor's periodic refresh; keep it empty.
|
|
siteRepo.GetAllSitesAsync(Arg.Any<CancellationToken>())
|
|
.Returns(new List<Site>());
|
|
|
|
siteRepo.GetSiteByIdentifierAsync("site1", Arg.Any<CancellationToken>())
|
|
.Returns(new Site("Site One", "site1") { Id = 7 });
|
|
|
|
deploymentRepo.GetExpectedDeploymentsForSiteAsync(7, Arg.Any<CancellationToken>())
|
|
.Returns(new List<ExpectedDeployment>
|
|
{
|
|
new(2, "inst-B", "rev2", "dep-B", true),
|
|
});
|
|
deploymentRepo.GetDeployedSnapshotByInstanceIdAsync(2, Arg.Any<CancellationToken>())
|
|
.Returns(new DeployedConfigSnapshot("dep-B", "rev2", "{\"cfg\":\"B\"}"));
|
|
deploymentRepo.StagePendingIfAbsentAsync(
|
|
Arg.Any<int>(), Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>(),
|
|
Arg.Any<string>(), Arg.Any<DateTimeOffset>(), Arg.Any<DateTimeOffset>(),
|
|
Arg.Any<CancellationToken>())
|
|
.Returns(true);
|
|
|
|
var options = Options.Create(new CommunicationOptions
|
|
{
|
|
CentralFetchBaseUrl = "https://central.example:9000",
|
|
PendingDeploymentTtl = TimeSpan.FromMinutes(5),
|
|
});
|
|
|
|
var services = new ServiceCollection();
|
|
services.AddScoped(_ => deploymentRepo);
|
|
services.AddScoped(_ => siteRepo);
|
|
services.AddSingleton(options);
|
|
services.AddSingleton<Microsoft.Extensions.Logging.ILogger<ReconcileService>>(
|
|
NullLogger<ReconcileService>.Instance);
|
|
services.AddScoped<ReconcileService>();
|
|
var sp = services.BuildServiceProvider();
|
|
|
|
var transport = Substitute.For<ISiteCommandTransport>();
|
|
var actor = Sys.ActorOf(Props.Create(() => new CentralCommunicationActor(sp, transport, (TimeSpan?)null)));
|
|
|
|
// Node B is missing inst-B entirely → it should come back as a gap item.
|
|
actor.Tell(new ReconcileSiteRequest(
|
|
"site1", "node-b",
|
|
new Dictionary<string, string>()));
|
|
|
|
var response = ExpectMsg<ReconcileSiteResponse>(TimeSpan.FromSeconds(5));
|
|
var gap = Assert.Single(response.Gap);
|
|
Assert.Equal("inst-B", gap.InstanceUniqueName);
|
|
Assert.Equal("dep-B", gap.DeploymentId);
|
|
Assert.False(string.IsNullOrWhiteSpace(gap.FetchToken));
|
|
}
|
|
}
|