Joseph Doherty
513fa1aa16
Comment/XML-doc changes only: - add summaries to ~10k test methods, fixtures, fakes and helpers (+ <param> on theories, <returns> on async Task methods, <inheritdoc/> on interface implementations the checker can resolve) - strip ~2.6k project-tracking references (WP*, P*-*, row-NN, Task N, #NN, Component-0NN) from comments, keeping the explanatory text; reword false positives in comments only - real docs on fakes implementing BCL/library interfaces (IDisposable, ILogger, IOptionsMonitor, IAsyncLifetime) - reword the last 5 src/ false positives (CWE-1236, failures-1, year-0001, M365) Only non-comment edits: four one-line nested classes split across lines so members can carry docs. Build 0 errors / 0 warnings.
60 lines
2.5 KiB
C#
60 lines
2.5 KiB
C#
using Microsoft.Extensions.DependencyInjection;
|
|
using Microsoft.Extensions.Options;
|
|
|
|
namespace ZB.MOM.WW.ScadaBridge.ClusterInfrastructure.Tests;
|
|
|
|
/// <summary>
|
|
/// Tests that <see cref="ServiceCollectionExtensions.AddClusterInfrastructure"/>
|
|
/// does real work rather than silently returning success — it must register
|
|
/// the <see cref="ClusterOptionsValidator"/> so misconfiguration fails fast.
|
|
/// (The companion actor-registration test was removed alongside the deleted
|
|
/// `AddClusterInfrastructureActors` extension method.)
|
|
/// </summary>
|
|
public class ServiceCollectionExtensionsTests
|
|
{
|
|
/// <summary>Verifies the case: add Cluster Infrastructure, registers Options Validator.</summary>
|
|
[Fact]
|
|
public void AddClusterInfrastructure_RegistersOptionsValidator()
|
|
{
|
|
var services = new ServiceCollection();
|
|
|
|
services.AddClusterInfrastructure();
|
|
|
|
var validators = services
|
|
.Where(d => d.ServiceType == typeof(IValidateOptions<ClusterOptions>))
|
|
.ToList();
|
|
Assert.NotEmpty(validators);
|
|
|
|
using var provider = services.BuildServiceProvider();
|
|
var validator = provider.GetService<IValidateOptions<ClusterOptions>>();
|
|
Assert.IsType<ClusterOptionsValidator>(validator);
|
|
}
|
|
|
|
/// <summary>Verifies the case: add Cluster Infrastructure, validator Rejects Bad Options At Resolution.</summary>
|
|
[Fact]
|
|
public void AddClusterInfrastructure_ValidatorRejectsBadOptionsAtResolution()
|
|
{
|
|
var services = new ServiceCollection();
|
|
services.AddClusterInfrastructure();
|
|
// A MinNrOfMembers of 2 blocks the cluster singleton after failover.
|
|
services.Configure<ClusterOptions>(o =>
|
|
{
|
|
o.SeedNodes = new List<string> { "akka.tcp://scadabridge@node1:8081" };
|
|
o.MinNrOfMembers = 2;
|
|
});
|
|
|
|
using var provider = services.BuildServiceProvider();
|
|
|
|
var ex = Assert.Throws<OptionsValidationException>(
|
|
() => provider.GetRequiredService<IOptions<ClusterOptions>>().Value);
|
|
Assert.Contains("MinNrOfMembers", ex.Message);
|
|
}
|
|
|
|
// `AddClusterInfrastructureActors_ThrowsRatherThanSilentlySucceeding`
|
|
// was removed alongside the now-deleted `AddClusterInfrastructureActors`
|
|
// extension method. The Akka.NET actor wiring legitimately lives in
|
|
// `ZB.MOM.WW.ScadaBridge.Host` (AkkaHostedService) per the
|
|
// Component-ClusterInfrastructure.md "Implementation Note — Code Placement"
|
|
// section; this project no longer exposes an actor-registration extension.
|
|
}
|