R2-05: Templates, Deployment & Transport round-2 fixes (9 tasks) #8

2026-07-13T10:11:11-04:00

dohertj2 commented

2026-07-13 10:11:11 -04:00

Round-2 architecture-review fixes — PLAN-R2-05 (Templates, Deployment & Transport), all 9 tasks. Source: archreview/05-templates-deployment-transport.md round-2 findings.

TDD throughout; per-task pathspec commits. Terminal verify green: build 0/0, TemplateEngine.Tests 473, Transport.Tests 154, Transport.IntegrationTests 103, DeploymentManager.Tests 119.

Two internal serial lanes (TemplateEngine T1–T4 on ValidationService/ScriptCompiler; Transport BundleImporter T5–T7):

T1 5573a9ee fix(template-engine): trigger-expression syntax check reports ALL violations/compile errors, not just the first (N2)
T2 06d79f65 fix(template-engine): verdict-cache key gains globals-surface discriminator — cross-surface reuse structurally impossible (N1)
T3 d233ecbe perf(template-engine): cache Expression-trigger compile verdicts under the trigger-surface key
T4 31fa5eaf perf(template-engine): read-only staleness/comparison paths skip Expression-trigger compiles; deploy gate stays authoritative
T5 ab77094a fix(transport): script-artifact change publisher covers Add resolutions (pairs with R2-06 T1 subscriber; closes round-1 U2 partial) (N3)
T6 b02c15bb fix(security): import trust gate covers instance alarm-override trigger expressions — 5th call site surface-complete (N5)
T7 db623c14 fix(transport): warn on locked-member overrides at import (N4)
T8 9b489032 fix(transport): validate MaxConcurrentImportSessions (N6)
T9 3ee98c8a docs sweep

Part of the round-2 initiative (8 plans / 86 tasks).

Round-2 architecture-review fixes — **PLAN-R2-05 (Templates, Deployment & Transport)**, all 9 tasks. Source: `archreview/05-templates-deployment-transport.md` round-2 findings. TDD throughout; per-task pathspec commits. Terminal verify green: build 0/0, TemplateEngine.Tests 473, Transport.Tests 154, Transport.IntegrationTests 103, DeploymentManager.Tests 119. Two internal serial lanes (TemplateEngine T1–T4 on `ValidationService`/`ScriptCompiler`; Transport `BundleImporter` T5–T7): - **T1** `5573a9ee` fix(template-engine): trigger-expression syntax check reports ALL violations/compile errors, not just the first (N2) - **T2** `06d79f65` fix(template-engine): verdict-cache key gains globals-surface discriminator — cross-surface reuse structurally impossible (N1) - **T3** `d233ecbe` perf(template-engine): cache Expression-trigger compile verdicts under the trigger-surface key - **T4** `31fa5eaf` perf(template-engine): read-only staleness/comparison paths skip Expression-trigger compiles; deploy gate stays authoritative - **T5** `ab77094a` fix(transport): script-artifact change publisher covers Add resolutions (pairs with R2-06 T1 subscriber; closes round-1 U2 partial) (N3) - **T6** `b02c15bb` fix(security): import trust gate covers instance alarm-override trigger expressions — 5th call site surface-complete (N5) - **T7** `db623c14` fix(transport): warn on locked-member overrides at import (N4) - **T8** `9b489032` fix(transport): validate `MaxConcurrentImportSessions` (N6) - **T9** `3ee98c8a` docs sweep Part of the round-2 initiative (8 plans / 86 tasks).

dohertj2 added 9 commits 2026-07-13 10:11:12 -04:00

fix(template-engine): trigger-expression syntax check reports ALL violations/compile errors, not just the first (plan R2-05 T1) 5573a9eeb9

fix(template-engine): verdict-cache key gains the globals-surface discriminator — cross-surface verdict reuse structurally impossible (plan R2-05 T2) 06d79f6516

perf(template-engine): cache Expression-trigger compile verdicts under the trigger-surface key — unchanged expressions compile once per process (plan R2-05 T3) d233ecbe8f

perf(template-engine): read-only staleness/comparison paths skip Expression-trigger compiles — deploy gate remains the authoritative check (plan R2-05 T4) 31fa5eafa4

fix(transport): script-artifact change publisher covers Add resolutions — delete-then-reimport no longer starves non-self-healing subscribers (plan R2-05 T5) ab77094a26

fix(security): import trust gate covers instance alarm-override trigger expressions — 5th call site is surface-complete (plan R2-05 T6) b02c15bbca

fix(transport): warn on import of instance overrides targeting locked template members — inert rows no longer silent (plan R2-05 T7) db623c1435

fix(transport): validate MaxConcurrentImportSessions at startup — a zero cap no longer bricks imports silently (plan R2-05 T8) 9b4890326e

docs: sync Transport/ScriptAnalysis/TemplateEngine specs + CLAUDE.md with the round-2 fix wave (plan R2-05 T9) 3ee98c8af6

No ../scadaproj/CLAUDE.md change needed — no wire-relationship/stack/namespace change in this wave.

dohertj2 commented

2026-07-13 11:48:36 -04:00

Merged to main via the r2-integration fast-forward (main @ 1930f19b, pushed to origin). All commits from this branch are in main; the two integration-surfaced test fixes (IntegrationTests NodeName host-boot config, compile-cache assertion relax) landed on main as well. Closing — content fully integrated.

Merged to main via the r2-integration fast-forward (main @ 1930f19b, pushed to origin). All commits from this branch are in main; the two integration-surfaced test fixes (IntegrationTests NodeName host-boot config, compile-cache assertion relax) landed on main as well. Closing — content fully integrated.

dohertj2 closed this pull request

2026-07-13 11:48:36 -04:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/ScadaBridge#8