R2-07: UI, Management & Security round-2 fixes (12 tasks; stacked on r2-plan02) #13

2026-07-13T11:06:36-04:00

dohertj2 commented

2026-07-13 11:06:36 -04:00

Round-2 architecture-review fixes — PLAN-R2-07 (UI, Management & Security), all 12 tasks. Source: archreview/07-ui-management-security.md.

Stacked on r2-plan02 (shares ManagementActor.cs — single-writer lane — and Communication/SiteAlarmLiveCacheService.cs — live-alarm slice; R2-02's edits are in the base, these build on top). Base = r2-plan02; retarget to main after r2-plan02 merges. TDD per task; per-task pathspec commits; full slnx build 0/0.

T1 e1a69201 DebugStreamHub delegates its Basic→LDAP bind to the shared ManagementAuthenticator (N1)
T2 b532a1e3 ForwardedHeadersSetup (N2; .NET 10 KnownIPNetworks)
T3 24c2097e ship trusted-proxy ForwardedHeaders config for Traefik topologies + document lockout-DoS trade-off
T4 9b9222d2 enforce LDAP-mapping site scope on secured-write submit/approve/reject (N3)
T5 92936747 additive permitted-sites query filter (MSSQL, live)
T6 1fcfa4fb scope-filter secured-write listing + spec alignment
T7 d33337a8 stale-site poll guard on AlarmSummary
T8 925c8698 poll defers rows while IsLive
T9 76ef97f7 disposal guard on live callback
T10 5b164296 deathwatch resets IsLive (N6; builds on R2-02's live-alarm coalescing)
T11 1b88ca12 amortize LoginThrottle.Prune
T12 2751a6db freeze ConfigSecretScrubber coverage

On-disk only (gitignored deploy/, not committed): T3 wonder-app-vd03 ForwardedHeaders disabled-block. No EF migration. Part of the round-2 initiative (8 plans / 86 tasks).

Round-2 architecture-review fixes — **PLAN-R2-07 (UI, Management & Security)**, all 12 tasks. Source: `archreview/07-ui-management-security.md`. **Stacked on `r2-plan02`** (shares `ManagementActor.cs` — single-writer lane — and `Communication/SiteAlarmLiveCacheService.cs` — live-alarm slice; R2-02's edits are in the base, these build on top). Base = r2-plan02; retarget to main after r2-plan02 merges. TDD per task; per-task pathspec commits; full slnx build 0/0. - **T1** `e1a69201` DebugStreamHub delegates its Basic→LDAP bind to the shared `ManagementAuthenticator` (N1) - **T2** `b532a1e3` `ForwardedHeadersSetup` (N2; `.NET 10` `KnownIPNetworks`) - **T3** `24c2097e` ship trusted-proxy ForwardedHeaders config for Traefik topologies + document lockout-DoS trade-off - **T4** `9b9222d2` enforce LDAP-mapping site scope on secured-write submit/approve/reject (N3) - **T5** `92936747` additive permitted-sites query filter (MSSQL, live) - **T6** `1fcfa4fb` scope-filter secured-write listing + spec alignment - **T7** `d33337a8` stale-site poll guard on AlarmSummary - **T8** `925c8698` poll defers rows while `IsLive` - **T9** `76ef97f7` disposal guard on live callback - **T10** `5b164296` deathwatch resets `IsLive` (N6; builds on R2-02's live-alarm coalescing) - **T11** `1b88ca12` amortize `LoginThrottle.Prune` - **T12** `2751a6db` freeze `ConfigSecretScrubber` coverage **On-disk only (gitignored `deploy/`, not committed):** T3 wonder-app-vd03 ForwardedHeaders disabled-block. No EF migration. Part of the round-2 initiative (8 plans / 86 tasks).

dohertj2 added 12 commits 2026-07-13 11:06:37 -04:00

fix(security): throttle DebugStreamHub LDAP bind via ManagementAuthenticator + correct coverage doc (plan R2-07 T1) e1a692016e

fix(security): trusted-proxy ForwardedHeaders so LoginThrottle keys on the real client IP (plan R2-07 T2) b532a1e30e

fix(security): ship trusted-proxy ForwardedHeaders config for Traefik topologies + document lockout-DoS trade-off (plan R2-07 T3) 24c2097ec3

fix(security): enforce LDAP-mapping site scope on secured-write submit/approve/reject (plan R2-07 T4) 9b9222d223

fix(security): additive permitted-sites filter on secured-write query/count (plan R2-07 T5) 92936747b7

fix(security): scope-filter secured-write listing + align spec with enforced site scoping (plan R2-07 T6) 1fcfa4fb16

fix(ui): drop stale-site poll results on Alarm Summary site switch (plan R2-07 T7) d33337a834

fix(ui): Alarm Summary poll defers row rebuilds to the live path while IsLive (plan R2-07 T8) 925c869826

fix(ui): disposal guard on Alarm Summary live callback, matching the DebugView pattern (plan R2-07 T9) 76ef97f729

fix(sitestream): deathwatch resets live-cache liveness on aggregator termination (plan R2-07 T10) 5b16429635

fix(security): amortize LoginThrottle.Prune off the failed-bind hot path (plan R2-07 T11) 1b88ca1296

test(management): freeze scrubber fragment coverage over DataConnection config types + document array-merge limit (plan R2-07 T12) 2751a6dba9

dohertj2 commented

2026-07-13 11:48:39 -04:00

Merged to main via the r2-integration fast-forward (main @ 1930f19b, pushed to origin). All commits from this branch are in main; the two integration-surfaced test fixes (IntegrationTests NodeName host-boot config, compile-cache assertion relax) landed on main as well. Closing — content fully integrated.

Merged to main via the r2-integration fast-forward (main @ 1930f19b, pushed to origin). All commits from this branch are in main; the two integration-surfaced test fixes (IntegrationTests NodeName host-boot config, compile-cache assertion relax) landed on main as well. Closing — content fully integrated.

dohertj2 closed this pull request

2026-07-13 11:48:39 -04:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/ScadaBridge#13