R2-04: Data & Audit Backbone + KPI rollups round-2 fixes (12 tasks, 1 EF migration) #10

2026-07-13T10:30:49-04:00

dohertj2 commented

2026-07-13 10:30:49 -04:00

Round-2 architecture-review fixes — PLAN-R2-04 (Data & Audit Backbone + KPI rollups), all 12 tasks incl. the High (R1) rollup-backfill bound. Source: archreview/04-data-audit-backbone.md.

TDD throughout; per-task pathspec commits; build 0/0; targeted + MSSQL suites green (infra up, no SkippableFact skipped).

High R1 spine (T1–T4):

T1 29c12869 untracked projected fold fetch (R2)
T2 a1c7c4ef GetLatestRollupHourAsync watermark seam
T3 350d5301 slice rollup backfill into bounded 24h folds that yield to periodic folds
T4 7b95ef37 backfill skips/shrinks to the rollup watermark on failover restarts

Rate-presentation + purge + hygiene (T5–T12):

T5 54417e1a Rate series sum-per-bucket in the bucketer (R3)
T6 9a1b160e query service applies catalog aggregation — one unit across raw/rollup boundary
T7 1c8b2bc7 trend charts state per-bucket-total semantics (docs)
T8 cd93ad39 promote catalog metric literals to shared constants (R4)
T9 439dee52 classify failover fold-race pass loss as self-healing Information (R5)
T10 3d6973cc filtered IX_SiteCalls_Terminal index — EF migration 20260713142234_AddSiteCallsTerminalIndex + idempotent SQL script (R6)
T11 8f46b6ce time-sliced SiteCalls terminal purge (R6)
T12 c573d8ca retention loop absorbs shutdown cancellation (R7)

Note: contains the round-2 EF migration (the only one). Merge-order this vs main's snapshot; no other round-2 branch touches the ConfigDB model snapshot. Part of the round-2 initiative (8 plans / 86 tasks).

Round-2 architecture-review fixes — **PLAN-R2-04 (Data & Audit Backbone + KPI rollups)**, all 12 tasks incl. the **High (R1)** rollup-backfill bound. Source: `archreview/04-data-audit-backbone.md`. TDD throughout; per-task pathspec commits; build 0/0; targeted + MSSQL suites green (infra up, no SkippableFact skipped). **High R1 spine (T1–T4):** - **T1** `29c12869` untracked projected fold fetch (R2) - **T2** `a1c7c4ef` `GetLatestRollupHourAsync` watermark seam - **T3** `350d5301` slice rollup backfill into bounded 24h folds that yield to periodic folds - **T4** `7b95ef37` backfill skips/shrinks to the rollup watermark on failover restarts **Rate-presentation + purge + hygiene (T5–T12):** - **T5** `54417e1a` Rate series sum-per-bucket in the bucketer (R3) - **T6** `9a1b160e` query service applies catalog aggregation — one unit across raw/rollup boundary - **T7** `1c8b2bc7` trend charts state per-bucket-total semantics (docs) - **T8** `cd93ad39` promote catalog metric literals to shared constants (R4) - **T9** `439dee52` classify failover fold-race pass loss as self-healing Information (R5) - **T10** `3d6973cc` filtered `IX_SiteCalls_Terminal` index — **EF migration** `20260713142234_AddSiteCallsTerminalIndex` + idempotent SQL script (R6) - **T11** `8f46b6ce` time-sliced SiteCalls terminal purge (R6) - **T12** `c573d8ca` retention loop absorbs shutdown cancellation (R7) **Note:** contains the round-2 EF migration (the only one). Merge-order this vs main's snapshot; no other round-2 branch touches the ConfigDB model snapshot. Part of the round-2 initiative (8 plans / 86 tasks).

dohertj2 added 12 commits 2026-07-13 10:30:51 -04:00

fix(kpi): untracked projected fold fetch — fold reads no longer flood the change tracker (plan R2-04 T1) 29c1286943

feat(kpi): GetLatestRollupHourAsync watermark seam for the backfill fast-path (plan R2-04 T2) a1c7c4ef26

fix(kpi): slice the rollup backfill into bounded 24h folds that yield to periodic folds (plan R2-04 T3) 350d530135

fix(kpi): backfill skips or shrinks to the rollup watermark on failover restarts (plan R2-04 T4) 7b95ef3752

fix(kpi): per-metric bucket reduction — Rate series sum per bucket instead of keeping one delta (plan R2-04 T5) 54417e1ae4

fix(kpi): query service applies catalog aggregation at the bucketer — rate charts keep one unit across the raw/rollup boundary (plan R2-04 T6) 9a1b160e79

docs(kpi): trend charts state per-bucket-total semantics for rate metrics (plan R2-04 T7) 1c8b2bc745

fix(kpi): promote catalog metric literals to shared KpiMetrics constants — drift becomes a compile error (plan R2-04 T8) cd93ad3976

fix(kpi): classify the failover fold-race pass loss as a self-healing Information event (plan R2-04 T9) 439dee52d3

perf(sitecallaudit): filtered IX_SiteCalls_Terminal index backs the retention purge predicate (plan R2-04 T10) 3d6973cc89

fix(sitecallaudit): time-sliced terminal purge replaces the single year-scale DELETE (plan R2-04 T11) 8f46b6cec2

fix(audit-log): retention loop absorbs shutdown cancellation instead of faulting host StopAsync (plan R2-04 T12) c573d8cac6

dohertj2 commented

2026-07-13 11:48:37 -04:00

Merged to main via the r2-integration fast-forward (main @ 1930f19b, pushed to origin). All commits from this branch are in main; the two integration-surfaced test fixes (IntegrationTests NodeName host-boot config, compile-cache assertion relax) landed on main as well. Closing — content fully integrated.

Merged to main via the r2-integration fast-forward (main @ 1930f19b, pushed to origin). All commits from this branch are in main; the two integration-surfaced test fixes (IntegrationTests NodeName host-boot config, compile-cache assertion relax) landed on main as well. Closing — content fully integrated.

dohertj2 closed this pull request

2026-07-13 11:48:37 -04:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/ScadaBridge#10