test(e2e): InstanceConfigure attribute-override + area reassignment + not-found edge

2026-06-06 11:58:45 -04:00
parent 3e4b0ca44c
commit fecac45d05
1 changed files with 99 additions and 0 deletions
@@ -68,4 +68,103 @@ public sealed class InstanceConfigureTests : IClassFixture<InstanceConfigureFixt
            && b.GetProperty("dataConnectionId").GetInt32() == _cfg.ConnectionId);
        Assert.True(bound, "Expected the Value attribute to be bound to the fixture connection after Save Bindings.");
    }
+
+    /// <summary>
+    /// Round-trips an attribute override through the <b>Attribute Overrides</b> card. The
+    /// override input carries no <c>data-test</c> hook, so it is located structurally: the
+    /// overrides card is the one whose Save button reads "Save Overrides"; inside it, the
+    /// table row whose label cell holds the attribute name (<c>_cfg.AttributeName</c> = "Value")
+    /// owns the type=text <c>input.form-control-sm</c>. Fills a sentinel value, saves, asserts
+    /// exactly one toast, then verifies the override persisted via a CLI <c>instance get</c>
+    /// read-back (not just the toast).
+    /// </summary>
+    [SkippableFact]
+    public async Task SaveOverride_RoundTrips()
+    {
+        Skip.IfNot(_cfg.Available, ClusterAvailability.SkipReason);
+
+        var page = await _fixture.NewAuthenticatedPageAsync("multi-role", "password");
+        await page.GotoAsync($"{PlaywrightFixture.BaseUrl}/deployment/instances/{_cfg.InstanceId}/configure");
+
+        // Blazor Server page renders a LoadingSpinner first; web-first wait for the overrides
+        // section's Save button before driving the input so we never race the post-load re-render.
+        await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
+        var saveOverrides = page.GetByRole(AriaRole.Button, new() { Name = "Save Overrides" });
+        await Assertions.Expect(saveOverrides).ToBeVisibleAsync(new() { Timeout = 15_000 });
+
+        // Scope to the Attribute Overrides card (the one containing the "Save Overrides" button),
+        // pick the row whose label cell text is the attribute name, then its text input.
+        var overridesCard = page.Locator("div.card", new() { Has = saveOverrides });
+        var overrideInput = overridesCard
+            .GetByRole(AriaRole.Row, new() { Name = _cfg.AttributeName })
+            .Locator("input.form-control-sm[type='text']");
+        await overrideInput.FillAsync("zztest-override-42");
+
+        await saveOverrides.ClickAsync();
+
+        await Assertions.Expect(page.Locator(".toast")).ToHaveCountAsync(1, new() { Timeout = 15_000 });
+
+        // Verify persistence via CLI read-back (not just the toast).
+        using var doc = await CliRunner.GetInstanceDocumentAsync(_cfg.InstanceId);
+        var overrides = doc.RootElement.GetProperty("attributeOverrides");
+        var saved = overrides.EnumerateArray().Any(o =>
+            o.GetProperty("attributeName").GetString() == _cfg.AttributeName
+            && o.GetProperty("overrideValue").GetString() == "zztest-override-42");
+        Assert.True(saved, "Expected the Value attribute override to persist after Save Overrides.");
+    }
+
+    /// <summary>
+    /// Reassigns the (initially area-less) fixture instance to the fixture area via the
+    /// <b>Area Assignment</b> card. Drives the existing <c>data-test='area-select'</c> hook by
+    /// VALUE (the area id, since the select binds the area id), clicks "Set Area", asserts one
+    /// toast, and verifies the new <c>areaId</c> via a CLI <c>instance get</c> read-back. This
+    /// mutates the shared fixture instance's area, but is independent of the other tests (each
+    /// gets a fresh page and asserts only on its own effect).
+    /// </summary>
+    [SkippableFact]
+    public async Task SetArea_RoundTrips()
+    {
+        Skip.IfNot(_cfg.Available, ClusterAvailability.SkipReason);
+
+        var page = await _fixture.NewAuthenticatedPageAsync("multi-role", "password");
+        await page.GotoAsync($"{PlaywrightFixture.BaseUrl}/deployment/instances/{_cfg.InstanceId}/configure");
+
+        await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
+        var areaSelect = page.Locator("[data-test='area-select']");
+        await Assertions.Expect(areaSelect).ToBeVisibleAsync(new() { Timeout = 15_000 });
+
+        // Select by VALUE = the area id (the select binds _reassignAreaId).
+        await areaSelect.SelectOptionAsync(new SelectOptionValue { Value = _cfg.AreaId.ToString() });
+        await page.GetByRole(AriaRole.Button, new() { Name = "Set Area" }).ClickAsync();
+
+        await Assertions.Expect(page.Locator(".toast")).ToHaveCountAsync(1, new() { Timeout = 15_000 });
+
+        // Verify persistence: areaId must equal the fixture area after Set Area (it may have been
+        // null/absent before).
+        using var doc = await CliRunner.GetInstanceDocumentAsync(_cfg.InstanceId);
+        Assert.True(doc.RootElement.TryGetProperty("areaId", out var areaIdEl)
+            && areaIdEl.ValueKind == JsonValueKind.Number,
+            "Expected areaId to be a number after Set Area.");
+        Assert.Equal(_cfg.AreaId, areaIdEl.GetInt32());
+    }
+
+    /// <summary>
+    /// Not-found edge: navigating to a configure URL for a non-existent instance id surfaces the
+    /// page's error alert (<c>data-test='instance-error-alert'</c>) carrying the
+    /// <c>$"Instance #{Id} not found."</c> message built in <c>InstanceConfigure.OnInitializedAsync</c>.
+    /// </summary>
+    [SkippableFact]
+    public async Task NotFoundInstance_ShowsErrorAlert()
+    {
+        Skip.IfNot(_cfg.Available, ClusterAvailability.SkipReason);
+
+        var page = await _fixture.NewAuthenticatedPageAsync("multi-role", "password");
+        await page.GotoAsync($"{PlaywrightFixture.BaseUrl}/deployment/instances/999999999/configure");
+
+        var errorAlert = page.Locator("[data-test='instance-error-alert']");
+        await Assertions.Expect(errorAlert).ToBeVisibleAsync(new() { Timeout = 10_000 });
+        await Assertions.Expect(errorAlert).ToContainTextAsync("not found");
+    }
+
+    // TODO(wave-N): alarm-override UI coverage — needs a template-with-alarm fixture (template alarms are not CLI-provisionable today).
 }