fix(configdb): InstanceLocator single untracked projected join (review 2026-10-21 08/P7)

2026-10-22 08:32:45 -04:00
parent 1d00d5f469
commit c6e4c7820a
2 changed files with 26 additions and 10 deletions
@@ -22,15 +22,13 @@ public class InstanceLocator : IInstanceLocator
        string instanceUniqueName,
        CancellationToken cancellationToken = default)
    {
-        var instance = await _context.Set<Commons.Entities.Instances.Instance>()
-            .FirstOrDefaultAsync(i => i.UniqueName == instanceUniqueName, cancellationToken);
-
-        if (instance == null)
-            return null;
-
-        var site = await _context.Set<Commons.Entities.Sites.Site>()
-            .FindAsync(new object[] { instance.SiteId }, cancellationToken);
-
-        return site?.SiteIdentifier;
+        // One untracked projected join: this sits on the inbound-API Route.To hot path and
+        // only needs a single string, so it must not materialise (and track) two entities.
+        return await (
+                from i in _context.Set<Commons.Entities.Instances.Instance>().AsNoTracking()
+                join s in _context.Set<Commons.Entities.Sites.Site>().AsNoTracking() on i.SiteId equals s.Id
+                where i.UniqueName == instanceUniqueName
+                select s.SiteIdentifier)
+            .FirstOrDefaultAsync(cancellationToken);
    }
 }
@@ -1486,6 +1486,24 @@ public class InstanceLocatorTests : IDisposable
        Assert.Equal("SITE-001", result);
    }

+    /// <summary>The lookup must not track entities (single untracked projection, review 08/P7).</summary>
+    /// <returns>A task that represents the asynchronous operation.</returns>
+    [Fact]
+    public async Task GetSiteIdForInstance_DoesNotTrackEntities()
+    {
+        var site = new Site("Site1", "SITE-001");
+        var template = new Template("T1");
+        _context.Sites.Add(site);
+        _context.Templates.Add(template);
+        await _context.SaveChangesAsync();
+        _context.Instances.Add(new Instance("Pump1") { SiteId = site.Id, TemplateId = template.Id });
+        await _context.SaveChangesAsync();
+        _context.ChangeTracker.Clear();
+
+        Assert.Equal("SITE-001", await _locator.GetSiteIdForInstanceAsync("Pump1"));
+        Assert.Empty(_context.ChangeTracker.Entries());
+    }
+
    /// <summary>Verifies that getting the site id for a missing instance returns null.</summary>
    /// <returns>A task that represents the asynchronous operation.</returns>
    [Fact]