dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

test(sms-e2e): valid Twilio SID fixture so the create path passes (Gitea #29)

Browse Source 
TestAccountSid was 'ACtest123' (AC + 6 chars). The management create
path validates the Account SID against ^AC[0-9a-fA-F]{32}$
(ManagementActor.cs:2205, added 2026-07-10, commit 40088a21) while the
fixture predates the guard (2026-06-19) — so the create was rejected and
the config-card + secret-non-leak assertions have been red/inert since.

Use AC + 32 hex (AC00000000000000000000000000000001) so the create
succeeds and the downstream Auth-Token-non-leak assertion actually runs
again. Unit-level RepositoryCoverageTests keep their short SIDs — they
construct SmsConfiguration directly and never hit the validated path.
This commit is contained in:
Joseph Doherty
2026-07-23 13:56:12 -04:00
parent c4dcd9bc02
commit 8524a7f746
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Notifications/SmsNotificationE2ETests.cs
+4 -2
View File
@@ -24,7 +24,7 @@ namespace ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests.Notifications;
/// </list>
///
/// <para>
/// Idempotency: the SMS-config fact uses a STABLE Account SID (<c>ACtest123</c>) and probes
/// Idempotency: the SMS-config fact uses a STABLE Account SID (<c>AC000…0001</c>) and probes
/// <c>notification sms list</c> first — if a prior run already created it, the fact SKIPS the
/// create and verifies the existing row instead (the page exposes no delete verb — neither UI
/// nor CLI — so we never create a second copy we could not clean up; the render-crash +
@@ -41,7 +41,9 @@ public class SmsNotificationE2ETests
// Stable test fixture values. The Account SID is stable (not random) so reruns find the
// prior config via 'notification sms list' and skip re-creation — the SMS config page has
// no delete verb, so a unique-per-run SID would leak a config on every run.
private const string TestAccountSid = "ACtest123";
// Must match the ManagementActor create guard ^AC[0-9a-fA-F]{32}$ (added 2026-07-10) or
// the create is rejected and the config-card / secret-non-leak assertions never run.
private const string TestAccountSid = "AC00000000000000000000000000000001";
private const string TestFromNumber = "+15551230000";
// The Auth Token VALUE that must NEVER be echoed back to the page (presence flag only).
private const string TestAuthTokenValue = "e2e-secret-token-xyz";