dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(commons): ActorNameRules accepts ( ) and " like Akka's IsValidPathElement (review 2026-10-21 01/SR-C1 parity)

Browse Source
This commit is contained in:
Joseph Doherty
2026-10-22 08:24:48 -04:00
parent 7aacc49043
commit 77b3a2c23f
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ZB.MOM.WW.ScadaBridge.Commons/Validation/ActorNameRules.cs
+1 -1
View File
@@ -9,7 +9,7 @@ namespace ZB.MOM.WW.ScadaBridge.Commons.Validation;
/// </summary> /// </summary>
public static class ActorNameRules public static class ActorNameRules
{ {
private const string AllowedSymbols = "-_.*$+:@&=,!~';"; private const string AllowedSymbols = "-_.*$+:@&=,!~';()\"";
/// <summary>True when <paramref name="name"/> is a legal actor path element.</summary> /// <summary>True when <paramref name="name"/> is a legal actor path element.</summary>
public static bool IsValid(string? name) public static bool IsValid(string? name)
tests/ZB.MOM.WW.ScadaBridge.Commons.Tests/Validation/ActorNameRulesTests.cs
+2
View File
@@ -23,6 +23,8 @@ public class ActorNameRulesTests
[InlineData("Furnace-3")] [InlineData("Furnace-3")]
[InlineData("Line_1.A")] [InlineData("Line_1.A")]
[InlineData("a%20b")] [InlineData("a%20b")]
[InlineData("Pump(A)")]
[InlineData("say\"hi\"")]
public void IsValid_AcceptsLegalNames(string name) public void IsValid_AcceptsLegalNames(string name)
{ {
Assert.True(ActorNameRules.IsValid(name)); Assert.True(ActorNameRules.IsValid(name));