From 77b3a2c23f6c3257752e8c8dd05f32447e5b1c2b Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Thu, 22 Oct 2026 08:24:48 -0400 Subject: [PATCH] fix(commons): ActorNameRules accepts ( ) and " like Akka's IsValidPathElement (review 2026-10-21 01/SR-C1 parity) --- src/ZB.MOM.WW.ScadaBridge.Commons/Validation/ActorNameRules.cs | 2 +- .../Validation/ActorNameRulesTests.cs | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ZB.MOM.WW.ScadaBridge.Commons/Validation/ActorNameRules.cs b/src/ZB.MOM.WW.ScadaBridge.Commons/Validation/ActorNameRules.cs index c946c184..91dbfc71 100644 --- a/src/ZB.MOM.WW.ScadaBridge.Commons/Validation/ActorNameRules.cs +++ b/src/ZB.MOM.WW.ScadaBridge.Commons/Validation/ActorNameRules.cs @@ -9,7 +9,7 @@ namespace ZB.MOM.WW.ScadaBridge.Commons.Validation; /// public static class ActorNameRules { - private const string AllowedSymbols = "-_.*$+:@&=,!~';"; + private const string AllowedSymbols = "-_.*$+:@&=,!~';()\""; /// True when is a legal actor path element. public static bool IsValid(string? name) diff --git a/tests/ZB.MOM.WW.ScadaBridge.Commons.Tests/Validation/ActorNameRulesTests.cs b/tests/ZB.MOM.WW.ScadaBridge.Commons.Tests/Validation/ActorNameRulesTests.cs index b6f6ffba..2d4ee2c8 100644 --- a/tests/ZB.MOM.WW.ScadaBridge.Commons.Tests/Validation/ActorNameRulesTests.cs +++ b/tests/ZB.MOM.WW.ScadaBridge.Commons.Tests/Validation/ActorNameRulesTests.cs @@ -23,6 +23,8 @@ public class ActorNameRulesTests [InlineData("Furnace-3")] [InlineData("Line_1.A")] [InlineData("a%20b")] + [InlineData("Pump(A)")] + [InlineData("say\"hi\"")] public void IsValid_AcceptsLegalNames(string name) { Assert.True(ActorNameRules.IsValid(name));