dohertj2/ScadaBridge
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

test(playwright): seed inside try in Notification filter/modal tests for guaranteed cleanup (review fix)

Browse Source
This commit is contained in:
Joseph Doherty
2026-06-07 04:32:16 -04:00
parent b1d7497463
commit 70e84a7b79
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Notifications/NotificationActionTests.cs
+11 -9
View File
@@ -183,14 +183,15 @@ public class NotificationActionTests
var runId = Guid.NewGuid().ToString("N"); var runId = Guid.NewGuid().ToString("N");
var marker = $"zztest-notif-wave4-{runId}"; var marker = $"zztest-notif-wave4-{runId}";
// Two Parked rows under the SAME ListName marker, distinct subjects.
await NotificationDataSeeder.InsertParkedNotificationAsync(
Guid.NewGuid(), marker, "wave4-alpha", "site-a");
await NotificationDataSeeder.InsertParkedNotificationAsync(
Guid.NewGuid(), marker, "wave4-beta", "site-a");
try try
{ {
// Two Parked rows under the SAME ListName marker, distinct subjects.
// Seeded inside the try so a mid-seed failure is still cleaned up by the finally.
await NotificationDataSeeder.InsertParkedNotificationAsync(
Guid.NewGuid(), marker, "wave4-alpha", "site-a");
await NotificationDataSeeder.InsertParkedNotificationAsync(
Guid.NewGuid(), marker, "wave4-beta", "site-a");
var page = await _fixture.NewAuthenticatedPageAsync(); var page = await _fixture.NewAuthenticatedPageAsync();
await page.GotoAsync($"{PlaywrightFixture.BaseUrl}{NotificationReportUrl}"); await page.GotoAsync($"{PlaywrightFixture.BaseUrl}{NotificationReportUrl}");
await page.WaitForLoadStateAsync(LoadState.NetworkIdle); await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
@@ -240,11 +241,12 @@ public class NotificationActionTests
var runId = Guid.NewGuid().ToString("N"); var runId = Guid.NewGuid().ToString("N");
var marker = $"zztest-notif-wave4-{runId}"; var marker = $"zztest-notif-wave4-{runId}";
await NotificationDataSeeder.InsertParkedNotificationAsync(
Guid.NewGuid(), marker, "wave4-detail", "site-a");
try try
{ {
// Seeded inside the try so a mid-seed failure is still cleaned up by the finally.
await NotificationDataSeeder.InsertParkedNotificationAsync(
Guid.NewGuid(), marker, "wave4-detail", "site-a");
var page = await _fixture.NewAuthenticatedPageAsync(); var page = await _fixture.NewAuthenticatedPageAsync();
await page.GotoAsync($"{PlaywrightFixture.BaseUrl}{NotificationReportUrl}"); await page.GotoAsync($"{PlaywrightFixture.BaseUrl}{NotificationReportUrl}");
await page.WaitForLoadStateAsync(LoadState.NetworkIdle); await page.WaitForLoadStateAsync(LoadState.NetworkIdle);