From 70e84a7b7957fce7413b716bd98b722066b0febf Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Sun, 7 Jun 2026 04:32:16 -0400 Subject: [PATCH] test(playwright): seed inside try in Notification filter/modal tests for guaranteed cleanup (review fix) --- .../Notifications/NotificationActionTests.cs | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Notifications/NotificationActionTests.cs b/tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Notifications/NotificationActionTests.cs index e2636916..8d548f86 100644 --- a/tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Notifications/NotificationActionTests.cs +++ b/tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Notifications/NotificationActionTests.cs @@ -183,14 +183,15 @@ public class NotificationActionTests var runId = Guid.NewGuid().ToString("N"); var marker = $"zztest-notif-wave4-{runId}"; - // Two Parked rows under the SAME ListName marker, distinct subjects. - await NotificationDataSeeder.InsertParkedNotificationAsync( - Guid.NewGuid(), marker, "wave4-alpha", "site-a"); - await NotificationDataSeeder.InsertParkedNotificationAsync( - Guid.NewGuid(), marker, "wave4-beta", "site-a"); - try { + // Two Parked rows under the SAME ListName marker, distinct subjects. + // Seeded inside the try so a mid-seed failure is still cleaned up by the finally. + await NotificationDataSeeder.InsertParkedNotificationAsync( + Guid.NewGuid(), marker, "wave4-alpha", "site-a"); + await NotificationDataSeeder.InsertParkedNotificationAsync( + Guid.NewGuid(), marker, "wave4-beta", "site-a"); + var page = await _fixture.NewAuthenticatedPageAsync(); await page.GotoAsync($"{PlaywrightFixture.BaseUrl}{NotificationReportUrl}"); await page.WaitForLoadStateAsync(LoadState.NetworkIdle); @@ -240,11 +241,12 @@ public class NotificationActionTests var runId = Guid.NewGuid().ToString("N"); var marker = $"zztest-notif-wave4-{runId}"; - await NotificationDataSeeder.InsertParkedNotificationAsync( - Guid.NewGuid(), marker, "wave4-detail", "site-a"); - try { + // Seeded inside the try so a mid-seed failure is still cleaned up by the finally. + await NotificationDataSeeder.InsertParkedNotificationAsync( + Guid.NewGuid(), marker, "wave4-detail", "site-a"); + var page = await _fixture.NewAuthenticatedPageAsync(); await page.GotoAsync($"{PlaywrightFixture.BaseUrl}{NotificationReportUrl}"); await page.WaitForLoadStateAsync(LoadState.NetworkIdle);