dohertj2/ScadaBridge
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

test(e2e): move deploy/disable preconditions inside try for guaranteed cleanup (review fix)

Browse Source 
In Disable_Instance_ShowsOutcomeToast and Enable_Instance_ShowsOutcomeToast, the
precondition CLI calls (DeployInstanceAsync / DisableInstanceAsync) were between
CreateInstanceAsync and the try block. A throw there would skip the finally
DeleteInstanceAsync, leaking the instance. Moved those calls to be the first
statements inside try so cleanup always runs once the instance exists.
This commit is contained in:
Joseph Doherty
2026-06-05 10:52:00 -04:00
parent ad0bc33231
commit 5546c32593
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Deployment/DeploymentActionTests.cs
+7 -7
View File
@@ -86,11 +86,11 @@ public class DeploymentActionTests : IClassFixture<DeploymentFixture>
Skip.IfNot(_cluster.Available, ClusterAvailability.SkipReason);
var (instanceId, uniqueName) = await _cluster.CreateInstanceAsync();
// Deploy moves the instance config state to Enabled, so the context menu
// offers "Disable" (it would offer "Enable" only for a Disabled instance).
await CliRunner.DeployInstanceAsync(instanceId);
try
{
// Deploy moves the instance config state to Enabled, so the context menu
// offers "Disable" (it would offer "Enable" only for a Disabled instance).
await CliRunner.DeployInstanceAsync(instanceId);
var page = await _pw.NewAuthenticatedPageAsync();
await OpenInstanceContextMenuAsync(page, uniqueName);
@@ -119,12 +119,12 @@ public class DeploymentActionTests : IClassFixture<DeploymentFixture>
Skip.IfNot(_cluster.Available, ClusterAvailability.SkipReason);
var (instanceId, uniqueName) = await _cluster.CreateInstanceAsync();
// Deploy then Disable leaves the instance config state at Disabled, so the
// context menu offers "Enable".
await CliRunner.DeployInstanceAsync(instanceId);
await CliRunner.DisableInstanceAsync(instanceId);
try
{
// Deploy then Disable leaves the instance config state at Disabled, so the
// context menu offers "Enable".
await CliRunner.DeployInstanceAsync(instanceId);
await CliRunner.DisableInstanceAsync(instanceId);
var page = await _pw.NewAuthenticatedPageAsync();
await OpenInstanceContextMenuAsync(page, uniqueName);