mbproxy: remediate the 2026-05-16 code-review findings
Fixes every finding from the codereviews/2026-05-16 multi-agent review (2 Critical, 20 Major, 38 Minor) and adds that review to the repo. Highlights: dashboard XSS escape; response cache invalidated on the write request (not just the response); ReloadValidator now runs at startup so port collisions / duplicate names / malformed Resilience profiles fail fast; AdminPort 0 genuinely disables the admin endpoint; PlcListener accept-loop faults propagate to the supervisor's faulted path; reconciler Restart builds before removing; Resilience pipelines are restart-only from a frozen snapshot; multiplexer connect-race leak, watchdog party-list snapshot, backend-response and FC16 framing validation; frontend reconnect retry and util.js load guard; plus the log-event/doc drift sweep and test-port hygiene. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -97,9 +97,14 @@ public sealed class MbproxyOptionsValidator : IValidateOptions<MbproxyOptions>
|
||||
}
|
||||
}
|
||||
|
||||
// Cache section ranges.
|
||||
// Cache section ranges. MaxEntriesPerPlc has a hard ceiling because the cache's
|
||||
// LRU eviction is an O(n) scan under a lock — a fat-fingered seven-figure value
|
||||
// would stall the backend reader on every cache-miss store.
|
||||
if (options.Cache.MaxEntriesPerPlc < 0)
|
||||
errors.Add($"Cache.MaxEntriesPerPlc must be >= 0; got {options.Cache.MaxEntriesPerPlc}.");
|
||||
else if (options.Cache.MaxEntriesPerPlc > 100_000)
|
||||
errors.Add(
|
||||
$"Cache.MaxEntriesPerPlc must be <= 100000; got {options.Cache.MaxEntriesPerPlc}.");
|
||||
if (options.Cache.EvictionIntervalMs < 0)
|
||||
errors.Add($"Cache.EvictionIntervalMs must be >= 0; got {options.Cache.EvictionIntervalMs}.");
|
||||
|
||||
|
||||
Reference in New Issue
Block a user