mbproxy: strip historical phase/wave/plan references from source comments
Comments described the *history* of how the code arrived (phase numbers, wave IDs, review IDs, dated TODOs) instead of what it does today. That scaffolding rotted as the codebase evolved. Cleaned 60 source files + .gitignore; behaviour unchanged (387/387 tests still pass). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -75,10 +75,10 @@ internal static class ReloadValidator
|
||||
// ── 4. Per-PLC tag-map build ──────────────────────────────────────────
|
||||
// BcdTagMapBuilder.Build is the single source of truth for tag-list
|
||||
// well-formedness; we must not duplicate its validation logic here.
|
||||
// Phase 12 (W2.10) — also re-check the RESOLVED per-tag CacheTtlMs against
|
||||
// AllowLongTtl. The raw-input check at section 5 covers explicit per-tag and
|
||||
// per-PLC-default values, but defensively re-validating the post-fold values
|
||||
// catches any future fold logic that produces a value above the gate.
|
||||
// Also re-check the RESOLVED per-tag CacheTtlMs against AllowLongTtl. The raw-
|
||||
// input check at section 5 covers explicit per-tag and per-PLC-default values,
|
||||
// but defensively re-validating the post-fold values catches any future fold
|
||||
// logic that produces a value above the gate.
|
||||
bool allowLongTtlForResolved = next.Cache.AllowLongTtl;
|
||||
foreach (var plc in next.Plcs)
|
||||
{
|
||||
@@ -98,7 +98,7 @@ internal static class ReloadValidator
|
||||
}
|
||||
}
|
||||
|
||||
// ── 5. Cache TTL bounds (Phase 11) ────────────────────────────────────
|
||||
// ── 5. Cache TTL bounds ───────────────────────────────────────────────
|
||||
// The MbproxyOptionsValidator catches these at schema time too, but ReloadValidator
|
||||
// is the gate that the hot-reload path consults directly so re-checking here keeps
|
||||
// both paths internally consistent (and the validator runs against tag-map-resolved
|
||||
@@ -129,8 +129,8 @@ internal static class ReloadValidator
|
||||
if (next.Cache.EvictionIntervalMs < 0)
|
||||
errs.Add($"Cache.EvictionIntervalMs must be >= 0; got {next.Cache.EvictionIntervalMs}.");
|
||||
|
||||
// Phase 12 (W2.18) — Connection timeouts must be > 0. A reload that sets any
|
||||
// of these to 0 or negative would break the runtime; reject the reload as a whole.
|
||||
// Connection timeouts must be > 0. A reload that sets any of these to 0 or
|
||||
// negative would break the runtime; reject the reload as a whole.
|
||||
if (next.Connection.BackendConnectTimeoutMs <= 0)
|
||||
errs.Add(
|
||||
$"Connection.BackendConnectTimeoutMs must be > 0; got {next.Connection.BackendConnectTimeoutMs}.");
|
||||
|
||||
Reference in New Issue
Block a user