Joseph Doherty
544a6ddb77
Resolves the 35 findings from the 2026-06-01 baseline (commit 26ba1c7),
test-first for every behavioral change. +51 tests (331 -> 382 passing, 0 failed).
- Telemetry-001 (HIGH): RedactionEnricher now honours property removal, so a
redactor that drops a key actually scrubs the secret from the event.
- Auth: LDAP validator ValidateOnStart; API-key verify no longer fails on a
best-effort MarkUsed write or a corrupt scopes column (fail-closed); LDAP cert
validation hook; KeyPrefix persistence aligned; README algorithm corrected.
- Health: Akka checks return Degraded (not throw) when the cluster isn't up yet;
GrpcDependencyHealthCheck catch-all; null 'description' rendered; composite
endpoint builder; XML docs shipped.
- Audit: CompositeAuditWriter no longer re-throws OperationCanceledException;
TruncatingAuditRedactor over-redact scrubs Target + safe negative max; options
record; XML docs shipped.
- Configuration: TryAddEnumerable idempotent registration; consistent port
quoting; strict invariant port parsing; XML docs + README packaged.
- Theme: mobile toggle is now CSS-only (no Bootstrap JS); token/CSS hygiene;
XML docs on the public parameter surface.
Shared-contract/spec docs updated where the code was the source of truth
(observability service.instance.id, MapZbMetrics, redactor reach). All changes
additive/back-compatible at v0.1.0. code-reviews bookkeeping follows separately.
66 lines
2.6 KiB
C#
66 lines
2.6 KiB
C#
namespace ZB.MOM.WW.Theme.Tests;
|
|
|
|
public class ThemeShellTests : TestContext
|
|
{
|
|
[Fact]
|
|
public void Renders_product_nav_and_body()
|
|
{
|
|
var cut = RenderComponent<ThemeShell>(p => p
|
|
.Add(x => x.Product, "OtOpcUa")
|
|
.Add(x => x.Nav, (RenderFragment)(b => b.AddMarkupContent(0, "<a class='rail-link'>N</a>")))
|
|
.AddChildContent("<div class='pagebody'>BODY</div>"));
|
|
Assert.NotNull(cut.Find(".side-rail .brand"));
|
|
Assert.Contains("OtOpcUa", cut.Markup);
|
|
Assert.NotNull(cut.Find(".side-rail .rail-link"));
|
|
Assert.NotNull(cut.Find("main.page .pagebody"));
|
|
}
|
|
|
|
[Fact]
|
|
public void Accent_sets_css_variable_on_shell_root()
|
|
{
|
|
var cut = RenderComponent<ThemeShell>(p => p
|
|
.Add(x => x.Product, "ScadaBridge")
|
|
.Add(x => x.Accent, "#2f855a"));
|
|
var shell = cut.Find(".app-shell");
|
|
Assert.Contains("--accent: #2f855a", shell.GetAttribute("style"));
|
|
}
|
|
|
|
[Fact]
|
|
public void No_accent_emits_no_style()
|
|
{
|
|
var cut = RenderComponent<ThemeShell>(p => p.Add(x => x.Product, "MXAccess Gateway"));
|
|
Assert.False(cut.Find(".app-shell").HasAttribute("style"));
|
|
}
|
|
|
|
[Fact]
|
|
public void RailFooter_renders_when_supplied()
|
|
{
|
|
var cut = RenderComponent<ThemeShell>(p => p
|
|
.Add(x => x.Product, "OtOpcUa")
|
|
.Add(x => x.RailFooter, (RenderFragment)(b => b.AddMarkupContent(0, "<span class='sess'>S</span>"))));
|
|
Assert.NotNull(cut.Find(".rail-foot .sess"));
|
|
}
|
|
|
|
// Theme-001: the mobile hamburger must work without Bootstrap collapse JS.
|
|
// The shell is a native <details> disclosure whose <summary> is the toggle —
|
|
// no data-bs-toggle / data-bs-target attributes, so no Bootstrap JS dependency.
|
|
[Fact]
|
|
public void Mobile_toggle_is_a_css_only_details_disclosure_not_bootstrap_collapse()
|
|
{
|
|
var cut = RenderComponent<ThemeShell>(p => p.Add(x => x.Product, "OtOpcUa"));
|
|
|
|
// Root is a <details> whose direct <summary> is the hamburger toggle.
|
|
var shell = cut.Find("details.app-shell");
|
|
var summary = cut.Find("details.app-shell > summary.rail-toggle");
|
|
Assert.NotNull(summary);
|
|
|
|
// The rail is plain markup inside the <details> — no Bootstrap .collapse class.
|
|
var rail = cut.Find("#theme-rail");
|
|
Assert.DoesNotContain("collapse", rail.ClassList);
|
|
|
|
// No Bootstrap collapse JS hooks anywhere in the shell markup.
|
|
Assert.DoesNotContain("data-bs-toggle", shell.OuterHtml);
|
|
Assert.DoesNotContain("data-bs-target", shell.OuterHtml);
|
|
}
|
|
}
|