Joseph Doherty
544a6ddb77
Resolves the 35 findings from the 2026-06-01 baseline (commit 26ba1c7),
test-first for every behavioral change. +51 tests (331 -> 382 passing, 0 failed).
- Telemetry-001 (HIGH): RedactionEnricher now honours property removal, so a
redactor that drops a key actually scrubs the secret from the event.
- Auth: LDAP validator ValidateOnStart; API-key verify no longer fails on a
best-effort MarkUsed write or a corrupt scopes column (fail-closed); LDAP cert
validation hook; KeyPrefix persistence aligned; README algorithm corrected.
- Health: Akka checks return Degraded (not throw) when the cluster isn't up yet;
GrpcDependencyHealthCheck catch-all; null 'description' rendered; composite
endpoint builder; XML docs shipped.
- Audit: CompositeAuditWriter no longer re-throws OperationCanceledException;
TruncatingAuditRedactor over-redact scrubs Target + safe negative max; options
record; XML docs shipped.
- Configuration: TryAddEnumerable idempotent registration; consistent port
quoting; strict invariant port parsing; XML docs + README packaged.
- Theme: mobile toggle is now CSS-only (no Bootstrap JS); token/CSS hygiene;
XML docs on the public parameter surface.
Shared-contract/spec docs updated where the code was the source of truth
(observability service.instance.id, MapZbMetrics, redactor reach). All changes
additive/back-compatible at v0.1.0. code-reviews bookkeeping follows separately.
70 lines
2.7 KiB
C#
70 lines
2.7 KiB
C#
using System.IO;
|
|
using System.Linq;
|
|
using System.Text.RegularExpressions;
|
|
|
|
namespace ZB.MOM.WW.Theme.Tests;
|
|
|
|
public class StaticAssetsTests
|
|
{
|
|
// wwwroot is copied next to the test assembly via the RCL static-web-asset pipeline,
|
|
// but the simplest stable check is against the source tree relative to the test binary.
|
|
private static string Wwwroot =>
|
|
Path.GetFullPath(Path.Combine(AppContext.BaseDirectory,
|
|
"..", "..", "..", "..", "..", "src", "ZB.MOM.WW.Theme", "wwwroot"));
|
|
|
|
[Fact]
|
|
public void ThemeCss_exists_and_defines_accent_token()
|
|
{
|
|
var css = File.ReadAllText(Path.Combine(Wwwroot, "css", "theme.css"));
|
|
Assert.Contains("--accent:", css);
|
|
Assert.Contains("--ok:", css);
|
|
}
|
|
|
|
[Fact]
|
|
public void ThemeCss_uses_corrected_relative_font_path()
|
|
{
|
|
var css = File.ReadAllText(Path.Combine(Wwwroot, "css", "theme.css"));
|
|
Assert.Contains("url('../fonts/ibm-plex-sans-400.woff2')", css);
|
|
Assert.DoesNotContain("url('fonts/ibm-plex", css); // the latent 404 path is gone
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("ibm-plex-sans-400.woff2")]
|
|
[InlineData("ibm-plex-sans-600.woff2")]
|
|
[InlineData("ibm-plex-mono-500.woff2")]
|
|
public void Fonts_are_vendored(string file) =>
|
|
Assert.True(File.Exists(Path.Combine(Wwwroot, "fonts", file)));
|
|
|
|
// Theme-002: .chip-idle pairs the idle background with the matching --idle
|
|
// foreground token (per DESIGN-TOKENS.md), not --ink-soft.
|
|
[Fact]
|
|
public void ChipIdle_pairs_idle_foreground_with_idle_background()
|
|
{
|
|
var css = File.ReadAllText(Path.Combine(Wwwroot, "css", "theme.css"));
|
|
var rule = Regex.Match(css, @"\.chip-idle\s*\{[^}]*\}").Value;
|
|
Assert.Contains("color: var(--idle)", rule);
|
|
Assert.Contains("background: var(--idle-bg)", rule);
|
|
Assert.DoesNotContain("--ink-soft", rule);
|
|
}
|
|
|
|
// Theme-003: no hardcoded hex colours appear outside the :root token block in
|
|
// either stylesheet — every shade is a named token.
|
|
[Theory]
|
|
[InlineData("theme.css")]
|
|
[InlineData("layout.css")]
|
|
public void No_hardcoded_hex_outside_root_token_block(string file)
|
|
{
|
|
var css = File.ReadAllText(Path.Combine(Wwwroot, "css", file));
|
|
|
|
// Strip the :root { ... } declaration block(s) — the one place hex literals live.
|
|
var withoutRoot = Regex.Replace(css, @":root\s*\{[^}]*\}", string.Empty);
|
|
|
|
var hexLiterals = Regex.Matches(withoutRoot, @"#[0-9a-fA-F]{3,8}\b")
|
|
.Select(m => m.Value)
|
|
.ToList();
|
|
|
|
Assert.True(hexLiterals.Count == 0,
|
|
$"{file} has hardcoded hex outside :root: {string.Join(", ", hexLiterals)}");
|
|
}
|
|
}
|