Joseph Doherty
544a6ddb77
Resolves the 35 findings from the 2026-06-01 baseline (commit 26ba1c7),
test-first for every behavioral change. +51 tests (331 -> 382 passing, 0 failed).
- Telemetry-001 (HIGH): RedactionEnricher now honours property removal, so a
redactor that drops a key actually scrubs the secret from the event.
- Auth: LDAP validator ValidateOnStart; API-key verify no longer fails on a
best-effort MarkUsed write or a corrupt scopes column (fail-closed); LDAP cert
validation hook; KeyPrefix persistence aligned; README algorithm corrected.
- Health: Akka checks return Degraded (not throw) when the cluster isn't up yet;
GrpcDependencyHealthCheck catch-all; null 'description' rendered; composite
endpoint builder; XML docs shipped.
- Audit: CompositeAuditWriter no longer re-throws OperationCanceledException;
TruncatingAuditRedactor over-redact scrubs Target + safe negative max; options
record; XML docs shipped.
- Configuration: TryAddEnumerable idempotent registration; consistent port
quoting; strict invariant port parsing; XML docs + README packaged.
- Theme: mobile toggle is now CSS-only (no Bootstrap JS); token/CSS hygiene;
XML docs on the public parameter surface.
Shared-contract/spec docs updated where the code was the source of truth
(observability service.instance.id, MapZbMetrics, redactor reach). All changes
additive/back-compatible at v0.1.0. code-reviews bookkeeping follows separately.
70 lines
2.7 KiB
C#
70 lines
2.7 KiB
C#
namespace ZB.MOM.WW.Audit.Tests;
|
|
|
|
public class CompositeAuditWriterTests
|
|
{
|
|
private sealed class RecordingWriter : IAuditWriter
|
|
{
|
|
public int Count;
|
|
public Task WriteAsync(AuditEvent evt, CancellationToken ct = default) { Count++; return Task.CompletedTask; }
|
|
}
|
|
private sealed class ThrowingWriter : IAuditWriter
|
|
{
|
|
public Task WriteAsync(AuditEvent evt, CancellationToken ct = default) => throw new InvalidOperationException("boom");
|
|
}
|
|
private sealed class CancellingWriter : IAuditWriter
|
|
{
|
|
public Task WriteAsync(AuditEvent evt, CancellationToken ct = default) => throw new OperationCanceledException();
|
|
}
|
|
|
|
private static AuditEvent Evt() => new() { EventId = Guid.NewGuid(), OccurredAtUtc = DateTimeOffset.UtcNow,
|
|
Actor = "a", Action = "x", Outcome = AuditOutcome.Success };
|
|
|
|
[Fact]
|
|
public async Task Fans_out_to_all_writers()
|
|
{
|
|
var a = new RecordingWriter(); var b = new RecordingWriter();
|
|
await new CompositeAuditWriter(new IAuditWriter[] { a, b }).WriteAsync(Evt());
|
|
Assert.Equal(1, a.Count);
|
|
Assert.Equal(1, b.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task One_failing_writer_does_not_stop_the_others()
|
|
{
|
|
var after = new RecordingWriter();
|
|
var sut = new CompositeAuditWriter(new IAuditWriter[] { new ThrowingWriter(), after });
|
|
await sut.WriteAsync(Evt()); // must not throw
|
|
Assert.Equal(1, after.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Cancellation_does_not_surface_to_the_caller()
|
|
{
|
|
// Per the IAuditWriter hard contract ("must not throw to the caller"), an
|
|
// OperationCanceledException from an inner writer is swallowed like any other failure —
|
|
// it must NOT abort the user-facing action that produced the event.
|
|
var after = new RecordingWriter();
|
|
var sut = new CompositeAuditWriter(new IAuditWriter[] { new CancellingWriter(), after });
|
|
await sut.WriteAsync(Evt()); // must not throw
|
|
Assert.Equal(1, after.Count); // drain continues past the cancelled writer
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Empty_writer_list_is_a_no_op()
|
|
{
|
|
var sut = new CompositeAuditWriter(Array.Empty<IAuditWriter>());
|
|
await sut.WriteAsync(Evt()); // must not throw
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Null_writer_entry_is_swallowed_and_does_not_stop_the_others()
|
|
{
|
|
// A null inner writer faults the await; the best-effort seam swallows it (like any
|
|
// other writer failure) and continues draining the remaining writers.
|
|
var after = new RecordingWriter();
|
|
var sut = new CompositeAuditWriter(new IAuditWriter?[] { null, after }!);
|
|
await sut.WriteAsync(Evt()); // must not throw
|
|
Assert.Equal(1, after.Count);
|
|
}
|
|
}
|