5.0 KiB
Independent ScadaBridge SB01–03 peer review
Reviewed 2026-11-13 against the actual sister checkout based on cdd3adf6, with SB01–03 changes pending at review time. Read-only source review plus one narrowly scoped native Chromium focus probe; no sister source/test edits, broad suite rerun, operations endpoints or deployment.
Concrete finding
P2 — Connected does not guarantee a usable focus restoration target. src/ZB.MOM.WW.ScadaBridge.CentralUI/wwwroot/js/dialog.js:33 enters its trigger branch whenever the captured element remains connected and outside inert ancestry. A disabled, hidden or otherwise nonfocusable trigger meets those checks; .focus() silently fails, and the heading fallback never executes. Removing the closed overlay then leaves focus on BODY, interrupting keyboard position.
Reproduced with the unchanged actual script in a disposable Chromium document: focus a native trigger button → activate the overlay → disable the still-connected trigger → remove the overlay → await the script's MutationObserver. Observed active=BODY, heading tabindex absent, modal-open=false, inert count0. This is a native lifecycle reproduction, not a claim that a specific live fleet route disables its trigger during dismissal.
Recommendation: after attempting trigger focus, verify document.activeElement === trigger; otherwise use the existing logical heading/main fallback. Filtering disabled/hidden targets is useful, but verifying actual focus also covers programmatically captured nonfocusable headings. Add a focused regression for disabled/hidden connected triggers alongside disconnected-trigger coverage. Retain current typed cancellation, single-active-overlay guard, lock cleanup and deferred temporary-tabindex removal.
Reviewed behavior without an additional finding
- DialogHost uses per-instance IDs for overlay/title/prompt and confirmation description; prompt label targets the actual input. It preserves Confirm=false, Prompt=null and custom typed default cancellation through DialogService.Resolve; disposal unsubscribes before cancelling any pending local result. The original service second-dialog guard remains.
- The actual DOM keydown listener owns synchronous Tab prevention; native-event filtering excludes disabled, hidden/inert and negative-tabindex controls. Escape's typed cancellation stays in Blazor. Single-active presentation rejection prevents sibling/descendant modal lifecycle ambiguity. Detached-node observer cleanup restores prior inert/body-lock state. Drawer routes rejection/Escape through its existing OnClose callback and deactivates on disposal.
- Sampled OPC UA and Mx Gateway field/error changes preserve the original EntityName exact/suffix matching logic. Conditional invalidity/describedby and rendered error ID use the same helper/key. Newly added text/number/select IDs are per-component-instance scopes. Existing primary/backup checkbox IdPrefix callers remain explicitly distinct in DataConnectionForm. No sampled field was newly assigned an unrelated validation error or bypassed a validator.
- MultiSelect toggle name combines the visible field ID and its unique current-summary ID. Its individual checkboxes retain wrapping labels. DataTable's new visible search label targets its instance ID rather than relying on placeholder text.
SB03 acceptance boundary
The batch report correctly leaves SB03 incomplete. Source associations are evidence of intended relationships, not proof of the rendered accessibility tree or control internals. TreeView currently names every checkbox “Select tree item” (Components/Shared/TreeView.razor:114); contextual tree names are an already documented pending item. Sampled repeated SchemaBuilder property names/types are also generic; native/editor/group context and Monaco internals require their promised rendered checks. Help descriptions, aggregate errors, repeated editor IDs and transport/notification/instance runtime samples remain under the author's explicit pending verification.
No new contradictory SB03 completion claim was found in the reviewed report. Do not infer all30+ component runtime acceptance from source-group JSON, regex counts or the passing full suite. This review makes no shared ledger/gate change. Address the concrete focus-target finding before lifecycle acceptance; the remaining known SB03 work stays open.
Resolution checkpoint
The original disabled/hidden connected-trigger finding was corrected in the accepted SB01–02 batch 87c882ec: current dialog.js checks whether trigger focus actually succeeded and otherwise uses the existing heading/main fallback. Focus cleanup/lifecycle regressions and rendered browser proofs were accepted. The originally pending SB03 work subsequently passed scoped composite labels, native editor/Monaco/contextual tree and help/error checks (915a8a59 plus 102cbb2e). This historical review's incomplete status describes its original checkpoint, not the final chapter; final chapter acceptance is d370dbd3,1597 tests, with explicit representative-runtime/deployment limits in the sister verification report.