3.0 KiB
Independent MX browse review
Reviewed commit c9a6c31cb8d0409674e7c7070d36cefd45afa652 read-only in the authorized MxAccessGateway checkout. Scope: BrowsePage, recursive BrowseTreeNodeView, scoped site CSS additions, the two framework-render test files, technical-light-browse.md and retained first/final browser evidence/script. No MX source edits, test rerun, browser fixture restart or live operations.
No concrete callback, state or accessibility regression found in this commit.
- Each expandable node has one native button; Enter/Space uses its existing ToggleAsync callback, aria-expanded tracks
_expanded, and aria-controls refers to the same per-instance stable ChildrenId used on the hidden/expanded container. Leaf nodes expose no unavailable expansion action. Existing HasChildrenHint/LoadState/OnLoadChildren projection and lazy-load behavior are unchanged. - Watch on recursive attributes/search hits calls the existing add-subscription path with the original full reference. The row's double-click accelerator is retained; the button stops that event's propagation. AddTagAsync claims the subscription synchronously before its first await and retains the ordinal duplicate guard, so repeated Watch cannot enqueue duplicate rows. Remove names the same full key passed to the unchanged RemoveTag callback.
- Clear uses the original Search setter/cancellation lifecycle, preserving latest-search identity, debounce, cache-only scan cap and linked disposal. Search-result live text follows user search state, not value-poll updates. Clearing does not change watched values/subscription collections. Focus is restored to the still-rendered search field after render, with the disposal guard and circuit-disconnect handling.
- New hierarchy/search/watched-table regions have names and keyboard focusability. Long references remain ordinary untruncated source text. Native expansion buttons contain no nested interactive controls. The new coarse-pointer rules are scoped to the existing browse domain and leave shared typography/tokens intact.
Framework HtmlRenderer tests cover named lazy-node expansion, absence of leaf expansion, and persistent search label/hint/controlled-results markup (three Fact cases across two files). They do not dispatch DOM callbacks. The actual retained five-case confirmation supplies the interaction proof: keyboard expand/Watch, repeat-Watch deduplication, long-reference preservation, search/no-match/Clear/focus, retained subscriptions and scroll-to-Remove. All five recorded document widths fit their viewports, real zoom records720 CSS pixels/DPR2, coarse mode records pointer:coarse with44px targets, and errors is empty. The initial false coarse request is retained and correctly excluded from accepted touch proof.
The report appropriately limits acceptance to synthetic cached metadata/fake redacted reads and preserves live COM/ACL integration as outside this checkpoint. No complete MX chapter or deployment acceptance is implied. No additional test run was justified by this review because it found no new concern requiring reproduction.