Files
scadaproj/components/ui-theme/validation/theme-1.0.0/review-components.md
T

3.5 KiB

Independent component/source review — 1.0.0 candidate

Reviewed 2026-11-13 in the managed worktree. Scope: current TechField, TechButton and ThemeShell diffs; their new/retained tests; semantic/accent CSS and README contracts. This is source review, not a browser acceptance run or G1/TH-07 completion. Parent reports 105 full tests passing; this reviewer did not repeat that run or treat the old 0.5.0 localhost canary as evidence for the candidate.

Concrete finding

P2 — README field recipe treated an empty error as present (resolved). The example used null-only checks while TechField intentionally omits its error node for both null and empty string. With NameError = "", the example would set aria-invalid=true and reference missing name-error. Reported promptly; parent authorized the narrow correction. Both conditional attributes now use !string.IsNullOrEmpty(NameError), matching the component/test contract. No component behavior changed for this fix.

Review conclusions

  • Field associations: additive nullable For/HintId/ErrorId emit only caller-selected associations. ChildContent remains untouched; caller owns input IDs, describedby/invalid cleanup, focus and announcements. Tests cover repeated fields, absent content, error removal and compatibility without new parameters. No guessed child-control rewriting or hidden live regions introduced.
  • Busy/action behavior: explicit Busy state overrides splatted aria-busy, ORs with CallerDisabled, and retains existing type/size/class/callback behavior. BusyText replaces visible child label only when supplied and busy; original content returns afterward. Spinner remains decorative and caller-owned outcome text remains outside the component. Existing disabled string/boolean handling and class composition code are unchanged; new tests retain those contracts.
  • Accent scoping: optional companion values are emitted on the shell only; omitted values inherit. The compatibility alias is rebound at .app-shell, and active rail background directly uses --accent-tint, avoiding root-computed blue alias leakage into a green/purple shell. Component tests prove emission/rerender boundaries, not computed inheritance.
  • Bootstrap states: .btn-primary explicitly maps normal/hover/active/disabled color/background/border variables at component scope, rather than relying on root --bs-primary. Ghost/link button states map to scoped deep accent, with disabled text muted. Existing sizing/group seam rules remain. Browser computed-state verification remains required.
  • Semantic colors: Info notice/pill/read-tag ink uses dedicated --info-ink, independent of product brand. Status text uses semantic ink; signal colors remain for dots/chart marks. Contrast tests include paper/card/tint pairs and authored family action/deep text combinations.
  • Security/scope: new accent strings are documented trusted application configuration, extending the existing trusted Accent contract; they are not a remote theme editor. Razor still performs attribute encoding. No auth/domain behavior, routes, protocol, storage, or JavaScript lifecycle changes in these component API diffs.

No further concrete component implementation regression was found in this source pass. Shared focus/reduced-motion work and actual candidate browser checks were still pending at review time; do not infer their completion from this review. Verify focus-visible/disabled/busy states, label focus, mobile disclosure, zoom and reduced motion against the newly built candidate assets.