dohertj2/scadaproj
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

[Secrets] Add jitter to SqlServerSecretsStoreMigrator retry backoff + 8-way concurrent-migrate test #18

New Issue
Open
opened 2026-11-06 15:25:44 -05:00 by dohertj2 · 0 comments
dohertj2 commented 2026-11-06 15:25:44 -05:00
Owner
Copy Link
Copy Source

SqlServerSecretsStoreMigrator retries its DDL with a flat 100*attempt backoff and no jitter (ZB.MOM.WW.Secrets/src/ZB.MOM.WW.Secrets.Replicator.SqlServer/SqlServerSecretsStoreMigrator.cs:67, verified 2026-11-06). The identical loop ported into Auth 0.3.0's SqlServerApiKeyStoreMigrator exhausted its retries ~1 in 60 eight-way concurrent boots; adding jitter took it to 0/180. Secrets has no concurrent-migrate test, so the defect is presumed latent here (a 2-node central pair is only 2-way, so low practical risk).

Fix: mirror the Auth fix (jittered backoff) and add a Migrate_Concurrently_FromEightTasks_AllSucceed-shaped live test.

Source: ScadaBridge docs/plans/2026-07-08-deferred-work-register.md, register row 109 (belongs to scadaproj).

SqlServerSecretsStoreMigrator retries its DDL with a flat 100*attempt backoff and no jitter (ZB.MOM.WW.Secrets/src/ZB.MOM.WW.Secrets.Replicator.SqlServer/SqlServerSecretsStoreMigrator.cs:67, verified 2026-11-06). The identical loop ported into Auth 0.3.0's SqlServerApiKeyStoreMigrator exhausted its retries ~1 in 60 eight-way concurrent boots; adding jitter took it to 0/180. Secrets has no concurrent-migrate test, so the defect is presumed latent here (a 2-node central pair is only 2-way, so low practical risk). Fix: mirror the Auth fix (jittered backoff) and add a Migrate_Concurrently_FromEightTasks_AllSucceed-shaped live test. Source: ScadaBridge docs/plans/2026-07-08-deferred-work-register.md, register row 109 (belongs to scadaproj).
dohertj2 added the type:bugpriority:p3migrated labels 2026-11-06 15:25:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
blocked
Blocked by dependency or external hold
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label migrated priority:p3 type:bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/scadaproj#18
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?